From 305d63482ff4bcc26fa6e621103fb1626abee63f Mon Sep 17 00:00:00 2001 From: Thierry Vignaud Date: Wed, 26 Feb 2003 11:13:12 +0000 Subject: - remove unused variable (hey perl_checker, why didn't you see it ?) - (rename_field) better use the parameter we passed than relying on $_ be set to the right value in that context even if it was correct --- perl-install/standalone/harddrake2 | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'perl-install/standalone/harddrake2') diff --git a/perl-install/standalone/harddrake2 b/perl-install/standalone/harddrake2 index c826509de..902a2c4ef 100755 --- a/perl-install/standalone/harddrake2 +++ b/perl-install/standalone/harddrake2 @@ -179,7 +179,7 @@ my (%data, %configurators); $tree->append_column(my $pixcolumn = Gtk2::TreeViewColumn->new_with_attributes(undef, Gtk2::CellRendererPixbuf->new, 'pixbuf' => 0)); $tree->append_column(my $textcolumn = Gtk2::TreeViewColumn->new_with_attributes(undef, Gtk2::CellRendererText->new, 'text' => 1)); $tree->set_headers_visible(0); -my $selection = gtksignal_connect($tree->get_selection(), 'changed' => sub { +$tree->get_selection()->signal_connect('changed' => sub { my ($select) = @_; my ($model, $iter) = $select->get_selected(); if ($model) { @@ -324,12 +324,12 @@ sub strip_first_underscore { sub rename_field { my ($dev, $field, $new_field) = @_; - if ($_->{$field}) { - if ($_->{$new_field}) { - $_->{$new_field} .= " ($_->{$field})"; + if ($dev->{$field}) { + if ($dev->{$new_field}) { + $dev->{$new_field} .= " ($_->{$field})"; } else { - $_->{$new_field} = $_->{$field}; + $dev->{$new_field} = $_->{$field}; } - delete $_->{$field}; + delete $dev->{$field}; } } -- cgit v1.2.1