From 3021e910718c4702abe831c7aa53e8a7bf8b135f Mon Sep 17 00:00:00 2001 From: Pascal Rigaux Date: Wed, 6 Nov 2002 16:47:00 +0000 Subject: please perl_checker: - local'ize $_ before doing while (<...>) - use "foreach" instead of "for" - remove unneeded parentheses on the right side of infix if/foreach/unless --- perl-install/printerdrake.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'perl-install/printerdrake.pm') diff --git a/perl-install/printerdrake.pm b/perl-install/printerdrake.pm index b5c674702..32edbb867 100644 --- a/perl-install/printerdrake.pm +++ b/perl-install/printerdrake.pm @@ -177,7 +177,7 @@ sub detect { sub first_time_dialog { my ($printer, $in, $upNetwork) = @_; - return 1 if (printer::get_default_spooler () or $::isInstall); + return 1 if printer::get_default_spooler () or $::isInstall; # Wait message my $w = $in->wait_message(N("Printerdrake"), @@ -2452,7 +2452,7 @@ sub copy_queues_from { @oldqueues = sort(@oldqueues); $newspoolerstr = $printer::shortspooler_inv{$newspooler}; $oldspoolerstr = $printer::shortspooler_inv{$oldspooler}; - for (@oldqueues) { + foreach (@oldqueues) { push (@queuesselected, 1); push (@queueentries, { text => $_, type => 'bool', val => \$queuesselected[$#queuesselected] }); @@ -2488,7 +2488,7 @@ Mark the printers which you want to transfer and click \@queueentries )) { my $queuecopied = 0; - for (@oldqueues) { + foreach (@oldqueues) { if (shift(@queuesselected)) { my $oldqueue = $_; my $newqueue = $_; -- cgit v1.2.1