From b0fafbf9030544f0584a1eadc34c3aa5c8b24992 Mon Sep 17 00:00:00 2001 From: Thierry Vignaud Date: Fri, 17 May 2013 03:51:45 +0000 Subject: hint that nonfree is needed if a driver needs a nonfree firmware --- perl-install/install/NEWS | 2 ++ perl-install/install/any.pm | 7 ++++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/perl-install/install/NEWS b/perl-install/install/NEWS index 8d8ade1f0..03e283c5f 100644 --- a/perl-install/install/NEWS +++ b/perl-install/install/NEWS @@ -1,6 +1,8 @@ - do not enable legacy sysvinit scripts that no longer exist (mga#10084) - do not enable to pick xguest (mga#9750) - fix offering to install shorewall & shorewall-ipv6 when already installed +- media step: + o hint that nonfree is needed if a driver needs a nonfree firmware Version 15.52 - 15 May 2013 - fix displaying release notes while installing (mga#10087) diff --git a/perl-install/install/any.pm b/perl-install/install/any.pm index 3bae857ef..ed9ab1291 100644 --- a/perl-install/install/any.pm +++ b/perl-install/install/any.pm @@ -325,10 +325,15 @@ sub _nonfree_medium() { N("Nonfree Release") } # FIXME: move me in ../any.pm or in harddrake::*, might be needed by rpmdrake/harddrake: sub is_firmware_needed { my ($o) = @_; + require list_firmwares; + my @l = map { $_->{driver} } detect_devices::probeall(); + my @need = intersection(\@l, \@list_firmwares::modules_with_nonfree_firmware); + log::l("the following driver(s) need nonfree firmware(s): " . join(', ', @need)) if @need; + require pkgs; my @xpkgs = pkgs::detect_graphical_drivers($o->do_pkgs); log::l("the following nonfree firmware(s) are needed for X.org: " . join(', ', @xpkgs)) if @xpkgs; - @xpkgs; + @need || @xpkgs; } sub msg_if_firmware_needed { -- cgit v1.2.1