warnAboutNaughtyServers

3 files changed, 35 insertions, 0 deletions

diff --git a/perl-install/install_any.pm b/perl-install/install_any.pm
index 3876cff74..f884691b9 100644
--- a/perl-install/install_any.pm
+++ b/perl-install/install_any.pm
@@ -366,6 +366,24 @@ sub unselectMostPackages {
     pkgs::selectPackage($o->{packages}, pkgs::packageByName($o->{packages}, $_) || next) foreach @{$o->{default_packages}};
 }
 
+sub warnAboutNaughtyServers {
+    my ($o) = @_;
+    my @naughtyServers = pkgs::naughtyServers($o->{packages}) or return 1;
+    if (!$o->ask_yesorno('', 
+formatAlaTeX(_("You have selected the following server(s): %s
+
+
+These servers are activated by default. They don't have any known security
+issues, but some new could be found. In that case, you must make sure to upgrade
+as soon as possible.
+
+
+Do you really want to install these servers?
+", join(", ", @naughtyServers))), 1)) {
+	pkgs::unselectPackage($o->{packages}, pkgs::packageByName($o->{packages}, $_)) foreach @naughtyServers;
+    }
+}
+
 sub addToBeDone(&$) {
     my ($f, $step) = @_;
 
diff --git a/perl-install/install_steps_interactive.pm b/perl-install/install_steps_interactive.pm
index 399e40b6d..4c553de0e 100644
--- a/perl-install/install_steps_interactive.pm
+++ b/perl-install/install_steps_interactive.pm
@@ -500,6 +500,8 @@ sub choosePackages {
       pkgs::setSelectedFromCompssList($packages, $o->{compssUsersChoice}, $min_mark, $size2install);
 
     $o->choosePackagesTree($packages) if $individual;
+
+    install_any::warnAboutNaughtyServers($o);
 }
 
 sub chooseSizeToInstall {
diff --git a/perl-install/pkgs.pm b/perl-install/pkgs.pm
index e5e17923b..d17f74407 100644
--- a/perl-install/pkgs.pm
+++ b/perl-install/pkgs.pm
@@ -1495,4 +1495,19 @@ sub selected_leaves {
     } grep { $l{$_} } keys %l ];
 }
 
+
+sub naughtyServers {
+    my ($packages) = @_;
+
+    my @naughtyServers = qw(FreeWnn MySQL am-utils boa cfengine cups
+finger-server freeswan imap jabber leafnode lpr mon ntp
+openssh-server pidentd postfix postgresql-server proftpd rwall rwho
+telnet-server webmin wu-ftpd ypbind); # portmap nfs-utils-clients
+
+    grep {
+	my $p = packageByName($packages, $_);
+	$p && packageFlagSelected($p);
+    } @naughtyServers;
+}
+
 1;