summaryrefslogtreecommitdiffstats
path: root/perl-install/Xconfig
diff options
context:
space:
mode:
authorPascal Rigaux <pixel@mandriva.com>2002-11-06 16:47:00 +0000
committerPascal Rigaux <pixel@mandriva.com>2002-11-06 16:47:00 +0000
commit3021e910718c4702abe831c7aa53e8a7bf8b135f (patch)
treee342014ee05783e78a37b18970bd6168610c30f8 /perl-install/Xconfig
parent371749c6a25c7aec0874e21d68ec212b2bf2dab7 (diff)
downloaddrakx-backup-do-not-use-3021e910718c4702abe831c7aa53e8a7bf8b135f.tar
drakx-backup-do-not-use-3021e910718c4702abe831c7aa53e8a7bf8b135f.tar.gz
drakx-backup-do-not-use-3021e910718c4702abe831c7aa53e8a7bf8b135f.tar.bz2
drakx-backup-do-not-use-3021e910718c4702abe831c7aa53e8a7bf8b135f.tar.xz
drakx-backup-do-not-use-3021e910718c4702abe831c7aa53e8a7bf8b135f.zip
please perl_checker:
- local'ize $_ before doing while (<...>) - use "foreach" instead of "for" - remove unneeded parentheses on the right side of infix if/foreach/unless
Diffstat (limited to 'perl-install/Xconfig')
-rw-r--r--perl-install/Xconfig/test.pm5
-rw-r--r--perl-install/Xconfig/xfree4.pm2
2 files changed, 5 insertions, 2 deletions
diff --git a/perl-install/Xconfig/test.pm b/perl-install/Xconfig/test.pm
index d5b2f1334..38d9f9377 100644
--- a/perl-install/Xconfig/test.pm
+++ b/perl-install/Xconfig/test.pm
@@ -67,12 +67,14 @@ sub test {
my $b = before_leaving { unlink $f_err };
if (!xtest(":9")) {
- local $_;
local *F; open F, $f_err;
+
+ local $_;
i: while (<F>) {
if (Xconfig::card::using_xf4($card)) {
if (/^\(EE\)/ && !/Disabling/ || /^Fatal\b/) {
my @msg = !/error/ && $_ ;
+ local $_;
while (<F>) {
/reporting a problem/ and last;
push @msg, $_;
@@ -83,6 +85,7 @@ sub test {
} else {
if (/\b(error|not supported)\b/i) {
my @msg = !/error/ && $_ ;
+ local $_;
while (<F>) {
/not fatal/ and last i;
/^$/ and last;
diff --git a/perl-install/Xconfig/xfree4.pm b/perl-install/Xconfig/xfree4.pm
index 542226000..88cad5b06 100644
--- a/perl-install/Xconfig/xfree4.pm
+++ b/perl-install/Xconfig/xfree4.pm
@@ -49,7 +49,7 @@ sub new_mouse_sections {
} (1 .. $nb_new);
push @$layout, { val => qq("Mouse1" "CorePointer") };
- push @$layout, { val => qq("Mouse$_" "SendCoreEvents") } foreach (2 .. $nb_new);
+ push @$layout, { val => qq("Mouse$_" "SendCoreEvents") } foreach 2 .. $nb_new;
@l;
}