diff options
author | Pascal Rigaux <pixel@mandriva.com> | 2002-11-06 16:47:00 +0000 |
---|---|---|
committer | Pascal Rigaux <pixel@mandriva.com> | 2002-11-06 16:47:00 +0000 |
commit | 3021e910718c4702abe831c7aa53e8a7bf8b135f (patch) | |
tree | e342014ee05783e78a37b18970bd6168610c30f8 /perl-install/Xconfig/test.pm | |
parent | 371749c6a25c7aec0874e21d68ec212b2bf2dab7 (diff) | |
download | drakx-backup-do-not-use-3021e910718c4702abe831c7aa53e8a7bf8b135f.tar drakx-backup-do-not-use-3021e910718c4702abe831c7aa53e8a7bf8b135f.tar.gz drakx-backup-do-not-use-3021e910718c4702abe831c7aa53e8a7bf8b135f.tar.bz2 drakx-backup-do-not-use-3021e910718c4702abe831c7aa53e8a7bf8b135f.tar.xz drakx-backup-do-not-use-3021e910718c4702abe831c7aa53e8a7bf8b135f.zip |
please perl_checker:
- local'ize $_ before doing while (<...>)
- use "foreach" instead of "for"
- remove unneeded parentheses on the right side of infix if/foreach/unless
Diffstat (limited to 'perl-install/Xconfig/test.pm')
-rw-r--r-- | perl-install/Xconfig/test.pm | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/perl-install/Xconfig/test.pm b/perl-install/Xconfig/test.pm index d5b2f1334..38d9f9377 100644 --- a/perl-install/Xconfig/test.pm +++ b/perl-install/Xconfig/test.pm @@ -67,12 +67,14 @@ sub test { my $b = before_leaving { unlink $f_err }; if (!xtest(":9")) { - local $_; local *F; open F, $f_err; + + local $_; i: while (<F>) { if (Xconfig::card::using_xf4($card)) { if (/^\(EE\)/ && !/Disabling/ || /^Fatal\b/) { my @msg = !/error/ && $_ ; + local $_; while (<F>) { /reporting a problem/ and last; push @msg, $_; @@ -83,6 +85,7 @@ sub test { } else { if (/\b(error|not supported)\b/i) { my @msg = !/error/ && $_ ; + local $_; while (<F>) { /not fatal/ and last i; /^$/ and last; |