From d115020f6badfb7e39d08d8d9c71754a59db0d86 Mon Sep 17 00:00:00 2001 From: Pascal Terjan Date: Mon, 3 Oct 2011 13:39:00 +0000 Subject: Remove a system("cp") and add a FIXME --- lib/Youri/Submit/Post/CleanRpmsrate.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Youri/Submit/Post/CleanRpmsrate.pm b/lib/Youri/Submit/Post/CleanRpmsrate.pm index 899c80f..05fb386 100644 --- a/lib/Youri/Submit/Post/CleanRpmsrate.pm +++ b/lib/Youri/Submit/Post/CleanRpmsrate.pm @@ -35,8 +35,8 @@ sub run { my $rpmsrate = "$root/$target/$arch/media/media_info/rpmsrate"; # FIXME: have a method to get core/release instead of hardcoding it my @media = "$root/$target/$arch/media/core/release"; - system("cp", "$rpmsrate-raw", "$rpmsrate-new"); - system("clean-rpmsrate", "$rpmsrate-new", @media); + system("clean-rpmsrate", "-o", "$rpmsrate-new", "$rpmsrate-raw", @media); + # FIXME: unlink instead of mv if the content did not change system("mv", "-f", "$rpmsrate-new", $rpmsrate); } return -- cgit v1.2.1