From c666df4d74b5888e18a417641ad922776dddc393 Mon Sep 17 00:00:00 2001 From: Olivier Blin Date: Fri, 8 Feb 2008 17:43:40 +0000 Subject: use scalar for fd --- lib/Youri/Submit/Check/Rpmlint.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Youri/Submit/Check/Rpmlint.pm b/lib/Youri/Submit/Check/Rpmlint.pm index da2240d..be6eaba 100644 --- a/lib/Youri/Submit/Check/Rpmlint.pm +++ b/lib/Youri/Submit/Check/Rpmlint.pm @@ -66,8 +66,8 @@ sub run { my @errors; my $command = "$self->{_path} -f $self->{_config} " . $package->as_file(); - open(RPMLINT, "$command |") or die "Can't run $command: $!"; - while (my $line = ) { + open(my $RPMLINT, "$command |") or die "Can't run $command: $!"; + while (my $line = <$RPMLINT>) { $line =~ /^[EW]: \S+ (\S+)(.*)$/ # old rpmlint format || $line =~ /^\S+: [EW]: (\S+)(.*)$/ or next; # new rpmlint format my ($id, $value) = ($1, $2); -- cgit v1.2.1