From 90a3c3e5a22de5b8a2c26c2fd7238152fc9e7def Mon Sep 17 00:00:00 2001
From: Gustavo De Nardin <spuk@mandriva.org>
Date: Tue, 8 May 2007 07:20:43 +0000
Subject: FIXME note for evil code

---
 lib/Youri/Repository/Mandriva_upload.pm | 3 +++
 1 file changed, 3 insertions(+)

(limited to 'lib')

diff --git a/lib/Youri/Repository/Mandriva_upload.pm b/lib/Youri/Repository/Mandriva_upload.pm
index 381aee5..e983a4a 100644
--- a/lib/Youri/Repository/Mandriva_upload.pm
+++ b/lib/Youri/Repository/Mandriva_upload.pm
@@ -386,6 +386,9 @@ sub _get_section {
         }
     }
 
+    # FIXME: doing this here is wrong; this way the caller can never know if
+    # a section was actually found or not; should return undef and let the
+    # caller set a default (Note: IIRC PLF|Zarb has this right, see there) -spuk
     print STDERR "Warning: Can't guess destination: section missing, defaulting to contrib/release\n" unless $section;
     $section ||= 'contrib/release';
 
-- 
cgit v1.2.1