aboutsummaryrefslogtreecommitdiffstats
path: root/lib
diff options
context:
space:
mode:
authorPascal Terjan <pterjan@mageia.org>2022-04-25 14:10:47 +0000
committerPascal Terjan <pterjan@mageia.org>2022-04-25 14:16:06 +0000
commit1be1c9d62000e1fa7aedce432957e379bdeb305c (patch)
treec8b1d0a20ca197113d905ada014423035d963e47 /lib
parent9834b77b7a810dffd2bc661bb926e8a1d8696878 (diff)
downloadiurt-1be1c9d62000e1fa7aedce432957e379bdeb305c.tar
iurt-1be1c9d62000e1fa7aedce432957e379bdeb305c.tar.gz
iurt-1be1c9d62000e1fa7aedce432957e379bdeb305c.tar.bz2
iurt-1be1c9d62000e1fa7aedce432957e379bdeb305c.tar.xz
iurt-1be1c9d62000e1fa7aedce432957e379bdeb305c.zip
ulri: rely on status.log to know a build completed
This will fix packages not marked as noarch but having only noarch subpackages, even if we still end up wasting resources. The only risk I see is if the noarch packages get built on all mandatory architectures first, upload starts and other architectures complete in hte middle, however this should not modify the files being uploaded, we use a temporary file and rename so it should be fine.
Diffstat (limited to 'lib')
-rw-r--r--lib/Iurt/Emi.pm3
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/Iurt/Emi.pm b/lib/Iurt/Emi.pm
index ee87526..bf76a64 100644
--- a/lib/Iurt/Emi.pm
+++ b/lib/Iurt/Emi.pm
@@ -152,7 +152,8 @@ sub upload_prefix_in_media {
plog('OK', " uploading $rpm in $done/$path");
}
- # This should not happen :(
+ # When a package is not marked as noarch but only has noarch subpackages, there will be nothing
+ # left to upload when it finishes building on non mandaory arch.
return unless @packages;
my $command = generate_upload_command($prefix, $media, $target, $user, \@packages, $o_finish, "$done$path/$youri_file");