From cd2fe6bf1129641d59614d6382c5819acd8252e4 Mon Sep 17 00:00:00 2001 From: Martin Whitaker Date: Mon, 18 Dec 2017 17:16:57 +0000 Subject: Add 'use strict' to all submodules and fix up resulting error. Except in Loopback.pm, where it introduces an unresolved error. --- lib/MGA/DrakISO/Config.pm | 2 ++ lib/MGA/DrakISO/CustomMedia.pm | 2 ++ lib/MGA/DrakISO/Live.pm | 4 +++- lib/MGA/DrakISO/Media.pm | 2 ++ lib/MGA/DrakISO/Mounts.pm | 2 ++ lib/MGA/DrakISO/Progress.pm | 2 ++ lib/MGA/DrakISO/Storage.pm | 2 ++ lib/MGA/DrakISO/StorageFS.pm | 2 ++ lib/MGA/DrakISO/Utils.pm | 2 ++ 9 files changed, 19 insertions(+), 1 deletion(-) diff --git a/lib/MGA/DrakISO/Config.pm b/lib/MGA/DrakISO/Config.pm index a8b8e88..9251699 100644 --- a/lib/MGA/DrakISO/Config.pm +++ b/lib/MGA/DrakISO/Config.pm @@ -1,5 +1,7 @@ package MGA::DrakISO::Config; +use strict; + use MDK::Common; use Pod::Usage; use Cwd 'getcwd'; diff --git a/lib/MGA/DrakISO/CustomMedia.pm b/lib/MGA/DrakISO/CustomMedia.pm index c01d480..821ee94 100644 --- a/lib/MGA/DrakISO/CustomMedia.pm +++ b/lib/MGA/DrakISO/CustomMedia.pm @@ -1,5 +1,7 @@ package MGA::DrakISO::CustomMedia; +use strict; + sub nfs_media { my ($module, $client, $path) = @_; ( diff --git a/lib/MGA/DrakISO/Live.pm b/lib/MGA/DrakISO/Live.pm index 6fa32af..f3e6be5 100644 --- a/lib/MGA/DrakISO/Live.pm +++ b/lib/MGA/DrakISO/Live.pm @@ -1,5 +1,7 @@ package MGA::DrakISO::Live; +use strict; + use MDK::Common; sub new { @@ -10,7 +12,7 @@ sub new { sub default_name_fields { my ($live) = @_; [ qw(name version product desktop), - if_($live->{settings}{region} ne 'all', region), + if_($live->{settings}{region} ne 'all', $live->{settings}{region}), qw(arch media) ]; } diff --git a/lib/MGA/DrakISO/Media.pm b/lib/MGA/DrakISO/Media.pm index 97e21ab..169d22d 100644 --- a/lib/MGA/DrakISO/Media.pm +++ b/lib/MGA/DrakISO/Media.pm @@ -1,5 +1,7 @@ package MGA::DrakISO::Media; +use strict; + use MDK::Common; use MGA::DrakISO::Storage; use POSIX; diff --git a/lib/MGA/DrakISO/Mounts.pm b/lib/MGA/DrakISO/Mounts.pm index 07cd5b6..c3c408d 100644 --- a/lib/MGA/DrakISO/Mounts.pm +++ b/lib/MGA/DrakISO/Mounts.pm @@ -1,5 +1,7 @@ package MGA::DrakISO::Mounts; +use strict; + use MDK::Common; my $dir_distrib_sqfs = { diff --git a/lib/MGA/DrakISO/Progress.pm b/lib/MGA/DrakISO/Progress.pm index 40e442e..c3e55bc 100644 --- a/lib/MGA/DrakISO/Progress.pm +++ b/lib/MGA/DrakISO/Progress.pm @@ -1,5 +1,7 @@ package MGA::DrakISO::Progress; +use strict; + use POSIX qw(strftime); sub new { diff --git a/lib/MGA/DrakISO/Storage.pm b/lib/MGA/DrakISO/Storage.pm index 6402cd2..9949e76 100644 --- a/lib/MGA/DrakISO/Storage.pm +++ b/lib/MGA/DrakISO/Storage.pm @@ -1,5 +1,7 @@ package MGA::DrakISO::Storage; +use strict; + use detect_devices; our %storage_types = ( diff --git a/lib/MGA/DrakISO/StorageFS.pm b/lib/MGA/DrakISO/StorageFS.pm index 05c62d4..371fb80 100644 --- a/lib/MGA/DrakISO/StorageFS.pm +++ b/lib/MGA/DrakISO/StorageFS.pm @@ -1,5 +1,7 @@ package MGA::DrakISO::StorageFS; +use strict; + use MDK::Common; my %storage_fs; diff --git a/lib/MGA/DrakISO/Utils.pm b/lib/MGA/DrakISO/Utils.pm index a2abd17..11295c9 100644 --- a/lib/MGA/DrakISO/Utils.pm +++ b/lib/MGA/DrakISO/Utils.pm @@ -1,5 +1,7 @@ package MGA::DrakISO::Utils; +use strict; + use MDK::Common; use common; use fs; -- cgit v1.2.1