From 8f68f36bb950456e7b88557599a2ddef628153f5 Mon Sep 17 00:00:00 2001 From: Michael Scherer Date: Sat, 18 Feb 2012 17:17:15 +0000 Subject: some cleaning ( ie, do not repeat default values ), some puppet-lint compliance --- modules/mgasoft/manifests/init.pp | 40 ++++++++++++++++----------------------- 1 file changed, 16 insertions(+), 24 deletions(-) (limited to 'modules/mgasoft') diff --git a/modules/mgasoft/manifests/init.pp b/modules/mgasoft/manifests/init.pp index 67a39a18..68c54ba7 100644 --- a/modules/mgasoft/manifests/init.pp +++ b/modules/mgasoft/manifests/init.pp @@ -5,41 +5,33 @@ class mgasoft( $svn_soft_publish = 'file:///svn/soft_publish', $mgasoft_login = 'mgasoft' ) { - group { $mgasoft_login: - ensure => present, - } + group { $mgasoft_login: } + user { $mgasoft_login: - ensure => present, - comment => "System user to publish software", - managehome => true, - home => "/var/lib/$mgasoft_login", - gid => $mgasoft_login, - require => Group[$mgasoft_login], + comment => 'System user to publish software', + managehome => true, + home => "/var/lib/$mgasoft_login", + gid => $mgasoft_login, + require => Group[$mgasoft_login], } - package { 'mgasoft-publish': - ensure => installed, - } + package { 'mgasoft-publish': } file { '/etc/mgasoft.conf': - ensure => present, - owner => root, - group => root, - mode => 644, - content => template('mgasoft/mgasoft.conf'), + content => template('mgasoft/mgasoft.conf'), } subversion::snapshot { $pubinfodir: - source => $svn_soft_publish, - user => $mgasoft_login, - refresh => '0', - require => User[$mgasoft_login], + source => $svn_soft_publish, + user => $mgasoft_login, + refresh => '0', + require => User[$mgasoft_login], } cron { "mgasoft-publish": - command => '/usr/bin/mgasoft-publish', - user => $mgasoft_login, - minute => '*/5', + command => '/usr/bin/mgasoft-publish', + user => $mgasoft_login, + minute => '*/5', require => User[$mgasoft_login], } } -- cgit v1.2.1