From 467c794b9779412cf2cc29deb42c232168989486 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Fri, 29 May 2015 16:05:16 +0200 Subject: [ticket/6466] Use jQuery and custom dropdown for permission roles tooltips PHPBB3-6466 --- phpBB/adm/style/acp_permissions.html | 11 +-- phpBB/adm/style/admin.css | 33 +++++++++ phpBB/adm/style/permission_mask.html | 13 +++- phpBB/adm/style/tooltip.js | 127 ++++++++++++++++++----------------- 4 files changed, 113 insertions(+), 71 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/acp_permissions.html b/phpBB/adm/style/acp_permissions.html index 6dc9dca2e7..004027df41 100644 --- a/phpBB/adm/style/acp_permissions.html +++ b/phpBB/adm/style/acp_permissions.html @@ -327,14 +327,9 @@

- - - -
+ + + {S_HIDDEN_FIELDS} diff --git a/phpBB/adm/style/admin.css b/phpBB/adm/style/admin.css index b03cb0ba24..8ae39b7754 100644 --- a/phpBB/adm/style/admin.css +++ b/phpBB/adm/style/admin.css @@ -2435,6 +2435,39 @@ fieldset.permissions .padding { display: none !important; } +.roles-options > .dropdown { + left: auto; + top: 3em; + width: 250px; +} + +.roles-options { + -webkit-user-select: none; + -moz-user-select: none; + -ms-user-select: none; + -o-user-select: none; + user-select: none; + width: 250px; +} + +.roles-options > span { + border: 1px solid #DEDEDE; + border-radius: 3px; + padding: 4px; + width: 250px; + display: block; + background: url('../images/arrow_down.gif') no-repeat 245px .7em; +} + +.roles-options li { + list-style: none; +} + +.roles-highlight { + background-color: #1e90ff; + color: #fff; +} + /* Classes for additional tasks ---------------------------------------- */ diff --git a/phpBB/adm/style/permission_mask.html b/phpBB/adm/style/permission_mask.html index 7b5c071693..5aeafba476 100644 --- a/phpBB/adm/style/permission_mask.html +++ b/phpBB/adm/style/permission_mask.html @@ -40,7 +40,18 @@
-
+
+ +
{L_NO_ROLE_AVAILABLE}
diff --git a/phpBB/adm/style/tooltip.js b/phpBB/adm/style/tooltip.js index 3a89008706..ec170ef6b2 100644 --- a/phpBB/adm/style/tooltip.js +++ b/phpBB/adm/style/tooltip.js @@ -10,7 +10,12 @@ phpBB Development Team: - further adjustements */ -var head_text, tooltip_mode; +(function($) { // Avoid conflicts with other libraries + +"use strict"; + +var head_text, tooltip_mode, tooltips; +tooltips = []; /** * Enable tooltip replacements for links @@ -54,7 +59,7 @@ function enable_tooltips_link(id, headline, sub_id) { * Enable tooltip replacements for selects */ function enable_tooltips_select(id, headline, sub_id) { - var links, i, hold; + var $links, hold; head_text = headline; @@ -66,24 +71,25 @@ function enable_tooltips_select(id, headline, sub_id) { hold.id = '_tooltip_container'; hold.setAttribute('id', '_tooltip_container'); hold.style.position = 'absolute'; - - document.getElementsByTagName('body')[0].appendChild(hold); + $('body').append(hold); if (id === null) { - links = document.getElementsByTagName('option'); + $links = $('.roles-options li'); } else { - links = document.getElementById(id).getElementsByTagName('option'); + $links = $('#' + id + ' .roles-options li'); } - for (i = 0; i < links.length; i++) { + $links.each(function () { + var $this = $(this); + if (sub_id) { - if (links[i].parentNode.id.substr(0, sub_id.length) === sub_id) { - prepare(links[i]); + if ($this.parent().attr('id').substr(0, sub_id.length) === sub_id) { + prepare($this); } } else { - prepare(links[i]); + prepare($this); } - } + }); tooltip_mode = 'select'; } @@ -91,16 +97,15 @@ function enable_tooltips_select(id, headline, sub_id) { /** * Prepare elements to replace */ -function prepare(element) { +function prepare($element) { var tooltip, text, desc, title; - text = element.getAttribute('title'); + text = $element.attr('data-title');; if (text === null || text.length === 0) { return; } - element.removeAttribute('title'); tooltip = create_element('span', 'tooltip'); title = create_element('span', 'top'); @@ -113,12 +118,12 @@ function prepare(element) { set_opacity(tooltip); - element.tooltip = tooltip; - element.onmouseover = show_tooltip; - element.onmouseout = hide_tooltip; + tooltips[$element.attr('data-id')] = tooltip; + $element.on('mouseover', show_tooltip); + $element.on('mouseout', hide_tooltip); if (tooltip_mode === 'link') { - element.onmousemove = locate; + $element.onmousemove = locate; } } @@ -126,8 +131,9 @@ function prepare(element) { * Show tooltip */ function show_tooltip(e) { - document.getElementById('_tooltip_container').appendChild(this.tooltip); - locate(this); + var $this = $(e.target); + $('#_tooltip_container').append(tooltips[$this.attr('data-id')]); + locate($this); } /** @@ -164,52 +170,49 @@ function create_element(tag, c) { * Correct positioning of tooltip container */ function locate(e) { - var posx = 0; - var posy = 0; - - e = e.parentNode; + var offset; - if (e.offsetParent) { - for (posx = 0, posy = 0; e.offsetParent; e = e.offsetParent) { - posx += e.offsetLeft; - posy += e.offsetTop; - } - } else { - posx = e.offsetLeft; - posy = e.offsetTop; - } + e = e.parent(); + offset = e.offset(); if (tooltip_mode === 'link') { - document.getElementById('_tooltip_container').style.top=(posy+20) + 'px'; - document.getElementById('_tooltip_container').style.left=(posx-20) + 'px'; + $('#_tooltip_container').css({ + top: offset.top + 20, + left: offset.left - 20 + }); } else { - document.getElementById('_tooltip_container').style.top=(posy+30) + 'px'; - document.getElementById('_tooltip_container').style.left=(posx-205) + 'px'; + $('#_tooltip_container').css({ + top: offset.top + 30, + left: offset.left - 205 + }); } +} -/* - if (e == null) - { - e = window.event; - } +$(function() { + var $options; - if (e.pageX || e.pageY) - { - posx = e.pageX; - posy = e.pageY; - } - else if (e.clientX || e.clientY) - { - if (document.documentElement.scrollTop) - { - posx = e.clientX+document.documentElement.scrollLeft; - posy = e.clientY+document.documentElement.scrollTop; - } - else - { - posx = e.clientX+document.body.scrollLeft; - posy = e.clientY+document.body.scrollTop; - } - } -*/ -} + // Enable tooltips + enable_tooltips_select('set-permissions', $('#set-permissions').attr('data-role-description'), 'role'); + + $options = $('.roles-options li'); + + // Prepare highlighting of select options and settings update + $options.each(function () { + $(this).on('mouseover', function (e) { + var $this = $(this); + $options.removeClass('roles-highlight'); + $this.addClass('roles-highlight'); + }).on('click', function (e) { + var $this = $(this); + + // Update settings + set_role_settings($this.attr('data-id'), $this.attr('data-target-id')); + init_colours($this.attr('data-target-id').replace('advanced', '')); + + // Set selected setting + $this.closest('.roles-options').children('span').text($this.text()); + }); + }); +}); + +})(jQuery); // Avoid conflicts with other libraries -- cgit v1.2.1 From fc00447520d19ac2e0c6667f1c2cf5e7b41913a2 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Fri, 29 May 2015 16:44:12 +0200 Subject: [ticket/6466] Improve behavior of select and properly save role PHPBB3-6466 --- phpBB/adm/style/permission_mask.html | 5 +++-- phpBB/adm/style/tooltip.js | 17 +++++++++++++++-- 2 files changed, 18 insertions(+), 4 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/permission_mask.html b/phpBB/adm/style/permission_mask.html index 5aeafba476..7569867f8c 100644 --- a/phpBB/adm/style/permission_mask.html +++ b/phpBB/adm/style/permission_mask.html @@ -44,12 +44,13 @@ diff --git a/phpBB/adm/style/tooltip.js b/phpBB/adm/style/tooltip.js index ec170ef6b2..60222e51d5 100644 --- a/phpBB/adm/style/tooltip.js +++ b/phpBB/adm/style/tooltip.js @@ -198,7 +198,16 @@ $(function() { // Prepare highlighting of select options and settings update $options.each(function () { - $(this).on('mouseover', function (e) { + var $this = $(this); + var $roles_options = $this.closest('.roles-options'); + + // Correctly show selected option + if (typeof $this.attr('data-selected') !== 'undefined') { + $this.closest('.roles-options').children('span').text($this.text()); + $('') + } + + $this.on('mouseover', function (e) { var $this = $(this); $options.removeClass('roles-highlight'); $this.addClass('roles-highlight'); @@ -210,7 +219,11 @@ $(function() { init_colours($this.attr('data-target-id').replace('advanced', '')); // Set selected setting - $this.closest('.roles-options').children('span').text($this.text()); + $roles_options.children('span').text($this.text()); + $roles_options.children('input[type=hidden]').val($this.attr('data-id')); + + // Trigger hiding of selection options + $('body').trigger('click'); }); }); }); -- cgit v1.2.1 From 4d827b5b994f5efa2ec79583a87facb01897727f Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Fri, 29 May 2015 16:56:24 +0200 Subject: [ticket/6466] Remove remnants of old code PHPBB3-6466 --- phpBB/adm/style/permission_mask.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/permission_mask.html b/phpBB/adm/style/permission_mask.html index 7569867f8c..91894ebc77 100644 --- a/phpBB/adm/style/permission_mask.html +++ b/phpBB/adm/style/permission_mask.html @@ -39,7 +39,7 @@
- + {% if role_options %}
- + {% else %}
{L_NO_ROLE_AVAILABLE}
- + {% endif %}
-- cgit v1.2.1 From faa5ab5899afc1023c7b42bd835e98c42d70eaa4 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Fri, 29 May 2015 17:06:14 +0200 Subject: [ticket/6466] Improved code in tooltip.js PHPBB3-6466 --- phpBB/adm/style/tooltip.js | 37 ++++++++++++++++++++++++------------- 1 file changed, 24 insertions(+), 13 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/tooltip.js b/phpBB/adm/style/tooltip.js index 60222e51d5..feaa698c9a 100644 --- a/phpBB/adm/style/tooltip.js +++ b/phpBB/adm/style/tooltip.js @@ -12,7 +12,7 @@ phpBB Development Team: (function($) { // Avoid conflicts with other libraries -"use strict"; +'use strict'; var head_text, tooltip_mode, tooltips; tooltips = []; @@ -56,7 +56,10 @@ function enable_tooltips_link(id, headline, sub_id) { } /** -* Enable tooltip replacements for selects + * Enable tooltip replacements for selects + * @param {string} id ID tag of select + * @param {string} headline Text that should appear on top of tooltip + * @param {string} sub_id Sub ID that should only be using tooltips (optional) */ function enable_tooltips_select(id, headline, sub_id) { var $links, hold; @@ -76,7 +79,7 @@ function enable_tooltips_select(id, headline, sub_id) { if (id === null) { $links = $('.roles-options li'); } else { - $links = $('#' + id + ' .roles-options li'); + $links = $('.roles-options li', '#' + id); } $links.each(function () { @@ -95,7 +98,9 @@ function enable_tooltips_select(id, headline, sub_id) { } /** -* Prepare elements to replace + * Prepare elements to replace + * + * @param {object} $element Element to prepare for tooltips */ function prepare($element) { var tooltip, text, desc, title; @@ -128,18 +133,22 @@ function prepare($element) { } /** -* Show tooltip + * Show tooltip + * + * @param {object} $element Element passed by .on() */ -function show_tooltip(e) { - var $this = $(e.target); +function show_tooltip($element) { + var $this = $($element.target); $('#_tooltip_container').append(tooltips[$this.attr('data-id')]); locate($this); } /** -* Hide tooltip + * Hide tooltip + * + * @param {object} $element Element passed by .on() */ -function hide_tooltip(e) { +function hide_tooltip($element) { var d = document.getElementById('_tooltip_container'); if (d.childNodes.length > 0) { d.removeChild(d.firstChild); @@ -167,13 +176,15 @@ function create_element(tag, c) { } /** -* Correct positioning of tooltip container + * Correct positioning of tooltip container + * + * @param {object} $element Tooltip element that should be positioned */ -function locate(e) { +function locate($element) { var offset; - e = e.parent(); - offset = e.offset(); + $element = $element.parent(); + offset = $element.offset(); if (tooltip_mode === 'link') { $('#_tooltip_container').css({ -- cgit v1.2.1 From 795776db4b09195e098d5c9dfd1b2fc8b4012be4 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Fri, 29 May 2015 17:07:47 +0200 Subject: [ticket/6466] Removed link tooltip It wasn't being used anymore and didn't work anymore. PHPBB3-6466 --- phpBB/adm/style/tooltip.js | 61 ++++------------------------------------------ 1 file changed, 5 insertions(+), 56 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/tooltip.js b/phpBB/adm/style/tooltip.js index feaa698c9a..5850fa43c2 100644 --- a/phpBB/adm/style/tooltip.js +++ b/phpBB/adm/style/tooltip.js @@ -14,47 +14,9 @@ phpBB Development Team: 'use strict'; -var head_text, tooltip_mode, tooltips; +var head_text, tooltips; tooltips = []; -/** -* Enable tooltip replacements for links -*/ -function enable_tooltips_link(id, headline, sub_id) { - var links, i, hold; - - head_text = headline; - - if (!document.getElementById || !document.getElementsByTagName) { - return; - } - - hold = document.createElement('span'); - hold.id = '_tooltip_container'; - hold.setAttribute('id', '_tooltip_container'); - hold.style.position = 'absolute'; - - document.getElementsByTagName('body')[0].appendChild(hold); - - if (id === null) { - links = document.getElementsByTagName('a'); - } else { - links = document.getElementById(id).getElementsByTagName('a'); - } - - for (i = 0; i < links.length; i++) { - if (sub_id) { - if (links[i].id.substr(0, sub_id.length) === sub_id) { - prepare(links[i]); - } - } else { - prepare(links[i]); - } - } - - tooltip_mode = 'link'; -} - /** * Enable tooltip replacements for selects * @param {string} id ID tag of select @@ -93,8 +55,6 @@ function enable_tooltips_select(id, headline, sub_id) { prepare($this); } }); - - tooltip_mode = 'select'; } /** @@ -126,10 +86,6 @@ function prepare($element) { tooltips[$element.attr('data-id')] = tooltip; $element.on('mouseover', show_tooltip); $element.on('mouseout', hide_tooltip); - - if (tooltip_mode === 'link') { - $element.onmousemove = locate; - } } /** @@ -186,17 +142,10 @@ function locate($element) { $element = $element.parent(); offset = $element.offset(); - if (tooltip_mode === 'link') { - $('#_tooltip_container').css({ - top: offset.top + 20, - left: offset.left - 20 - }); - } else { - $('#_tooltip_container').css({ - top: offset.top + 30, - left: offset.left - 205 - }); - } + $('#_tooltip_container').css({ + top: offset.top + 30, + left: offset.left - 205 + }); } $(function() { -- cgit v1.2.1 From 75e1cbdc7728329f1c5d7375417e891c8d764fb5 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Fri, 29 May 2015 17:08:17 +0200 Subject: [ticket/6466] Remove double semicolon PHPBB3-6466 --- phpBB/adm/style/tooltip.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/tooltip.js b/phpBB/adm/style/tooltip.js index 5850fa43c2..89736e40f7 100644 --- a/phpBB/adm/style/tooltip.js +++ b/phpBB/adm/style/tooltip.js @@ -65,7 +65,7 @@ function enable_tooltips_select(id, headline, sub_id) { function prepare($element) { var tooltip, text, desc, title; - text = $element.attr('data-title');; + text = $element.attr('data-title'); if (text === null || text.length === 0) { return; -- cgit v1.2.1 From abf0be4b4c7c646ad35e5943fda1f0bb4a5e2a84 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Fri, 29 May 2015 17:18:03 +0200 Subject: [ticket/6466] Get rid of useless variables and functions in tooltip.js PHPBB3-6466 --- phpBB/adm/style/admin.css | 1 + phpBB/adm/style/tooltip.js | 41 ++++++++++++++--------------------------- 2 files changed, 15 insertions(+), 27 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/admin.css b/phpBB/adm/style/admin.css index 8ae39b7754..145bcfaec1 100644 --- a/phpBB/adm/style/admin.css +++ b/phpBB/adm/style/admin.css @@ -1858,6 +1858,7 @@ li.pagination ul { color: #000; text-align: center; border: 1px solid #AAA; + opacity: .95; } .tooltip span.top { diff --git a/phpBB/adm/style/tooltip.js b/phpBB/adm/style/tooltip.js index 89736e40f7..8e05cec30b 100644 --- a/phpBB/adm/style/tooltip.js +++ b/phpBB/adm/style/tooltip.js @@ -14,8 +14,7 @@ phpBB Development Team: 'use strict'; -var head_text, tooltips; -tooltips = []; +var tooltips = []; /** * Enable tooltip replacements for selects @@ -26,12 +25,6 @@ tooltips = []; function enable_tooltips_select(id, headline, sub_id) { var $links, hold; - head_text = headline; - - if (!document.getElementById || !document.getElementsByTagName) { - return; - } - hold = document.createElement('span'); hold.id = '_tooltip_container'; hold.setAttribute('id', '_tooltip_container'); @@ -49,10 +42,10 @@ function enable_tooltips_select(id, headline, sub_id) { if (sub_id) { if ($this.parent().attr('id').substr(0, sub_id.length) === sub_id) { - prepare($this); + prepare($this, headline); } } else { - prepare($this); + prepare($this, headline); } }); } @@ -61,8 +54,9 @@ function enable_tooltips_select(id, headline, sub_id) { * Prepare elements to replace * * @param {object} $element Element to prepare for tooltips + * @param {string} head_text Text heading to display */ -function prepare($element) { +function prepare($element, head_text) { var tooltip, text, desc, title; text = $element.attr('data-title'); @@ -71,17 +65,15 @@ function prepare($element) { return; } - tooltip = create_element('span', 'tooltip'); - title = create_element('span', 'top'); title.appendChild(document.createTextNode(head_text)); - tooltip.appendChild(title); desc = create_element('span', 'bottom'); desc.innerHTML = text; - tooltip.appendChild(desc); - set_opacity(tooltip); + tooltip = create_element('span', 'tooltip'); + tooltip.appendChild(title); + tooltip.appendChild(desc); tooltips[$element.attr('data-id')] = tooltip; $element.on('mouseover', show_tooltip); @@ -112,17 +104,12 @@ function hide_tooltip($element) { } /** -* Set opacity on tooltip element -*/ -function set_opacity(element) { - element.style.filter = 'alpha(opacity:95)'; - element.style.KHTMLOpacity = '0.95'; - element.style.MozOpacity = '0.95'; - element.style.opacity = '0.95'; -} - -/** -* Create new element + * Create new element + * + * @param {string} tag HTML tag + * @param {string} c Element's class + * + * @return {object} Created element */ function create_element(tag, c) { var x = document.createElement(tag); -- cgit v1.2.1 From 120600e055c9220982ff4639f114d6bd60eaa41f Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Fri, 29 May 2015 17:34:42 +0200 Subject: [ticket/6466] Rename functions and clean up code PHPBB3-6466 --- phpBB/adm/style/tooltip.js | 64 +++++++++++++++++++++++++--------------------- 1 file changed, 35 insertions(+), 29 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/tooltip.js b/phpBB/adm/style/tooltip.js index 8e05cec30b..2798592c3d 100644 --- a/phpBB/adm/style/tooltip.js +++ b/phpBB/adm/style/tooltip.js @@ -22,7 +22,7 @@ var tooltips = []; * @param {string} headline Text that should appear on top of tooltip * @param {string} sub_id Sub ID that should only be using tooltips (optional) */ -function enable_tooltips_select(id, headline, sub_id) { +phpbb.enableTooltipsSelect = function (id, headline, sub_id) { var $links, hold; hold = document.createElement('span'); @@ -42,13 +42,13 @@ function enable_tooltips_select(id, headline, sub_id) { if (sub_id) { if ($this.parent().attr('id').substr(0, sub_id.length) === sub_id) { - prepare($this, headline); + phpbb.prepareTooltips($this, headline); } } else { - prepare($this, headline); + phpbb.prepareTooltips($this, headline); } }); -} +}; /** * Prepare elements to replace @@ -56,7 +56,7 @@ function enable_tooltips_select(id, headline, sub_id) { * @param {object} $element Element to prepare for tooltips * @param {string} head_text Text heading to display */ -function prepare($element, head_text) { +phpbb.prepareTooltips = function ($element, head_text) { var tooltip, text, desc, title; text = $element.attr('data-title'); @@ -65,43 +65,43 @@ function prepare($element, head_text) { return; } - title = create_element('span', 'top'); + title = phpbb.createElement('span', 'top'); title.appendChild(document.createTextNode(head_text)); - desc = create_element('span', 'bottom'); + desc = phpbb.createElement('span', 'bottom'); desc.innerHTML = text; - tooltip = create_element('span', 'tooltip'); + tooltip = phpbb.createElement('span', 'tooltip'); tooltip.appendChild(title); tooltip.appendChild(desc); tooltips[$element.attr('data-id')] = tooltip; - $element.on('mouseover', show_tooltip); - $element.on('mouseout', hide_tooltip); -} + $element.on('mouseover', phpbb.showTooltip); + $element.on('mouseout', phpbb.hideTooltip); +}; /** * Show tooltip * * @param {object} $element Element passed by .on() */ -function show_tooltip($element) { +phpbb.showTooltip = function ($element) { var $this = $($element.target); $('#_tooltip_container').append(tooltips[$this.attr('data-id')]); - locate($this); -} + phpbb.positionTooltip($this); +}; /** * Hide tooltip * * @param {object} $element Element passed by .on() */ -function hide_tooltip($element) { +phpbb.hideTooltip = function () { var d = document.getElementById('_tooltip_container'); if (d.childNodes.length > 0) { d.removeChild(d.firstChild); } -} +}; /** * Create new element @@ -111,19 +111,19 @@ function hide_tooltip($element) { * * @return {object} Created element */ -function create_element(tag, c) { +phpbb.createElement = function (tag, c) { var x = document.createElement(tag); x.className = c; x.style.display = 'block'; return x; -} +}; /** * Correct positioning of tooltip container * * @param {object} $element Tooltip element that should be positioned */ -function locate($element) { +phpbb.positionTooltip = function ($element) { var offset; $element = $element.parent(); @@ -133,25 +133,22 @@ function locate($element) { top: offset.top + 30, left: offset.left - 205 }); -} +}; -$(function() { - var $options; - - // Enable tooltips - enable_tooltips_select('set-permissions', $('#set-permissions').attr('data-role-description'), 'role'); - - $options = $('.roles-options li'); +/** + * Prepare roles drop down select + */ +phpbb.prepareRolesDropdown = function () { + var $options = $('.roles-options li'); // Prepare highlighting of select options and settings update - $options.each(function () { + $options.each(function (element) { var $this = $(this); var $roles_options = $this.closest('.roles-options'); // Correctly show selected option if (typeof $this.attr('data-selected') !== 'undefined') { $this.closest('.roles-options').children('span').text($this.text()); - $('') } $this.on('mouseover', function (e) { @@ -173,6 +170,15 @@ $(function() { $('body').trigger('click'); }); }); +}; + +// Run onload functions for RolesDropdown and tooltips +$(function() { + // Enable tooltips + phpbb.enableTooltipsSelect('set-permissions', $('#set-permissions').attr('data-role-description'), 'role'); + + // Prepare dropdown + phpbb.prepareRolesDropdown(); }); })(jQuery); // Avoid conflicts with other libraries -- cgit v1.2.1 From c8bb0fd24179f9c2d639e53c896dd28f7d5562f8 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Fri, 29 May 2015 17:35:53 +0200 Subject: [ticket/6466] Improve code in tooltip.js PHPBB3-6466 --- phpBB/adm/style/tooltip.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/tooltip.js b/phpBB/adm/style/tooltip.js index 2798592c3d..68750b8663 100644 --- a/phpBB/adm/style/tooltip.js +++ b/phpBB/adm/style/tooltip.js @@ -93,8 +93,6 @@ phpbb.showTooltip = function ($element) { /** * Hide tooltip - * - * @param {object} $element Element passed by .on() */ phpbb.hideTooltip = function () { var d = document.getElementById('_tooltip_container'); @@ -142,7 +140,7 @@ phpbb.prepareRolesDropdown = function () { var $options = $('.roles-options li'); // Prepare highlighting of select options and settings update - $options.each(function (element) { + $options.each(function () { var $this = $(this); var $roles_options = $this.closest('.roles-options'); -- cgit v1.2.1 From 0d5f074f54caeeffcc9deea840fb1dc59911a596 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Fri, 29 May 2015 17:39:03 +0200 Subject: [ticket/6466] Rename variables and remove unused ones PHPBB3-6466 --- phpBB/adm/style/tooltip.js | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/tooltip.js b/phpBB/adm/style/tooltip.js index 68750b8663..f78e1da81f 100644 --- a/phpBB/adm/style/tooltip.js +++ b/phpBB/adm/style/tooltip.js @@ -20,9 +20,9 @@ var tooltips = []; * Enable tooltip replacements for selects * @param {string} id ID tag of select * @param {string} headline Text that should appear on top of tooltip - * @param {string} sub_id Sub ID that should only be using tooltips (optional) + * @param {string} subId Sub ID that should only be using tooltips (optional) */ -phpbb.enableTooltipsSelect = function (id, headline, sub_id) { +phpbb.enableTooltipsSelect = function (id, headline, subId) { var $links, hold; hold = document.createElement('span'); @@ -31,7 +31,7 @@ phpbb.enableTooltipsSelect = function (id, headline, sub_id) { hold.style.position = 'absolute'; $('body').append(hold); - if (id === null) { + if (!id) { $links = $('.roles-options li'); } else { $links = $('.roles-options li', '#' + id); @@ -40,8 +40,8 @@ phpbb.enableTooltipsSelect = function (id, headline, sub_id) { $links.each(function () { var $this = $(this); - if (sub_id) { - if ($this.parent().attr('id').substr(0, sub_id.length) === sub_id) { + if (subId) { + if ($this.parent().attr('id').substr(0, subId.length) === subId) { phpbb.prepareTooltips($this, headline); } } else { @@ -54,9 +54,9 @@ phpbb.enableTooltipsSelect = function (id, headline, sub_id) { * Prepare elements to replace * * @param {object} $element Element to prepare for tooltips - * @param {string} head_text Text heading to display + * @param {string} headText Text heading to display */ -phpbb.prepareTooltips = function ($element, head_text) { +phpbb.prepareTooltips = function ($element, headText) { var tooltip, text, desc, title; text = $element.attr('data-title'); @@ -66,7 +66,7 @@ phpbb.prepareTooltips = function ($element, head_text) { } title = phpbb.createElement('span', 'top'); - title.appendChild(document.createTextNode(head_text)); + title.appendChild(document.createTextNode(headText)); desc = phpbb.createElement('span', 'bottom'); desc.innerHTML = text; @@ -142,18 +142,18 @@ phpbb.prepareRolesDropdown = function () { // Prepare highlighting of select options and settings update $options.each(function () { var $this = $(this); - var $roles_options = $this.closest('.roles-options'); + var $rolesOptions = $this.closest('.roles-options'); // Correctly show selected option if (typeof $this.attr('data-selected') !== 'undefined') { $this.closest('.roles-options').children('span').text($this.text()); } - $this.on('mouseover', function (e) { + $this.on('mouseover', function () { var $this = $(this); $options.removeClass('roles-highlight'); $this.addClass('roles-highlight'); - }).on('click', function (e) { + }).on('click', function () { var $this = $(this); // Update settings @@ -161,8 +161,8 @@ phpbb.prepareRolesDropdown = function () { init_colours($this.attr('data-target-id').replace('advanced', '')); // Set selected setting - $roles_options.children('span').text($this.text()); - $roles_options.children('input[type=hidden]').val($this.attr('data-id')); + $rolesOptions.children('span').text($this.text()); + $rolesOptions.children('input[type=hidden]').val($this.attr('data-id')); // Trigger hiding of selection options $('body').trigger('click'); -- cgit v1.2.1 From 89cb8a3217edf0f374122e678e48e65a5c86c998 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Fri, 29 May 2015 18:06:30 +0200 Subject: [ticket/6466] Minor documentation changes PHPBB3-6466 --- phpBB/adm/style/tooltip.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/tooltip.js b/phpBB/adm/style/tooltip.js index f78e1da81f..a52fa36853 100644 --- a/phpBB/adm/style/tooltip.js +++ b/phpBB/adm/style/tooltip.js @@ -20,7 +20,7 @@ var tooltips = []; * Enable tooltip replacements for selects * @param {string} id ID tag of select * @param {string} headline Text that should appear on top of tooltip - * @param {string} subId Sub ID that should only be using tooltips (optional) + * @param {string} [subId] Sub ID that should only be using tooltips (optional) */ phpbb.enableTooltipsSelect = function (id, headline, subId) { var $links, hold; @@ -53,7 +53,7 @@ phpbb.enableTooltipsSelect = function (id, headline, subId) { /** * Prepare elements to replace * - * @param {object} $element Element to prepare for tooltips + * @param {jQuery} $element Element to prepare for tooltips * @param {string} headText Text heading to display */ phpbb.prepareTooltips = function ($element, headText) { @@ -119,7 +119,7 @@ phpbb.createElement = function (tag, c) { /** * Correct positioning of tooltip container * - * @param {object} $element Tooltip element that should be positioned + * @param {jQuery} $element Tooltip element that should be positioned */ phpbb.positionTooltip = function ($element) { var offset; -- cgit v1.2.1 From 2e46bef2ecc42a225e53d27c9b7614107b878186 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Sat, 30 May 2015 10:54:32 +0200 Subject: [ticket/6466] Remove createElement function from tooltip.js PHPBB3-6466 --- phpBB/adm/style/tooltip.js | 61 ++++++++++++++++++++++++---------------------- 1 file changed, 32 insertions(+), 29 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/tooltip.js b/phpBB/adm/style/tooltip.js index a52fa36853..641d82c80a 100644 --- a/phpBB/adm/style/tooltip.js +++ b/phpBB/adm/style/tooltip.js @@ -25,10 +25,13 @@ var tooltips = []; phpbb.enableTooltipsSelect = function (id, headline, subId) { var $links, hold; - hold = document.createElement('span'); - hold.id = '_tooltip_container'; - hold.setAttribute('id', '_tooltip_container'); - hold.style.position = 'absolute'; + hold = $('', { + id: '_tooltip_container', + css: { + position: 'absolute' + } + }); + $('body').append(hold); if (!id) { @@ -57,7 +60,7 @@ phpbb.enableTooltipsSelect = function (id, headline, subId) { * @param {string} headText Text heading to display */ phpbb.prepareTooltips = function ($element, headText) { - var tooltip, text, desc, title; + var $tooltip, text, $desc, $title; text = $element.attr('data-title'); @@ -65,17 +68,32 @@ phpbb.prepareTooltips = function ($element, headText) { return; } - title = phpbb.createElement('span', 'top'); - title.appendChild(document.createTextNode(headText)); - - desc = phpbb.createElement('span', 'bottom'); - desc.innerHTML = text; + $title = $('', { + class: 'top', + css: { + display: 'block' + } + }) + .append(document.createTextNode(headText)); + + $desc = $('', { + class: 'bottom', + html: text, + css: { + display: 'block' + } + }); - tooltip = phpbb.createElement('span', 'tooltip'); - tooltip.appendChild(title); - tooltip.appendChild(desc); + $tooltip = $('', { + class: 'tooltip', + css: { + display: 'block' + } + }) + .append($title) + .append($desc); - tooltips[$element.attr('data-id')] = tooltip; + tooltips[$element.attr('data-id')] = $tooltip; $element.on('mouseover', phpbb.showTooltip); $element.on('mouseout', phpbb.hideTooltip); }; @@ -101,21 +119,6 @@ phpbb.hideTooltip = function () { } }; -/** - * Create new element - * - * @param {string} tag HTML tag - * @param {string} c Element's class - * - * @return {object} Created element -*/ -phpbb.createElement = function (tag, c) { - var x = document.createElement(tag); - x.className = c; - x.style.display = 'block'; - return x; -}; - /** * Correct positioning of tooltip container * -- cgit v1.2.1 From 44b8dafb233cb07403a303b9c3a5eb72539365d2 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Sat, 30 May 2015 11:20:04 +0200 Subject: [ticket/6466] Support form reset and do not loose role upon resubmit PHPBB3-6466 --- phpBB/adm/style/permission_mask.html | 2 +- phpBB/adm/style/tooltip.js | 28 ++++++++++++++++++++++++---- 2 files changed, 25 insertions(+), 5 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/permission_mask.html b/phpBB/adm/style/permission_mask.html index 91894ebc77..347da3181e 100644 --- a/phpBB/adm/style/permission_mask.html +++ b/phpBB/adm/style/permission_mask.html @@ -50,7 +50,7 @@ {% endfor %} - + {% else %} diff --git a/phpBB/adm/style/tooltip.js b/phpBB/adm/style/tooltip.js index 641d82c80a..68964034f0 100644 --- a/phpBB/adm/style/tooltip.js +++ b/phpBB/adm/style/tooltip.js @@ -141,15 +141,20 @@ phpbb.positionTooltip = function ($element) { */ phpbb.prepareRolesDropdown = function () { var $options = $('.roles-options li'); + var $rolesOptions = $options.closest('.roles-options'); + var $span = $rolesOptions.children('span'); // Prepare highlighting of select options and settings update $options.each(function () { var $this = $(this); - var $rolesOptions = $this.closest('.roles-options'); // Correctly show selected option if (typeof $this.attr('data-selected') !== 'undefined') { - $this.closest('.roles-options').children('span').text($this.text()); + $rolesOptions.closest('.roles-options') + .children('span') + .text($this.text()) + .attr('data-default', $this.text()) + .attr('data-default-val', $this.attr('data-id')); } $this.on('mouseover', function () { @@ -164,13 +169,28 @@ phpbb.prepareRolesDropdown = function () { init_colours($this.attr('data-target-id').replace('advanced', '')); // Set selected setting - $rolesOptions.children('span').text($this.text()); - $rolesOptions.children('input[type=hidden]').val($this.attr('data-id')); + $rolesOptions.children('span') + .text($this.text()); + $rolesOptions.children('input[type=hidden]') + .val($this.attr('data-id')); // Trigger hiding of selection options $('body').trigger('click'); }); }); + + // Save default text of drop down if there is no default set yet + if (typeof $span.attr('data-default') === 'undefined') { + $span.attr('data-default', $span.text()); + } + + // Prepare resetting drop down on form reset + $options.closest('form').on('reset', function () { + $span.text($span.attr('data-default')); + $rolesOptions.children('input[type=hidden]') + .val($span.attr('data-id')); + }); + }; // Run onload functions for RolesDropdown and tooltips -- cgit v1.2.1 From 11623dd6718ec12504286db3dfcd042ccb4e3688 Mon Sep 17 00:00:00 2001 From: MateBartus Date: Tue, 28 Apr 2015 22:33:04 +0200 Subject: [ticket/13740] Front facing files and controllers [ci skip] PHPBB3-13740 --- phpBB/adm/style/admin.css | 6 +++- phpBB/adm/style/installer_form.html | 52 ++++++++++++++++++++++++++++++++++ phpBB/adm/style/installer_install.html | 13 +++++++++ 3 files changed, 70 insertions(+), 1 deletion(-) create mode 100644 phpBB/adm/style/installer_form.html create mode 100644 phpBB/adm/style/installer_install.html (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/admin.css b/phpBB/adm/style/admin.css index 145bcfaec1..dd5878a976 100644 --- a/phpBB/adm/style/admin.css +++ b/phpBB/adm/style/admin.css @@ -1776,7 +1776,7 @@ li.pagination ul { /* Action Highlighting ---------------------------------------- */ -.successbox, .errorbox { +.successbox, .errorbox, .warningbox { padding: 8px; margin: 10px 0; color: #FFFFFF; @@ -1800,6 +1800,10 @@ li.pagination ul { background-color: #BC2A4D; } +.warningbox { + background-color: #fca600; +} + .successbox h3, .errorbox h3 { color: #FFFFFF; margin: 0 0 0.5em; diff --git a/phpBB/adm/style/installer_form.html b/phpBB/adm/style/installer_form.html new file mode 100644 index 0000000000..dbcf3c19f8 --- /dev/null +++ b/phpBB/adm/style/installer_form.html @@ -0,0 +1,52 @@ + + +
+ + + + +
+ +
+ + {options.LEGEND} + + + +
+

{options.TITLE_EXPLAIN}
+
+ + + + + + + + + + + + + + + checked /> {options.OPTIONS.label} + + +
+
+ +
+
+ {L_SUBMIT} + +
+ + + + + diff --git a/phpBB/adm/style/installer_install.html b/phpBB/adm/style/installer_install.html new file mode 100644 index 0000000000..7d62075c62 --- /dev/null +++ b/phpBB/adm/style/installer_install.html @@ -0,0 +1,13 @@ + +

{L_INSTALL}

+{CONTENT} + +
+
+ {L_SUBMIT} + +
+
+ + + -- cgit v1.2.1 From b7ef709549597f2fa4f9c8525bfd602f81644530 Mon Sep 17 00:00:00 2001 From: MateBartus Date: Wed, 3 Jun 2015 01:31:48 +0200 Subject: [ticket/13740] Implement progress bar for AJAX UI PHPBB3-13740 --- phpBB/adm/style/admin.css | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/admin.css b/phpBB/adm/style/admin.css index dd5878a976..ca5daf5bc5 100644 --- a/phpBB/adm/style/admin.css +++ b/phpBB/adm/style/admin.css @@ -2521,3 +2521,30 @@ fieldset.permissions .padding { clear: both; display: block; } + +#progress-bar { + position: relative; + width: 90%; + height: 25px; + margin: 20px auto; + border: 1px solid #cecece; +} + +#progress-bar #progress-bar-text { + position: absolute; + top: 0; + width: 100%; + text-align: center; + line-height: 25px; + font-weight: bold; +} + +#progress-bar #progress-bar-filler { + display: block; + position: relative; + top: 0; + left: 0; + background-color: #3c84ad; + width: 0; + height: 25px; +} -- cgit v1.2.1 From db4cfa7df62d5911bc5a0edcdc59236c39aede08 Mon Sep 17 00:00:00 2001 From: CHItA Date: Thu, 11 Jun 2015 19:32:11 +0200 Subject: [ticket/13740] Add navigation bar support for the installer Also added various UI elements and texts. [ci skip] PHPBB3-13740 --- phpBB/adm/style/install_header.html | 2 +- phpBB/adm/style/installer_form.html | 4 ++++ phpBB/adm/style/installer_install.html | 6 +++--- 3 files changed, 8 insertions(+), 4 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/install_header.html b/phpBB/adm/style/install_header.html index 6f7f129d39..b162fa3e89 100644 --- a/phpBB/adm/style/install_header.html +++ b/phpBB/adm/style/install_header.html @@ -43,7 +43,7 @@ id="activemenu">{l_block1.L_TITLE} - id="activemenu"> class="completed">{l_block2.L_TITLE}
+ id="activemenu"> class="completed" id="installer-stage-{l_block2.STAGE_NAME}">{l_block2.L_TITLE}
diff --git a/phpBB/adm/style/installer_form.html b/phpBB/adm/style/installer_form.html index dbcf3c19f8..3cb4185bc6 100644 --- a/phpBB/adm/style/installer_form.html +++ b/phpBB/adm/style/installer_form.html @@ -1,6 +1,8 @@
+
+ @@ -40,7 +42,9 @@
+ +
{L_SUBMIT} diff --git a/phpBB/adm/style/installer_install.html b/phpBB/adm/style/installer_install.html index 7d62075c62..7700c79036 100644 --- a/phpBB/adm/style/installer_install.html +++ b/phpBB/adm/style/installer_install.html @@ -1,11 +1,11 @@ -

{L_INSTALL}

-{CONTENT} +

{TITLE}

+

{CONTENT}

{L_SUBMIT} - +
-- cgit v1.2.1 From 97d08d6f56cf448fd4def8a4d29c570da91faa89 Mon Sep 17 00:00:00 2001 From: Mate Bartus Date: Wed, 22 Jul 2015 03:16:16 +0200 Subject: [ticket/13740] Allow language change in the installer PHPBB3-13740 --- phpBB/adm/style/install_header.html | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/install_header.html b/phpBB/adm/style/install_header.html index b162fa3e89..9d0f9a56de 100644 --- a/phpBB/adm/style/install_header.html +++ b/phpBB/adm/style/install_header.html @@ -15,10 +15,14 @@

{L_INSTALL_PANEL}

{L_SKIP}

-
+
- {S_LANG_SELECT} +
-- cgit v1.2.1 From 3356130ce2adf82248cf64fcaa81a47713ce7987 Mon Sep 17 00:00:00 2001 From: Mate Bartus Date: Wed, 22 Jul 2015 12:43:17 +0200 Subject: [ticket/13740] Separate new installer style templates PHPBB3-13740 --- phpBB/adm/style/install_header.html | 10 ++---- phpBB/adm/style/installer_footer.html | 21 +++++++++++++ phpBB/adm/style/installer_header.html | 57 ++++++++++++++++++++++++++++++++++ phpBB/adm/style/installer_install.html | 4 +-- phpBB/adm/style/installer_main.html | 6 ++++ 5 files changed, 89 insertions(+), 9 deletions(-) create mode 100644 phpBB/adm/style/installer_footer.html create mode 100644 phpBB/adm/style/installer_header.html create mode 100644 phpBB/adm/style/installer_main.html (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/install_header.html b/phpBB/adm/style/install_header.html index 9d0f9a56de..8debfc69c0 100644 --- a/phpBB/adm/style/install_header.html +++ b/phpBB/adm/style/install_header.html @@ -15,14 +15,10 @@

{L_INSTALL_PANEL}

{L_SKIP}

-
+
- + {S_LANG_SELECT}
@@ -47,7 +43,7 @@ id="activemenu">{l_block1.L_TITLE} - id="activemenu"> class="completed" id="installer-stage-{l_block2.STAGE_NAME}">{l_block2.L_TITLE} + id="activemenu"> class="completed">{l_block2.L_TITLE} diff --git a/phpBB/adm/style/installer_footer.html b/phpBB/adm/style/installer_footer.html new file mode 100644 index 0000000000..2c70d4d5d3 --- /dev/null +++ b/phpBB/adm/style/installer_footer.html @@ -0,0 +1,21 @@ + + + + + + + + + + + + + +{$SCRIPTS} + + + diff --git a/phpBB/adm/style/installer_header.html b/phpBB/adm/style/installer_header.html new file mode 100644 index 0000000000..ada6553aec --- /dev/null +++ b/phpBB/adm/style/installer_header.html @@ -0,0 +1,57 @@ + + + + + + {META} + {PAGE_TITLE} + + + + + +
+ + +
+
+ +
+ +
+
+ + +
+
diff --git a/phpBB/adm/style/installer_install.html b/phpBB/adm/style/installer_install.html index 7700c79036..175c6eac67 100644 --- a/phpBB/adm/style/installer_install.html +++ b/phpBB/adm/style/installer_install.html @@ -1,4 +1,4 @@ - +

{TITLE}

{CONTENT}

@@ -10,4 +10,4 @@ - + diff --git a/phpBB/adm/style/installer_main.html b/phpBB/adm/style/installer_main.html new file mode 100644 index 0000000000..ed65da8a68 --- /dev/null +++ b/phpBB/adm/style/installer_main.html @@ -0,0 +1,6 @@ + + +

{TITLE}

+

{BODY}

+ + -- cgit v1.2.1 From b4552a8ba303881d53995d334cc22aa175d5c46f Mon Sep 17 00:00:00 2001 From: Mate Bartus Date: Fri, 24 Jul 2015 08:33:02 +0200 Subject: [ticket/13740] Replace more spaces with tabs PHPBB3-13740 --- phpBB/adm/style/admin.css | 38 +++++++------- phpBB/adm/style/install_header.html | 4 +- phpBB/adm/style/installer_footer.html | 20 ++++---- phpBB/adm/style/installer_form.html | 86 +++++++++++++++---------------- phpBB/adm/style/installer_header.html | 92 +++++++++++++++++----------------- phpBB/adm/style/installer_install.html | 8 +-- phpBB/adm/style/installer_main.html | 4 +- 7 files changed, 126 insertions(+), 126 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/admin.css b/phpBB/adm/style/admin.css index ca5daf5bc5..992af0997f 100644 --- a/phpBB/adm/style/admin.css +++ b/phpBB/adm/style/admin.css @@ -1801,7 +1801,7 @@ li.pagination ul { } .warningbox { - background-color: #fca600; + background-color: #fca600; } .successbox h3, .errorbox h3 { @@ -2523,28 +2523,28 @@ fieldset.permissions .padding { } #progress-bar { - position: relative; - width: 90%; - height: 25px; - margin: 20px auto; - border: 1px solid #cecece; + position: relative; + width: 90%; + height: 25px; + margin: 20px auto; + border: 1px solid #cecece; } #progress-bar #progress-bar-text { - position: absolute; - top: 0; - width: 100%; - text-align: center; - line-height: 25px; - font-weight: bold; + position: absolute; + top: 0; + width: 100%; + text-align: center; + line-height: 25px; + font-weight: bold; } #progress-bar #progress-bar-filler { - display: block; - position: relative; - top: 0; - left: 0; - background-color: #3c84ad; - width: 0; - height: 25px; + display: block; + position: relative; + top: 0; + left: 0; + background-color: #3c84ad; + width: 0; + height: 25px; } diff --git a/phpBB/adm/style/install_header.html b/phpBB/adm/style/install_header.html index 8debfc69c0..6f7f129d39 100644 --- a/phpBB/adm/style/install_header.html +++ b/phpBB/adm/style/install_header.html @@ -18,7 +18,7 @@
- {S_LANG_SELECT} + {S_LANG_SELECT}
@@ -43,7 +43,7 @@ id="activemenu">{l_block1.L_TITLE} - id="activemenu"> class="completed">{l_block2.L_TITLE} + id="activemenu"> class="completed">{l_block2.L_TITLE}
diff --git a/phpBB/adm/style/installer_footer.html b/phpBB/adm/style/installer_footer.html index 2c70d4d5d3..617d3dc254 100644 --- a/phpBB/adm/style/installer_footer.html +++ b/phpBB/adm/style/installer_footer.html @@ -1,14 +1,14 @@ -
-
-
-
-
+ + + + + - + diff --git a/phpBB/adm/style/installer_form.html b/phpBB/adm/style/installer_form.html index 3cb4185bc6..669f7aa834 100644 --- a/phpBB/adm/style/installer_form.html +++ b/phpBB/adm/style/installer_form.html @@ -4,53 +4,53 @@
- - - -
+ + + +
-
- - {options.LEGEND} - +
+ + {options.LEGEND} + - -
-

{options.TITLE_EXPLAIN}
-
- - - - - - - - - - - - - - - checked /> {options.OPTIONS.label} - - -
-
- + +
+

{options.TITLE_EXPLAIN}
+
+ + + + + + + + + + + + + + + checked /> {options.OPTIONS.label} + + +
+
+
-
- {L_SUBMIT} - -
- - - +
+ {L_SUBMIT} + +
+ + + diff --git a/phpBB/adm/style/installer_header.html b/phpBB/adm/style/installer_header.html index ada6553aec..775caa7c67 100644 --- a/phpBB/adm/style/installer_header.html +++ b/phpBB/adm/style/installer_header.html @@ -1,57 +1,57 @@ - - - {META} - {PAGE_TITLE} + + + {META} + {PAGE_TITLE} - +
- + -
-
- -
+
+
+ +
-
-
- +
+
+ -
-
+
+
diff --git a/phpBB/adm/style/installer_install.html b/phpBB/adm/style/installer_install.html index 175c6eac67..53a91f2700 100644 --- a/phpBB/adm/style/installer_install.html +++ b/phpBB/adm/style/installer_install.html @@ -3,10 +3,10 @@

{CONTENT}

-
- {L_SUBMIT} - -
+
+ {L_SUBMIT} + +
diff --git a/phpBB/adm/style/installer_main.html b/phpBB/adm/style/installer_main.html index ed65da8a68..f14fe4da70 100644 --- a/phpBB/adm/style/installer_main.html +++ b/phpBB/adm/style/installer_main.html @@ -1,6 +1,6 @@ -

{TITLE}

-

{BODY}

+

{TITLE}

+

{BODY}

-- cgit v1.2.1 From 3937f1f4ae77b29faf69292783cc3ae267785ee4 Mon Sep 17 00:00:00 2001 From: Zoddo Date: Sat, 12 Sep 2015 00:53:33 +0200 Subject: [ticket/14157] Allow to set the alt/title attribute on post icons PHPBB3-14157 --- phpBB/adm/style/acp_icons.html | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/acp_icons.html b/phpBB/adm/style/acp_icons.html index f18dad0ef6..e723129e37 100644 --- a/phpBB/adm/style/acp_icons.html +++ b/phpBB/adm/style/acp_icons.html @@ -89,6 +89,9 @@ {L_WIDTH} {L_HEIGHT} + + {L_ALT_TEXT} + {L_DISPLAY_ON_POSTING} {L_ORDER} @@ -102,7 +105,7 @@ - + {items.TEXT_ALT} [{items.IMG}] @@ -110,6 +113,9 @@ + + + -- cgit v1.2.1 From 90038e32cd6d35aa7a516a8d4f998e9504112c6a Mon Sep 17 00:00:00 2001 From: Cesar G Date: Tue, 13 Oct 2015 07:39:46 -0700 Subject: [ticket/13789] Upgrade reCaptcha plugin to 2.0 API. PHPBB3-13789 --- phpBB/adm/style/captcha_recaptcha.html | 26 +++----------------------- 1 file changed, 3 insertions(+), 23 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/captcha_recaptcha.html b/phpBB/adm/style/captcha_recaptcha.html index d3038fd714..3f61c76cb1 100644 --- a/phpBB/adm/style/captcha_recaptcha.html +++ b/phpBB/adm/style/captcha_recaptcha.html @@ -1,32 +1,12 @@
- - - - - + +
-- cgit v1.2.1 From 8f5a0ad6f73e7b7757b02c827436384c96069b5a Mon Sep 17 00:00:00 2001 From: Mate Bartus Date: Fri, 24 Jul 2015 09:20:50 +0200 Subject: [ticket/14039] Revamp updater PHPBB3-14039 --- phpBB/adm/style/admin.css | 21 ++++++ phpBB/adm/style/installer_footer.html | 2 +- phpBB/adm/style/installer_form.html | 24 +++---- phpBB/adm/style/installer_install.html | 2 +- phpBB/adm/style/installer_update.html | 13 ++++ phpBB/adm/style/installer_update_file_status.html | 80 +++++++++++++++++++++++ 6 files changed, 128 insertions(+), 14 deletions(-) create mode 100644 phpBB/adm/style/installer_update.html create mode 100644 phpBB/adm/style/installer_update_file_status.html (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/admin.css b/phpBB/adm/style/admin.css index cf009562b3..d884e69e09 100644 --- a/phpBB/adm/style/admin.css +++ b/phpBB/adm/style/admin.css @@ -1836,10 +1836,31 @@ li.pagination ul { font-weight: bold; } +#log-container { + max-height: 300px; + padding: 8px; + margin: 10px 0; + clear: both; + overflow-y: auto; + background-color: #FFFFFF; +} + +#log-container.show_border { + border: 1px solid #DBD7D1; +} + +.log { + font-size: 0.8em; +} + .notice { background-color: #62A5CC; } +.download-box { + margin: 10px 0 10px 0; +} + /* Special cases for the error page */ #errorpage #page-header a { font-weight: bold; diff --git a/phpBB/adm/style/installer_footer.html b/phpBB/adm/style/installer_footer.html index 617d3dc254..b2eba48ae6 100644 --- a/phpBB/adm/style/installer_footer.html +++ b/phpBB/adm/style/installer_footer.html @@ -13,7 +13,7 @@ - + {$SCRIPTS} diff --git a/phpBB/adm/style/installer_form.html b/phpBB/adm/style/installer_form.html index 669f7aa834..cc5b041fa1 100644 --- a/phpBB/adm/style/installer_form.html +++ b/phpBB/adm/style/installer_form.html @@ -1,6 +1,6 @@
- +
@@ -13,8 +13,6 @@ {options.LEGEND} - -

{options.TITLE_EXPLAIN}
@@ -41,16 +39,18 @@
- - -
- -
- {L_SUBMIT} - -
- + +
+ + + +
+ {L_SUBMIT} + + + +
diff --git a/phpBB/adm/style/installer_install.html b/phpBB/adm/style/installer_install.html index 53a91f2700..747b1291f4 100644 --- a/phpBB/adm/style/installer_install.html +++ b/phpBB/adm/style/installer_install.html @@ -9,5 +9,5 @@ - + diff --git a/phpBB/adm/style/installer_update.html b/phpBB/adm/style/installer_update.html new file mode 100644 index 0000000000..6bcbc525e9 --- /dev/null +++ b/phpBB/adm/style/installer_update.html @@ -0,0 +1,13 @@ + +

{TITLE}

+

{CONTENT}

+ +
+
+ {L_SUBMIT} + +
+
+ + + diff --git a/phpBB/adm/style/installer_update_file_status.html b/phpBB/adm/style/installer_update_file_status.html new file mode 100644 index 0000000000..9f15c402e9 --- /dev/null +++ b/phpBB/adm/style/installer_update_file_status.html @@ -0,0 +1,80 @@ + +

{L_FILES_DELETED}

+
» {L_TOGGLE_DISPLAY}
+

{L_FILES_DELETED_EXPLAIN}

+ +
+ {L_STATUS_DELETED} + +
+
{deleted.DIR_PART}{deleted.FILE_PART}
+
+ +
+ + + + +

{L_FILES_CONFLICT}

+
» {L_TOGGLE_DISPLAY}
+

{L_FILES_CONFLICT_EXPLAIN}

+ +
+ {L_STATUS_CONFLICT} + +
+
{conflict.DIR_PART}{conflict.FILE_PART}
+
+ +
+ + + + +

{L_FILES_MODIFIED}

+
» {L_TOGGLE_DISPLAY}
+

{L_FILES_MODIFIED_EXPLAIN}

+ +
+ {L_STATUS_MODIFIED} + +
+
{modified.DIR_PART}{modified.FILE_PART}
+
+ +
+ + + + +

{L_FILES_NEW}

+
» {L_TOGGLE_DISPLAY}
+

{L_FILES_NEW_EXPLAIN}

+ + + + + + +

{L_FILES_NOT_MODIFIED}

+
» {L_TOGGLE_DISPLAY}
+

{L_FILES_NOT_MODIFIED_EXPLAIN}

+ + + + -- cgit v1.2.1 From afe91fa7d3af0d30389c49428b30c9aeb0fe0916 Mon Sep 17 00:00:00 2001 From: Mate Bartus Date: Sun, 18 Oct 2015 11:22:19 +0200 Subject: [ticket/14039] Fix T_TEMPLATE_PATH constant PHPBB3-14039 --- phpBB/adm/style/installer_header.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/installer_header.html b/phpBB/adm/style/installer_header.html index 775caa7c67..c4c3427fdb 100644 --- a/phpBB/adm/style/installer_header.html +++ b/phpBB/adm/style/installer_header.html @@ -6,7 +6,7 @@ {META} {PAGE_TITLE} - + -- cgit v1.2.1 From 74ae7d2a8d396701f0ae8bdbcb19cd67135c5f8d Mon Sep 17 00:00:00 2001 From: Mate Bartus Date: Sun, 18 Oct 2015 11:33:49 +0200 Subject: [ticket/14039] Only show log container when it has content PHPBB3-14039 --- phpBB/adm/style/admin.css | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/admin.css b/phpBB/adm/style/admin.css index d884e69e09..cfa55b58a1 100644 --- a/phpBB/adm/style/admin.css +++ b/phpBB/adm/style/admin.css @@ -1837,6 +1837,7 @@ li.pagination ul { } #log-container { + display: none; max-height: 300px; padding: 8px; margin: 10px 0; @@ -1845,7 +1846,8 @@ li.pagination ul { background-color: #FFFFFF; } -#log-container.show_border { +#log-container.show_log_container { + display: block; border: 1px solid #DBD7D1; } -- cgit v1.2.1 From 597297b169e2ae14684ad1f40c8e083be22b241d Mon Sep 17 00:00:00 2001 From: Mate Bartus Date: Sun, 18 Oct 2015 22:47:04 +0200 Subject: [ticket/14044] Deduplicate the installers PHPBB3-14044 --- phpBB/adm/style/install_convert.html | 134 --------- phpBB/adm/style/install_error.html | 8 - phpBB/adm/style/install_footer.html | 21 -- phpBB/adm/style/install_header.html | 53 ---- phpBB/adm/style/install_install.html | 77 ----- phpBB/adm/style/install_main.html | 6 - phpBB/adm/style/install_update.html | 491 ------------------------------- phpBB/adm/style/install_update_diff.html | 254 ---------------- 8 files changed, 1044 deletions(-) delete mode 100644 phpBB/adm/style/install_convert.html delete mode 100644 phpBB/adm/style/install_error.html delete mode 100644 phpBB/adm/style/install_footer.html delete mode 100644 phpBB/adm/style/install_header.html delete mode 100644 phpBB/adm/style/install_install.html delete mode 100644 phpBB/adm/style/install_main.html delete mode 100644 phpBB/adm/style/install_update.html delete mode 100644 phpBB/adm/style/install_update_diff.html (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/install_convert.html b/phpBB/adm/style/install_convert.html deleted file mode 100644 index 7e22404f56..0000000000 --- a/phpBB/adm/style/install_convert.html +++ /dev/null @@ -1,134 +0,0 @@ - - - - -

{TITLE}

- -

{BODY}

- - - -
- -

{TITLE}

- -

{BODY}

- - -
-

{ERROR_TITLE}

-

{ERROR_MSG}

-
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
{L_AVAILABLE_CONVERTORS}
{L_SOFTWARE}{L_VERSION}{L_AUTHOR}{L_OPTIONS}
{convertors.SOFTWARE}{convertors.VERSION}{convertors.AUTHOR}{L_CONVERT}
{L_NO_CONVERTORS}---
- - - -
- -
-
- -
-
-
- -
-
- -
- - - -
- - - - -
- -
- - {checks.LEGEND} -

{checks.LEGEND_EXPLAIN}

- - -
-

{checks.TITLE_EXPLAIN}
-
{checks.RESULT}
-
- - - -
- - - -
- - - - -
- -
- - {options.LEGEND} - - -
-

{options.TITLE_EXPLAIN}
-
{options.CONTENT}
-
- - - - -
- - - -

{L_MESSAGE}

- -
- {S_HIDDEN} - disabled="disabled" onclick="this.className = 'button1 disabled';" onsubmit="this.disabled = 'disabled';" name="submit" value="{L_SUBMIT}" /> -
- - -
- - - diff --git a/phpBB/adm/style/install_error.html b/phpBB/adm/style/install_error.html deleted file mode 100644 index 3f7c8b9ed4..0000000000 --- a/phpBB/adm/style/install_error.html +++ /dev/null @@ -1,8 +0,0 @@ - - -
-

{MESSAGE_TITLE}

-

{MESSAGE_TEXT}

-
- - diff --git a/phpBB/adm/style/install_footer.html b/phpBB/adm/style/install_footer.html deleted file mode 100644 index a29fce6c5a..0000000000 --- a/phpBB/adm/style/install_footer.html +++ /dev/null @@ -1,21 +0,0 @@ - - - - - - - - - - - - - -{$SCRIPTS} - - - diff --git a/phpBB/adm/style/install_header.html b/phpBB/adm/style/install_header.html deleted file mode 100644 index 6f7f129d39..0000000000 --- a/phpBB/adm/style/install_header.html +++ /dev/null @@ -1,53 +0,0 @@ - - - - - -{META} -{PAGE_TITLE} - - - - - -
- - -
-
- -
- -
-
- - -
-
diff --git a/phpBB/adm/style/install_install.html b/phpBB/adm/style/install_install.html deleted file mode 100644 index 1a809a3588..0000000000 --- a/phpBB/adm/style/install_install.html +++ /dev/null @@ -1,77 +0,0 @@ - - -
- -

{TITLE}

-

{BODY}

- - -
- - - - -
- -
- - {checks.LEGEND} -

{checks.LEGEND_EXPLAIN}

- - -
-
{checks.TITLE}{L_COLON}
{checks.TITLE_EXPLAIN}
-
{checks.RESULT}
-
- - - -
- - - -
- - - - -
- -
- - {options.LEGEND} - - -
-

{options.TITLE_EXPLAIN}
-
{options.CONTENT}
-
- - - - -
- - - -

{L_DL_CONFIG}

-

{L_DL_CONFIG_EXPLAIN}

- -
- {L_DL_CONFIG} - {S_HIDDEN} -   -
- - - -
- {L_SUBMIT} - {S_HIDDEN} - -
- - -
- - diff --git a/phpBB/adm/style/install_main.html b/phpBB/adm/style/install_main.html deleted file mode 100644 index 73e73ad578..0000000000 --- a/phpBB/adm/style/install_main.html +++ /dev/null @@ -1,6 +0,0 @@ - - -

{TITLE}

-

{BODY}

- - diff --git a/phpBB/adm/style/install_update.html b/phpBB/adm/style/install_update.html deleted file mode 100644 index 898233f72d..0000000000 --- a/phpBB/adm/style/install_update.html +++ /dev/null @@ -1,491 +0,0 @@ - - - - - -
-

{L_NOTICE}

-

{ERROR_MSG}

-
- - - - -
-

{L_IN_PROGRESS}

-

{L_IN_PROGRESS_EXPLAIN}

-
- - - - -
-

{L_NOTICE}

-

{WARNING_MSG}

-
- - -
-

{L_NOTICE}

-

{L_BACKUP_NOTICE}

-
- -
- -

{L_UPDATE_INSTALLATION}

-

{L_UPDATE_INSTALLATION_EXPLAIN}

- -
- -
- -
- - - -
- -

{L_UPDATE_SUCCESS}

-

{L_UPDATE_SUCCESS_EXPLAIN}

- -
- -
- -
- - - - - -

{L_VERSION_CHECK}

- -

{L_VERSION_CHECK_EXPLAIN}

- - -
-

{L_VERSION_UP_TO_DATE}

-
- -
-

{L_VERSION_NOT_UP_TO_DATE}

-
- - -
- -
-
-
{CURRENT_VERSION}
-
-
-
-
{LATEST_VERSION}
-
- -
-
-
{PACKAGE_VERSION}
-
- -
- -
- -
-

{L_CHECK_FILES_EXPLAIN}

- -
- -
- - - - - -

{L_PERFORM_DATABASE_UPDATE}

- -

- {L_PERFORM_DATABASE_UPDATE_EXPLAIN}
-

- -

- -
- -
- {L_RUN_DATABASE_SCRIPT} - - -
- -
- - - -
-

{L_UPDATE_SUCCESS}

-

{L_EVERYTHING_UP_TO_DATE}

-
- - - - - - - -

{L_UPDATE_FILE_SUCCESS}

-

{L_ALL_FILES_UP_TO_DATE}

- -

{L_UPDATE_DATABASE_EXPLAIN}

- -
- -
- -
- -
- - -

{L_COLLECTED_INFORMATION}

- -

{L_COLLECTED_INFORMATION_EXPLAIN}

- - -
-

{L_NO_UPDATE_FILES}

- -

{L_NO_UPDATE_FILES_EXPLAIN}


- - {NO_UPDATE_FILES} - -
- - -
- - -

{L_FILES_DELETED}

- -

{L_FILES_DELETED_EXPLAIN}

- -
- {L_STATUS_DELETED} - -
-
{deleted.DIR_PART}
{deleted.FILE_PART}
-
- [{deleted.L_SHOW_DIFF}]{L_BINARY_FILE} -
-
- -
- - - - -

{L_FILES_CONFLICT}

- -

{L_FILES_CONFLICT_EXPLAIN}

- - -
- {L_STATUS_CONFLICT} -
-
{conflict.DIR_PART}
{conflict.FILE_PART}
-
{L_FILE_USED}{L_COLON} {conflict.CUSTOM_ORIGINAL} -
{L_NUM_CONFLICTS}{L_COLON} {conflict.NUM_CONFLICTS} -
-
- [{L_DOWNLOAD_CONFLICTS}]
{L_DOWNLOAD_CONFLICTS_EXPLAIN} - {L_BINARY_FILE} -
- -
- -
- -
-
-
 
-
- -
-
-
[{L_SHOW_DIFF_MODIFIED}]
-
-
-
-
[{L_SHOW_DIFF_MODIFIED}]
-
-
-
-
[{L_SHOW_DIFF_FINAL}]
-
-
-
-
[{L_SHOW_DIFF_FINAL}]
-
- -
- - - - - -

{L_FILES_NEW_CONFLICT}

- -

{L_FILES_NEW_CONFLICT_EXPLAIN}

- -
- {L_STATUS_NEW_CONFLICT} - -
-
{new_conflict.DIR_PART}
{new_conflict.FILE_PART}
-
{L_FILE_USED}{L_COLON} {new_conflict.CUSTOM_ORIGINAL} -
-
- [{new_conflict.L_SHOW_DIFF}]{L_BINARY_FILE} -
- -
- -
- -
- - - - -

{L_FILES_MODIFIED}

- -

{L_FILES_MODIFIED_EXPLAIN}

- - -
- {L_STATUS_MODIFIED} -
-
{modified.DIR_PART}
{modified.FILE_PART}
-
{L_FILE_USED}{L_COLON} {modified.CUSTOM_ORIGINAL} -
-
 
- -
- -
-
-
-
[{modified.L_SHOW_DIFF}]{L_BINARY_FILE}
-
-
-
-
[{L_SHOW_DIFF_FINAL}] 
-
-
-
-
[{L_SHOW_DIFF_FINAL}] 
-
-
- - - - - -

{L_FILES_NEW}

- -

{L_FILES_NEW_EXPLAIN}

- - - - - - -

{L_FILES_NOT_MODIFIED}

- -

{L_FILES_NOT_MODIFIED_EXPLAIN}

- - - - - - -

{L_FILES_UP_TO_DATE}

- -

{L_FILES_UP_TO_DATE_EXPLAIN}

- - - - - -
- -
- -
- -
- -

{L_UPDATE_METHOD}

- -

{L_UPDATE_METHOD_EXPLAIN}

- -
-     -
- -
- - - - - -

{L_DOWNLOAD_UPDATE_METHOD}

- -

{L_DOWNLOAD_UPDATE_METHOD_EXPLAIN}

- -
- -
- {L_SELECT_DOWNLOAD_FORMAT} -
-
-
{RADIO_BUTTONS}
-
-
- -
- {S_HIDDEN_FIELDS} -     -
- -
- -

- -

{L_MAPPING_FILE_STRUCTURE}

- - - - - - - - - - - - - - - - - - - -
{L_ARCHIVE_FILE} {L_DESTINATION}
{location.SOURCE}»{location.DESTINATION}
- - - -

{L_SELECT_FTP_SETTINGS}

- -
- - -
-

{L_CONNECTION_SUCCESS}

-
- -
-

{L_TRY_DOWNLOAD_METHOD}

- -
- -
-
- -
-

{L_CONNECTION_FAILED}
{ERROR_MSG}

-
- - -
- {L_FTP_SETTINGS} -
-
-
{UPLOAD_METHOD}
-
- -
-

{data.EXPLAIN}
-
-
- -
- -
- {S_HIDDEN_FIELDS} - - - -
- -
- - - - diff --git a/phpBB/adm/style/install_update_diff.html b/phpBB/adm/style/install_update_diff.html deleted file mode 100644 index 5f80084705..0000000000 --- a/phpBB/adm/style/install_update_diff.html +++ /dev/null @@ -1,254 +0,0 @@ - - - - - -{META} -{PAGE_TITLE} - - - - - - - - - - - - - - - -
- - -
-
-
-
-
- {DIFF_CONTENT} -
-
-
-
-
- - - -- cgit v1.2.1 From d7317c9b25e5343bc28bd7cee7ad825cba30734a Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Mon, 7 Dec 2015 16:41:23 +0100 Subject: [ticket/14310] Put progress percentage inside span and make more visible PHPBB3-14310 --- phpBB/adm/style/admin.css | 1 + 1 file changed, 1 insertion(+) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/admin.css b/phpBB/adm/style/admin.css index cfa55b58a1..e38e1cc3d7 100644 --- a/phpBB/adm/style/admin.css +++ b/phpBB/adm/style/admin.css @@ -2566,6 +2566,7 @@ fieldset.permissions .padding { text-align: center; line-height: 25px; font-weight: bold; + color: #fff; } #progress-bar #progress-bar-filler { -- cgit v1.2.1 From c02fc0f63fb8098cd4096481ad27b31f8069d5d1 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Tue, 22 Dec 2015 20:01:22 +0100 Subject: [ticket/14378] Use consistent template variable paths PHPBB3-14378 --- phpBB/adm/style/installer_footer.html | 2 +- phpBB/adm/style/installer_header.html | 2 +- phpBB/adm/style/installer_update_file_status.html | 10 +++++----- 3 files changed, 7 insertions(+), 7 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/installer_footer.html b/phpBB/adm/style/installer_footer.html index 44010b5589..63aebec993 100644 --- a/phpBB/adm/style/installer_footer.html +++ b/phpBB/adm/style/installer_footer.html @@ -13,7 +13,7 @@ - + {$SCRIPTS} diff --git a/phpBB/adm/style/installer_header.html b/phpBB/adm/style/installer_header.html index c4c3427fdb..775caa7c67 100644 --- a/phpBB/adm/style/installer_header.html +++ b/phpBB/adm/style/installer_header.html @@ -6,7 +6,7 @@ {META} {PAGE_TITLE} - + diff --git a/phpBB/adm/style/installer_update_file_status.html b/phpBB/adm/style/installer_update_file_status.html index 9f15c402e9..a27bfa6a44 100644 --- a/phpBB/adm/style/installer_update_file_status.html +++ b/phpBB/adm/style/installer_update_file_status.html @@ -4,7 +4,7 @@

{L_FILES_DELETED_EXPLAIN}

- {L_STATUS_DELETED} + {L_STATUS_DELETED}
{deleted.DIR_PART}{deleted.FILE_PART}
@@ -20,7 +20,7 @@

{L_FILES_CONFLICT_EXPLAIN}

- {L_STATUS_CONFLICT} + {L_STATUS_CONFLICT}
{conflict.DIR_PART}{conflict.FILE_PART}
@@ -36,7 +36,7 @@

{L_FILES_MODIFIED_EXPLAIN}

- {L_STATUS_MODIFIED} + {L_STATUS_MODIFIED}
{modified.DIR_PART}{modified.FILE_PART}
@@ -52,7 +52,7 @@

{L_FILES_NEW_EXPLAIN}

- + -- cgit v1.2.1 From 78349ed80f24cb61ad05f997e97d805cc5b0409f Mon Sep 17 00:00:00 2001 From: Tristan Darricau Date: Fri, 11 Dec 2015 21:31:27 +0100 Subject: [ticket/14306] Automatically enable a safe mode when container building fails PHPBB3-14306 --- phpBB/adm/style/overall_header.html | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/overall_header.html b/phpBB/adm/style/overall_header.html index ada88edff2..dbf27eb942 100644 --- a/phpBB/adm/style/overall_header.html +++ b/phpBB/adm/style/overall_header.html @@ -49,7 +49,7 @@ function marklist(id, name, state) } var rb = parent.getElementsByTagName('input'); - + for (var r = 0; r < rb.length; r++) { if (rb[r].name.substr(0, name.length) == name) @@ -103,7 +103,7 @@ function popup(url, width, height, name)

{L_ADMIN_INDEX}{L_FORUM_INDEX}

{L_SKIP}

- +
    @@ -120,7 +120,7 @@ function popup(url, width, height, name) - +
@@ -129,13 +129,13 @@ function popup(url, width, height, name)
- +
+ +
+

{L_CONTAINER_EXCEPTION}

+

{L_CONTAINER_EXCEPTION_DETAIL}

+

Exception message: {{ CONTAINER_EXCEPTION.getMessage() }}

+
{{ CONTAINER_EXCEPTION.getTraceAsString() }}
+
+ -- cgit v1.2.1 From 7f8b6c02c6380d44d2bc3c402cfa5e9953d4819b Mon Sep 17 00:00:00 2001 From: Tristan Darricau Date: Tue, 15 Dec 2015 20:18:55 +0100 Subject: [ticket/14306] Update the error message PHPBB3-14306 --- phpBB/adm/style/overall_header.html | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/overall_header.html b/phpBB/adm/style/overall_header.html index dbf27eb942..4212f01f15 100644 --- a/phpBB/adm/style/overall_header.html +++ b/phpBB/adm/style/overall_header.html @@ -149,8 +149,7 @@ function popup(url, width, height, name)

{L_CONTAINER_EXCEPTION}

-

{L_CONTAINER_EXCEPTION_DETAIL}

-

Exception message: {{ CONTAINER_EXCEPTION.getMessage() }}

+

{L_EXCEPTION}{L_COLON} {{ CONTAINER_EXCEPTION.getMessage() }}

{{ CONTAINER_EXCEPTION.getTraceAsString() }}
-- cgit v1.2.1 From 6594ef8b1e0b63f911fbcc2b8859fcfb09977e2f Mon Sep 17 00:00:00 2001 From: Tristan Darricau Date: Sat, 9 Jan 2016 15:32:11 +0100 Subject: [ticket/14306] CS and correctly handle exception loop PHPBB3-14306 --- phpBB/adm/style/overall_header.html | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/overall_header.html b/phpBB/adm/style/overall_header.html index 4212f01f15..3feb94f89c 100644 --- a/phpBB/adm/style/overall_header.html +++ b/phpBB/adm/style/overall_header.html @@ -146,10 +146,10 @@ function popup(url, width, height, name)
- + {% if CONTAINER_EXCEPTION !== false %}
-

{L_CONTAINER_EXCEPTION}

-

{L_EXCEPTION}{L_COLON} {{ CONTAINER_EXCEPTION.getMessage() }}

+

{{ lang('CONTAINER_EXCEPTION') }}

+

{{ lang('EXCEPTION') }}{{ lang('COLON') }} {{ CONTAINER_EXCEPTION.getMessage() }}

{{ CONTAINER_EXCEPTION.getTraceAsString() }}
- + {% endif %} -- cgit v1.2.1 From 1e0340b0cf7cc34094e03985457f1aed2f60da36 Mon Sep 17 00:00:00 2001 From: Tristan Darricau Date: Sat, 9 Jan 2016 18:03:21 +0100 Subject: =?UTF-8?q?[ticket/14306]=C2=A0Improves=20Error=20display?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PHPBB3-14306 --- phpBB/adm/style/overall_header.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/overall_header.html b/phpBB/adm/style/overall_header.html index 3feb94f89c..9266372ab8 100644 --- a/phpBB/adm/style/overall_header.html +++ b/phpBB/adm/style/overall_header.html @@ -148,7 +148,7 @@ function popup(url, width, height, name)
{% if CONTAINER_EXCEPTION !== false %}
-

{{ lang('CONTAINER_EXCEPTION') }}

+

{{ lang('CONTAINER_EXCEPTION') }}


{{ lang('EXCEPTION') }}{{ lang('COLON') }} {{ CONTAINER_EXCEPTION.getMessage() }}

{{ CONTAINER_EXCEPTION.getTraceAsString() }}
-- cgit v1.2.1 From 57ce891d5f2c0b7090d44fac074ab27b4f98b93b Mon Sep 17 00:00:00 2001 From: cunha17 Date: Wed, 28 Oct 2015 11:38:14 -0200 Subject: [ticket/14253] Show group requests pending aproval at the ACP groups summary Currenty, you need to open each existing group in ACP to know if there are pending group requests or not. Doing so is really boring and annoying... :/ This patch displays the number of pending group requests at the ACP groups summary page. PHPBB3-14253 --- phpBB/adm/style/acp_groups.html | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/acp_groups.html b/phpBB/adm/style/acp_groups.html index 23f6e744c0..ffde27a437 100644 --- a/phpBB/adm/style/acp_groups.html +++ b/phpBB/adm/style/acp_groups.html @@ -267,11 +267,12 @@ - + + @@ -281,7 +282,7 @@ - + @@ -302,11 +303,12 @@

{L_SPECIAL_GROUPS_EXPLAIN}

{L_GROUP} {L_TOTAL_MEMBERS}{L_PENDING_MEMBERS} {L_OPTIONS} {L_ACTION}
{L_NO_GROUPS_CREATED}{L_NO_GROUPS_CREATED}
- + + @@ -316,6 +318,7 @@ + -- cgit v1.2.1 From a649768e17d25bcf55ae539420abe4eb4b7a1ef1 Mon Sep 17 00:00:00 2001 From: Mate Bartus Date: Wed, 28 Oct 2015 15:00:11 +0100 Subject: [ticket/14262] Move convertor to controller PHPBB3-14262 --- phpBB/adm/style/installer_convert.html | 79 +++++++++++++++++ phpBB/adm/style/installer_convert_old.html | 134 +++++++++++++++++++++++++++++ 2 files changed, 213 insertions(+) create mode 100644 phpBB/adm/style/installer_convert.html create mode 100644 phpBB/adm/style/installer_convert_old.html (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/installer_convert.html b/phpBB/adm/style/installer_convert.html new file mode 100644 index 0000000000..8f1c51a1cb --- /dev/null +++ b/phpBB/adm/style/installer_convert.html @@ -0,0 +1,79 @@ + +

{TITLE}

+ +
+

{ERROR_TITLE}

+

{ERROR_MSG}

+
+ +

{BODY}

+{CONTENT} + +

onclick="return false;">{L_SUBMIT}

+ + + + + +
{L_GROUP} {L_TOTAL_MEMBERS}{L_PENDING_MEMBERS} {L_OPTIONS} {L_ACTION}
{groups.GROUP_NAME} {groups.TOTAL_MEMBERS}{groups.PENDING_MEMBERS} {L_SETTINGS} {L_MEMBERS} {L_DELETE}{L_DELETE}
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
{L_AVAILABLE_CONVERTORS}
{L_SOFTWARE}{L_VERSION}{L_AUTHOR}{L_CONVERT_OPTIONS}
{convertors.SOFTWARE}{convertors.VERSION}{convertors.AUTHOR}{L_CONVERT}
{L_NO_CONVERTORS}---
+ + +
+ + + + +
+ +
+ + {checks.LEGEND} +

{checks.LEGEND_EXPLAIN}

+ + +
+

{checks.TITLE_EXPLAIN}
+
{checks.RESULT}
+
+ + + +
+ + + diff --git a/phpBB/adm/style/installer_convert_old.html b/phpBB/adm/style/installer_convert_old.html new file mode 100644 index 0000000000..75cc151c9e --- /dev/null +++ b/phpBB/adm/style/installer_convert_old.html @@ -0,0 +1,134 @@ + + + + +

{TITLE}

+ +

{BODY}

+ + + +
+ +

{TITLE}

+ +

{BODY}

+ + +
+

{ERROR_TITLE}

+

{ERROR_MSG}

+
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
{L_AVAILABLE_CONVERTORS}
{L_SOFTWARE}{L_VERSION}{L_AUTHOR}{L_OPTIONS}
{convertors.SOFTWARE}{convertors.VERSION}{convertors.AUTHOR}{L_CONVERT}
{L_NO_CONVERTORS}---
+ + + +
+ +
+
+ +
+
+
+ +
+
+ +
+ + + +
+ + + + +
+ +
+ + {checks.LEGEND} +

{checks.LEGEND_EXPLAIN}

+ + +
+

{checks.TITLE_EXPLAIN}
+
{checks.RESULT}
+
+ + + +
+ + + +
+ + + + +
+ +
+ + {options.LEGEND} + + +
+

{options.TITLE_EXPLAIN}
+
{options.CONTENT}
+
+ + + + +
+ + + +

{L_MESSAGE}

+ +
+ {S_HIDDEN} + disabled="disabled" onclick="this.className = 'button1 disabled';" onsubmit="this.disabled = 'disabled';" name="submit" value="{L_SUBMIT}" /> +
+ + +
+ + + -- cgit v1.2.1 From a3f16c1f5fa7c22687840f7760fdc40a36c6d545 Mon Sep 17 00:00:00 2001 From: Mate Bartus Date: Fri, 29 Jan 2016 13:55:49 +0100 Subject: [ticket/14262] Remove converter template duplicate PHPBB3-14262 --- phpBB/adm/style/installer_convert_old.html | 134 ----------------------------- 1 file changed, 134 deletions(-) delete mode 100644 phpBB/adm/style/installer_convert_old.html (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/installer_convert_old.html b/phpBB/adm/style/installer_convert_old.html deleted file mode 100644 index 75cc151c9e..0000000000 --- a/phpBB/adm/style/installer_convert_old.html +++ /dev/null @@ -1,134 +0,0 @@ - - - - -

{TITLE}

- -

{BODY}

- - - -
- -

{TITLE}

- -

{BODY}

- - -
-

{ERROR_TITLE}

-

{ERROR_MSG}

-
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
{L_AVAILABLE_CONVERTORS}
{L_SOFTWARE}{L_VERSION}{L_AUTHOR}{L_OPTIONS}
{convertors.SOFTWARE}{convertors.VERSION}{convertors.AUTHOR}{L_CONVERT}
{L_NO_CONVERTORS}---
- - - -
- -
-
- -
-
-
- -
-
- -
- - - -
- - - - -
- -
- - {checks.LEGEND} -

{checks.LEGEND_EXPLAIN}

- - -
-

{checks.TITLE_EXPLAIN}
-
{checks.RESULT}
-
- - - -
- - - -
- - - - -
- -
- - {options.LEGEND} - - -
-

{options.TITLE_EXPLAIN}
-
{options.CONTENT}
-
- - - - -
- - - -

{L_MESSAGE}

- -
- {S_HIDDEN} - disabled="disabled" onclick="this.className = 'button1 disabled';" onsubmit="this.disabled = 'disabled';" name="submit" value="{L_SUBMIT}" /> -
- - -
- - - -- cgit v1.2.1 From 43cdb35b848b914d11cc1ccb57f84497a012db86 Mon Sep 17 00:00:00 2001 From: Mate Bartus Date: Fri, 29 Jan 2016 17:06:23 +0100 Subject: [ticket/14438] Allign progressbar text to center PHPBB3-14438 --- phpBB/adm/style/admin.css | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/admin.css b/phpBB/adm/style/admin.css index e38e1cc3d7..4bb9922d56 100644 --- a/phpBB/adm/style/admin.css +++ b/phpBB/adm/style/admin.css @@ -2554,6 +2554,7 @@ fieldset.permissions .padding { #progress-bar { position: relative; width: 90%; + text-align: center; height: 25px; margin: 20px auto; border: 1px solid #cecece; @@ -2563,10 +2564,7 @@ fieldset.permissions .padding { position: absolute; top: 0; width: 100%; - text-align: center; - line-height: 25px; - font-weight: bold; - color: #fff; + color: #000; } #progress-bar #progress-bar-filler { @@ -2577,4 +2575,11 @@ fieldset.permissions .padding { background-color: #3c84ad; width: 0; height: 25px; + overflow: hidden; + color: #fff; +} + +#progress-bar p { + line-height: 25px; + font-weight: bold; } -- cgit v1.2.1 From 91f809dc3dc926ff858e5e53ee8cfed781c1aeaa Mon Sep 17 00:00:00 2001 From: Mate Bartus Date: Tue, 2 Feb 2016 16:09:40 +0100 Subject: [ticket/14262] Add error handling and small CS fixes PHPBB3-14262 --- phpBB/adm/style/installer_convert.html | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/installer_convert.html b/phpBB/adm/style/installer_convert.html index 8f1c51a1cb..aa16542b6b 100644 --- a/phpBB/adm/style/installer_convert.html +++ b/phpBB/adm/style/installer_convert.html @@ -6,6 +6,14 @@

{ERROR_MSG}

+ +
+ + {errors.TITLE} +

{errors.DESCRIPTION}

+ +
+

{BODY}

{CONTENT} -- cgit v1.2.1 From 2084404d2a0648d406749d67e44f1ba3ba44d7df Mon Sep 17 00:00:00 2001 From: Oliver Schramm Date: Sat, 13 Feb 2016 23:10:40 +0100 Subject: [ticket/14462] Make timeout error translateable PHPBB3-14462 --- phpBB/adm/style/installer_footer.html | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/installer_footer.html b/phpBB/adm/style/installer_footer.html index 63aebec993..fefa8f6d3f 100644 --- a/phpBB/adm/style/installer_footer.html +++ b/phpBB/adm/style/installer_footer.html @@ -11,6 +11,15 @@
+ + -- cgit v1.2.1 From 49736322887029b409ff177eafca9581c6622e83 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Fri, 5 Feb 2016 23:48:57 +0100 Subject: [ticket/14315] Only add role options specified for each group PHPBB3-14315 --- phpBB/adm/style/permission_mask.html | 2 ++ 1 file changed, 2 insertions(+) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/permission_mask.html b/phpBB/adm/style/permission_mask.html index 347da3181e..75e76b157d 100644 --- a/phpBB/adm/style/permission_mask.html +++ b/phpBB/adm/style/permission_mask.html @@ -46,7 +46,9 @@ -- cgit v1.2.1 From eab1b1ad11ae2e42cf4f6c3af9f7171d6dd0837b Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Fri, 5 Feb 2016 23:59:19 +0100 Subject: [ticket/14315] Correctly set default values and reset values The permissions tooltip javascript failed at correctly passing the default values to the page. The same applied to the display_mask() method in includes/acp/auth.php. PHPBB3-14315 --- phpBB/adm/style/permission_mask.html | 2 +- phpBB/adm/style/tooltip.js | 32 ++++++++++++++++---------------- 2 files changed, 17 insertions(+), 17 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/permission_mask.html b/phpBB/adm/style/permission_mask.html index 75e76b157d..aa18a40cb7 100644 --- a/phpBB/adm/style/permission_mask.html +++ b/phpBB/adm/style/permission_mask.html @@ -52,7 +52,7 @@ {% endfor %}
- +
{% else %} diff --git a/phpBB/adm/style/tooltip.js b/phpBB/adm/style/tooltip.js index 68964034f0..3abeefbffe 100644 --- a/phpBB/adm/style/tooltip.js +++ b/phpBB/adm/style/tooltip.js @@ -141,20 +141,32 @@ phpbb.positionTooltip = function ($element) { */ phpbb.prepareRolesDropdown = function () { var $options = $('.roles-options li'); - var $rolesOptions = $options.closest('.roles-options'); - var $span = $rolesOptions.children('span'); // Prepare highlighting of select options and settings update $options.each(function () { var $this = $(this); + var $rolesOptions = $this.closest('.roles-options'); + var $span = $rolesOptions.children('span'); // Correctly show selected option if (typeof $this.attr('data-selected') !== 'undefined') { - $rolesOptions.closest('.roles-options') + $rolesOptions .children('span') .text($this.text()) .attr('data-default', $this.text()) .attr('data-default-val', $this.attr('data-id')); + + // Save default text of drop down if there is no default set yet + if (typeof $span.attr('data-default') === 'undefined') { + $span.attr('data-default', $span.text()); + } + + // Prepare resetting drop down on form reset + $this.closest('form').on('reset', function () { + $span.text($span.attr('data-default')); + $rolesOptions.children('input[type=hidden]') + .val($span.attr('data-default-val')); + }); } $this.on('mouseover', function () { @@ -163,6 +175,7 @@ phpbb.prepareRolesDropdown = function () { $this.addClass('roles-highlight'); }).on('click', function () { var $this = $(this); + var $rolesOptions = $this.closest('.roles-options'); // Update settings set_role_settings($this.attr('data-id'), $this.attr('data-target-id')); @@ -178,19 +191,6 @@ phpbb.prepareRolesDropdown = function () { $('body').trigger('click'); }); }); - - // Save default text of drop down if there is no default set yet - if (typeof $span.attr('data-default') === 'undefined') { - $span.attr('data-default', $span.text()); - } - - // Prepare resetting drop down on form reset - $options.closest('form').on('reset', function () { - $span.text($span.attr('data-default')); - $rolesOptions.children('input[type=hidden]') - .val($span.attr('data-id')); - }); - }; // Run onload functions for RolesDropdown and tooltips -- cgit v1.2.1 From 4cfba8f3a40c424d831b6034bdf1dc4975822406 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Sat, 6 Feb 2016 09:33:33 +0100 Subject: [ticket/14315] Build role options for each permission group Previously all role options were put into one array. This required filtering the options. Instead, these are now passed to the template via template loops. PHPBB3-14315 --- phpBB/adm/style/permission_mask.html | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/permission_mask.html b/phpBB/adm/style/permission_mask.html index aa18a40cb7..721fc42473 100644 --- a/phpBB/adm/style/permission_mask.html +++ b/phpBB/adm/style/permission_mask.html @@ -39,16 +39,14 @@
- {% if role_options %} + {% if p_mask.f_mask.role_options %}
-- cgit v1.2.1 From cc7a0aa4fb2d6c8efd5c78df7d68328c9f8d4d32 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Mon, 1 Feb 2016 13:55:36 +0100 Subject: [ticket/14492] Use guzzle for submitting data to stats service PHPBB3-14492 --- phpBB/adm/style/acp_help_phpbb.html | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/acp_help_phpbb.html b/phpBB/adm/style/acp_help_phpbb.html index 347d39af86..cbbe42e8c7 100644 --- a/phpBB/adm/style/acp_help_phpbb.html +++ b/phpBB/adm/style/acp_help_phpbb.html @@ -4,6 +4,7 @@

{L_ACP_HELP_PHPBB}

+

Send statistics

@@ -47,6 +48,13 @@
Enable
+
+

+ +

+ {S_FORM_TOKEN} +
+
-- cgit v1.2.1 From c07ecb060dd04c76d8bd166a0a8a7226a8167f06 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Tue, 2 Feb 2016 12:19:55 +0100 Subject: [ticket/14492] Add events for modifying help phpBB page PHPBB3-14492 --- phpBB/adm/style/acp_help_phpbb.html | 17 ++++------------- phpBB/adm/style/admin.css | 6 ------ 2 files changed, 4 insertions(+), 19 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/acp_help_phpbb.html b/phpBB/adm/style/acp_help_phpbb.html index cbbe42e8c7..a9406e2c2e 100644 --- a/phpBB/adm/style/acp_help_phpbb.html +++ b/phpBB/adm/style/acp_help_phpbb.html @@ -6,6 +6,7 @@
+

Send statistics

{L_EXPLAIN_SEND_STATISTICS}

@@ -31,23 +32,13 @@
- - + checked="checked" /> +
{L_SEND_STATISTICS_LONG}
-
-

VigLink

-

{L_EXPLAIN_ENABLE_VIGLINK}

-
-
- - -
-
Enable
-
-
+

diff --git a/phpBB/adm/style/admin.css b/phpBB/adm/style/admin.css index d4df01dba7..bcf01fe597 100644 --- a/phpBB/adm/style/admin.css +++ b/phpBB/adm/style/admin.css @@ -2612,12 +2612,6 @@ fieldset.permissions .padding { padding-right: 0.3em; } -.viglink-header { - background: url('http://www.viglink.com/wp-content/uploads/2015/05/favicon-96x96.png') no-repeat 0 0; - padding-left: 30px; - background-size: 25px; -} - .icon { font-family: FontAwesome; font-style: normal; -- cgit v1.2.1 From 80a63a9a94af042da37227ed747eba0feeac1049 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Sat, 20 Feb 2016 11:58:36 +0100 Subject: [ticket/14492] Add missing input name PHPBB3-14492 --- phpBB/adm/style/acp_help_phpbb.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/acp_help_phpbb.html b/phpBB/adm/style/acp_help_phpbb.html index a9406e2c2e..d2f5e76916 100644 --- a/phpBB/adm/style/acp_help_phpbb.html +++ b/phpBB/adm/style/acp_help_phpbb.html @@ -32,7 +32,7 @@

- checked="checked" /> + checked="checked" />
{L_SEND_STATISTICS_LONG}
-- cgit v1.2.1 From 89fef2ce13a183c7b963032274f455a09a05f325 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Sun, 21 Feb 2016 22:14:58 +0100 Subject: [ticket/14492] Send statistics via ajax request Flooding ajax requests will try to be prevented and sending stats without JS will also properly work. PHPBB3-14492 --- phpBB/adm/style/acp_help_phpbb.html | 16 ++++-- phpBB/adm/style/admin.js | 7 ++- phpBB/adm/style/ajax.js | 99 +++++++++++++++++++++++++++++++++++++ 3 files changed, 118 insertions(+), 4 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/acp_help_phpbb.html b/phpBB/adm/style/acp_help_phpbb.html index d2f5e76916..48a4595913 100644 --- a/phpBB/adm/style/acp_help_phpbb.html +++ b/phpBB/adm/style/acp_help_phpbb.html @@ -4,7 +4,7 @@

{L_ACP_HELP_PHPBB}

- +
@@ -12,9 +12,9 @@

{L_EXPLAIN_SEND_STATISTICS}

-
+
@@ -41,11 +41,21 @@

+ +

{S_FORM_TOKEN}
+
+
+

+ + +

+
+
diff --git a/phpBB/adm/style/admin.js b/phpBB/adm/style/admin.js index e42fdb380a..551c78a4a3 100644 --- a/phpBB/adm/style/admin.js +++ b/phpBB/adm/style/admin.js @@ -243,11 +243,16 @@ function parse_document(container) parse_document($('body')); - $('#trigger-configlist').on('click', function () { + $('#questionnaire-form').css('display', 'none'); + var $triggerConfiglist = $('#trigger-configlist'); + + $triggerConfiglist.on('click', function () { var $configlist = $('#configlist'); $configlist.closest('.send-stats-data-row').toggleClass('send-stats-data-hidden'); $configlist.closest('.send-stats-row').find('.send-stats-data-row:first-child').toggleClass('send-stats-data-only-row'); $(this).find('i').toggleClass('fa-angle-down fa-angle-up'); }); + + $('#configlist').closest('.send-stats-data-row').addClass('send-stats-data-hidden'); }); })(jQuery); diff --git a/phpBB/adm/style/ajax.js b/phpBB/adm/style/ajax.js index 3c1c57505b..1d4e00dfa4 100644 --- a/phpBB/adm/style/ajax.js +++ b/phpBB/adm/style/ajax.js @@ -4,6 +4,101 @@ 'use strict'; + +phpbb.prepareSendStats = function () { + var $form = $('#acp_help_phpbb'); + var $dark = $('#darkenwrapper'); + var $loadingIndicator; + + $form.on('submit', function () { + var $this = $(this), + currentTime = Math.floor(new Date().getTime() / 1000), + statsTime = parseInt($this.find('input[name=help_send_statistics_time]').val(), 10); + + event.preventDefault(); + $this.unbind('submit'); + + // Skip ajax request if form is submitted too early or send stats + // checkbox is not checked + if (!$this.find('input[name=help_send_statistics]').is(':checked') || + statsTime > currentTime) { + $form.find('input[type=submit]').click(); + setTimeout(function () { + $form.find('input[type=submit]').click(); + }, 300); + return; + } + + /** + * Handler for AJAX errors + */ + function errorHandler(jqXHR, textStatus, errorThrown) { + if (typeof console !== 'undefined' && console.log) { + console.log('AJAX error. status: ' + textStatus + ', message: ' + errorThrown); + } + phpbb.clearLoadingTimeout(); + var errorText = ''; + + if (typeof errorThrown === 'string' && errorThrown.length > 0) { + errorText = errorThrown; + } else { + errorText = $dark.attr('data-ajax-error-text-' + textStatus); + if (typeof errorText !== 'string' || !errorText.length) { + errorText = $dark.attr('data-ajax-error-text'); + } + } + phpbb.alert($dark.attr('data-ajax-error-title'), errorText); + } + + /** + * This is a private function used to handle the callbacks, refreshes + * and alert. It calls the callback, refreshes the page if necessary, and + * displays an alert to the user and removes it after an amount of time. + * + * It cannot be called from outside this function, and is purely here to + * avoid repetition of code. + * + * @param {object} res The object sent back by the server. + */ + function returnHandler(res) { + phpbb.clearLoadingTimeout(); + + // If a confirmation is not required, display an alert and call the + // callbacks. + $dark.fadeOut(phpbb.alertTime); + + if ($loadingIndicator) { + $loadingIndicator.fadeOut(phpbb.alertTime); + } + + var $sendStatisticsSuccess = $('', { + type: 'hidden', + name: 'send_statistics_response', + value: res + }); + $sendStatisticsSuccess.appendTo('p.submit-buttons'); + + // Finish actual form submission + $form.find('input[type=submit]').click(); + } + + $loadingIndicator = phpbb.loadingIndicator(); + + $.ajax({ + url: $this.attr('data-ajax-action').replace('&', '&'), + type: 'POST', + data: 'systemdata=' + $this.find('input[name=systemdata]').val(), + success: returnHandler, + error: errorHandler, + cache: false + }).always(function() { + if ($loadingIndicator && $loadingIndicator.is(':visible')) { + $loadingIndicator.fadeOut(phpbb.alertTime); + } + }); + }); +}; + /** * The following callbacks are for reording items. row_down * is triggered when an item is moved down, and row_up is triggered when @@ -225,6 +320,10 @@ $(function() { $(this).attr('data-clicked', true); }); } + + if ($('#acp_help_phpbb')) { + phpbb.prepareSendStats(); + } }); -- cgit v1.2.1 From afe16a62724451cb5c7eca7864a3c110404f4e2a Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Sat, 3 Sep 2016 10:47:20 +0200 Subject: [ticket/14492] Add missing event variable PHPBB3-14492 --- phpBB/adm/style/ajax.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/ajax.js b/phpBB/adm/style/ajax.js index 1d4e00dfa4..28f761bc0b 100644 --- a/phpBB/adm/style/ajax.js +++ b/phpBB/adm/style/ajax.js @@ -10,7 +10,7 @@ phpbb.prepareSendStats = function () { var $dark = $('#darkenwrapper'); var $loadingIndicator; - $form.on('submit', function () { + $form.on('submit', function (event) { var $this = $(this), currentTime = Math.floor(new Date().getTime() / 1000), statsTime = parseInt($this.find('input[name=help_send_statistics_time]').val(), 10); -- cgit v1.2.1 From 9b4190e1365aed639068d341cb4296e895ad4ba1 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Wed, 9 Nov 2016 22:02:46 +0100 Subject: [ticket/14492] Encode URI components in systemdata for stats The stats data needs to be URI encoded to prevent issues when submitting the data to the receive_stats script on www.phpbb.com. PHPBB3-14492 --- phpBB/adm/style/ajax.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/ajax.js b/phpBB/adm/style/ajax.js index 28f761bc0b..d5154b2a61 100644 --- a/phpBB/adm/style/ajax.js +++ b/phpBB/adm/style/ajax.js @@ -87,7 +87,7 @@ phpbb.prepareSendStats = function () { $.ajax({ url: $this.attr('data-ajax-action').replace('&', '&'), type: 'POST', - data: 'systemdata=' + $this.find('input[name=systemdata]').val(), + data: 'systemdata=' + encodeURIComponent($this.find('input[name=systemdata]').val()), success: returnHandler, error: errorHandler, cache: false -- cgit v1.2.1 From a2793f24b1b4394871e897679fd407ba703d1937 Mon Sep 17 00:00:00 2001 From: Derky Date: Fri, 9 Dec 2016 20:03:00 +0100 Subject: [ticket/14901] Remove notice for extension without version check Extensions without version check should not display a notice on the details page in the ACP. PHPBB3-14901 --- phpBB/adm/style/acp_ext_details.html | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/acp_ext_details.html b/phpBB/adm/style/acp_ext_details.html index 830c2e3cb4..4c1feb59a9 100644 --- a/phpBB/adm/style/acp_ext_details.html +++ b/phpBB/adm/style/acp_ext_details.html @@ -7,19 +7,17 @@

{L_EXTENSIONS_ADMIN}

-
-

{UP_TO_DATE_MSG} - {L_VERSIONCHECK_FORCE_UPDATE}

-
- -
-

{L_VERSIONCHECK_FAIL}

-

{VERSIONCHECK_FAIL_REASON}

-

{L_VERSIONCHECK_FORCE_UPDATE}

-
- -
-

{VERSIONCHECK_FAIL_REASON}

-
+ +
+

{L_VERSIONCHECK_FAIL}

+

{VERSIONCHECK_FAIL_REASON}

+

{L_VERSIONCHECK_FORCE_UPDATE}

+
+ +
+

{UP_TO_DATE_MSG} - {L_VERSIONCHECK_FORCE_UPDATE}

+
+
-- cgit v1.2.1 From dfe42e96035ed63e92f8c14a553c3631c1ea08e4 Mon Sep 17 00:00:00 2001 From: Christian Schnegelberger Date: Sat, 10 Dec 2016 21:50:09 +0100 Subject: [ticket/14908] Uses lang-variable instead of english text PHPBB3-14908 --- phpBB/adm/style/acp_help_phpbb.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/acp_help_phpbb.html b/phpBB/adm/style/acp_help_phpbb.html index 48a4595913..478ecc162a 100644 --- a/phpBB/adm/style/acp_help_phpbb.html +++ b/phpBB/adm/style/acp_help_phpbb.html @@ -8,7 +8,7 @@
-

Send statistics

+

{L_SEND_STATISTICS}

{L_EXPLAIN_SEND_STATISTICS}

-- cgit v1.2.1 From 80ecad5cf922527b976680d570041bd47f888d5d Mon Sep 17 00:00:00 2001 From: Vinny Date: Wed, 1 Feb 2017 02:34:01 -0300 Subject: [ticket/15062] Update to Rhea version the CSS files PHPBB3-15062 --- phpBB/adm/style/admin.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/admin.css b/phpBB/adm/style/admin.css index bcf01fe597..d46530700f 100644 --- a/phpBB/adm/style/admin.css +++ b/phpBB/adm/style/admin.css @@ -1,4 +1,4 @@ -/* phpBB 3.1 Admin Style Sheet +/* phpBB 3.2 Admin Style Sheet ------------------------------------------------------------------------ Original author: subBlue ( http://www.subblue.com/ ) Copyright (c) phpBB Limited -- cgit v1.2.1 From b4821907b7f8acf84229f95018688636c8aad159 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Sat, 11 Feb 2017 11:19:46 +0100 Subject: [ticket/15083] Fix invalid emoji sizing in ACP & print view PHPBB3-15083 --- phpBB/adm/style/admin.css | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/admin.css b/phpBB/adm/style/admin.css index d46530700f..2ad964e6bb 100644 --- a/phpBB/adm/style/admin.css +++ b/phpBB/adm/style/admin.css @@ -2691,3 +2691,10 @@ fieldset.permissions .padding { word-wrap: break-word; word-break: break-all; } + +.emoji { + min-height: 18px; + min-width: 18px; + height: 1em; + width: 1em; +} -- cgit v1.2.1 From c06f4756eca4dfbbdad8984a62976745aeb183dd Mon Sep 17 00:00:00 2001 From: nomind60s Date: Fri, 17 Feb 2017 13:44:42 -0700 Subject: [ticket/15097] Add PHP version to Board statistics The ACP main page shows the phpBB version and the database version, but didn't show the PHP version. With this change the PHP version is displayed as part of the Board statistics. PHPBB3-15097 --- phpBB/adm/style/acp_main.html | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/acp_main.html b/phpBB/adm/style/acp_main.html index 1bdb7b8d2a..944cf10ea5 100644 --- a/phpBB/adm/style/acp_main.html +++ b/phpBB/adm/style/acp_main.html @@ -167,6 +167,10 @@   + + {L_PHP_VERSION}{L_COLON} + {PHP_VERSION} + -- cgit v1.2.1 From c30ad4ce60267a1301a406c3d0279f95b856f5a5 Mon Sep 17 00:00:00 2001 From: nomind60s Date: Fri, 17 Feb 2017 14:19:18 -0700 Subject: [ticket/15097] Add PHP version to Board statistics Rework commit message per DavidIQ's guidance and change variable name to avoid confusion PHPBB3-15907 --- phpBB/adm/style/acp_main.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/acp_main.html b/phpBB/adm/style/acp_main.html index 944cf10ea5..5f8040b57e 100644 --- a/phpBB/adm/style/acp_main.html +++ b/phpBB/adm/style/acp_main.html @@ -169,7 +169,7 @@ {L_PHP_VERSION}{L_COLON} - {PHP_VERSION} + {PHP_VERSION_INFO} -- cgit v1.2.1 From f677376b8ca4451e3a0c415f603ad1513ed24ef7 Mon Sep 17 00:00:00 2001 From: nomind60s Date: Sun, 19 Feb 2017 11:49:07 -0700 Subject: [ticket/15097] New 'Installed software' lead section Created a new lead section showing the installed software (phpBB, PHP and Database server) and their versions. Implementation is inspired by MediaWiki's Special:Version page. Removed those items from Board statistics section. PHPBB3-15097 --- phpBB/adm/style/acp_main.html | 59 +++++++++++++++++++++++++------------------ 1 file changed, 35 insertions(+), 24 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/acp_main.html b/phpBB/adm/style/acp_main.html index 5f8040b57e..e306ce78e9 100644 --- a/phpBB/adm/style/acp_main.html +++ b/phpBB/adm/style/acp_main.html @@ -94,15 +94,45 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + +
{L_SOFTWARE_HEADING}
{L_SOFTWARE_PRODUCT}{L_SOFTWARE_VERSION}
{L_BOARD_VERSION}style="color: #228822;" style="color: #BC2A4D;" title="{L_MORE_INFORMATION}">{BOARD_VERSION}{L_VERSIONCHECK_FORCE_UPDATE} ] + {BOARD_VERSION}
{L_PHP_VERSION}{PHP_VERSION_INFO}
{L_DATABASE_SERVER_INFO}{DATABASE_INFO}
+ - - - - + + + + @@ -130,8 +160,6 @@ - - @@ -145,33 +173,16 @@ - - - - - - - - - - - + - - - - -
{L_FORUM_STATS}
{L_STATISTIC}{L_VALUE}{L_STATISTIC}{L_VALUE}{L_STATISTIC}{L_VALUE}{L_STATISTIC}{L_VALUE}
{L_FILES_PER_DAY}{L_COLON} {FILES_PER_DAY}
{L_BOARD_STARTED}{L_COLON} {START_DATE}{UPLOAD_DIR_SIZE}
{L_DATABASE_SERVER_INFO}{L_COLON} {DATABASE_INFO} {L_GZIP_COMPRESSION}{L_COLON} {GZIP_COMPRESSION}
{L_BOARD_VERSION}{L_COLON} - style="color: #228822;" style="color: #BC2A4D;" title="{L_MORE_INFORMATION}">{BOARD_VERSION}{L_VERSIONCHECK_FORCE_UPDATE} ] - {L_NUMBER_ORPHAN}{L_COLON} {TOTAL_ORPHAN}    
{L_PHP_VERSION}{L_COLON} {PHP_VERSION_INFO}
-- cgit v1.2.1 From f36eb932a4bfe0e56fd01753531dbc7a31db1b1f Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Wed, 8 Mar 2017 21:36:27 +0100 Subject: [ticket/15083] Add stylelint exceptions for admin.css PHPBB3-15083 --- phpBB/adm/style/admin.css | 2 ++ 1 file changed, 2 insertions(+) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/admin.css b/phpBB/adm/style/admin.css index 2ad964e6bb..2322b3da88 100644 --- a/phpBB/adm/style/admin.css +++ b/phpBB/adm/style/admin.css @@ -2692,9 +2692,11 @@ fieldset.permissions .padding { word-break: break-all; } +/* stylelint-disable declaration-property-unit-whitelist */ .emoji { min-height: 18px; min-width: 18px; height: 1em; width: 1em; } +/* stylelint-enable declaration-property-unit-whitelist */ -- cgit v1.2.1 From 95f61af798a304e3edce6cca3ab6489e02806b04 Mon Sep 17 00:00:00 2001 From: Matt Friedman Date: Wed, 26 Apr 2017 09:34:15 -0700 Subject: [ticket/15198] Add PHP version to board stats in the ACP PHPBB3-15198 --- phpBB/adm/style/acp_main.html | 54 ++++++++++++++++--------------------------- 1 file changed, 20 insertions(+), 34 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/acp_main.html b/phpBB/adm/style/acp_main.html index e306ce78e9..9522baa9c2 100644 --- a/phpBB/adm/style/acp_main.html +++ b/phpBB/adm/style/acp_main.html @@ -94,45 +94,15 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - -
{L_SOFTWARE_HEADING}
{L_SOFTWARE_PRODUCT}{L_SOFTWARE_VERSION}
{L_BOARD_VERSION}style="color: #228822;" style="color: #BC2A4D;" title="{L_MORE_INFORMATION}">{BOARD_VERSION}{L_VERSIONCHECK_FORCE_UPDATE} ] - {BOARD_VERSION}
{L_PHP_VERSION}{PHP_VERSION_INFO}
{L_DATABASE_SERVER_INFO}{DATABASE_INFO}
- - - - - + + + + @@ -173,8 +143,14 @@ + + + + + + @@ -183,6 +159,16 @@ + + + + + + + +
{L_FORUM_STATS}
{L_STATISTIC}{L_VALUE}{L_STATISTIC}{L_VALUE}{L_STATISTIC}{L_VALUE}{L_STATISTIC}{L_VALUE}
{UPLOAD_DIR_SIZE}
{L_DATABASE_SERVER_INFO}{L_COLON} {DATABASE_INFO} {L_GZIP_COMPRESSION}{L_COLON} {GZIP_COMPRESSION}
{L_PHP_VERSION}{L_COLON} {PHP_VERSION_INFO} {L_NUMBER_ORPHAN}{L_COLON} {TOTAL_ORPHAN} 
{L_BOARD_VERSION}{L_COLON} + style="color: #228822;" style="color: #BC2A4D;" title="{L_MORE_INFORMATION}">{BOARD_VERSION}{L_VERSIONCHECK_FORCE_UPDATE} ] +   
-- cgit v1.2.1 From d84834db88ea54bc33a323457236943a56399747 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Sun, 23 Jul 2017 21:09:30 +0200 Subject: [ticket/15293] Prevent continuing to database update on incomplete file update PHPBB3-15293 --- phpBB/adm/style/acp_board.html | 7 ++++--- phpBB/adm/style/installer_form.html | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/acp_board.html b/phpBB/adm/style/acp_board.html index 64592a5de2..04dee98276 100644 --- a/phpBB/adm/style/acp_board.html +++ b/phpBB/adm/style/acp_board.html @@ -18,10 +18,11 @@ -
- + +
- {options.LEGEND} + + {options.LEGEND}
diff --git a/phpBB/adm/style/installer_form.html b/phpBB/adm/style/installer_form.html index cc5b041fa1..a38f33c7c2 100644 --- a/phpBB/adm/style/installer_form.html +++ b/phpBB/adm/style/installer_form.html @@ -49,7 +49,7 @@
{L_SUBMIT} - + disabled="disabled" />
-- cgit v1.2.1 From b6cb353239b00ad08e76594973035283afc9afb1 Mon Sep 17 00:00:00 2001 From: javiexin Date: Sun, 6 Aug 2017 14:22:57 +0200 Subject: [ticket/15307] Extensions may add modes to acp_users Includes both PHP and Template events. PHPBB3-15307 --- phpBB/adm/style/acp_users.html | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/acp_users.html b/phpBB/adm/style/acp_users.html index 18c3d84f96..50b6ec9bc9 100644 --- a/phpBB/adm/style/acp_users.html +++ b/phpBB/adm/style/acp_users.html @@ -231,6 +231,10 @@ + + + + -- cgit v1.2.1 From 9adf7474a9ca4a04da3636c1d867b8cdbcd07ea8 Mon Sep 17 00:00:00 2001 From: Oliver Schramm Date: Sat, 9 Sep 2017 19:06:12 +0200 Subject: [ticket/15353] Fix html in acp_board.html PHPBB3-15353 --- phpBB/adm/style/acp_board.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'phpBB/adm/style') diff --git a/phpBB/adm/style/acp_board.html b/phpBB/adm/style/acp_board.html index 04dee98276..fe3e250099 100644 --- a/phpBB/adm/style/acp_board.html +++ b/phpBB/adm/style/acp_board.html @@ -19,9 +19,9 @@
+
- {options.LEGEND} -- cgit v1.2.1