From dbc164e13188a8adf4478c1b4b3ce563e16486c3 Mon Sep 17 00:00:00 2001
From: 3D-I <480857+3D-I@users.noreply.github.com>
Date: Sun, 22 Dec 2019 21:03:35 +0100
Subject: [ticket/16260] Missing check whether the index exists in ACP - PHP
 7.4

PHPBB3-16260
---
 phpBB/includes/acp/acp_board.php | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

diff --git a/phpBB/includes/acp/acp_board.php b/phpBB/includes/acp/acp_board.php
index 2285ac997e..cd72a8748a 100644
--- a/phpBB/includes/acp/acp_board.php
+++ b/phpBB/includes/acp/acp_board.php
@@ -530,17 +530,14 @@ class acp_board
 
 			if ($submit)
 			{
-				if (isset($data['type']))
+				if (isset($data['type']) && strpos($data['type'], 'password') === 0 && $config_value === '********')
 				{
-					if (strpos($data['type'], 'password') === 0 && $config_value === '********')
-					{
-						/**
-						 * Do not update password fields if the content is ********,
-						 * because that is the password replacement we use to not
-						 * send the password to the output
-						 */
-						continue;
-					}
+					/**
+					 * Do not update password fields if the content is ********,
+					 * because that is the password replacement we use to not
+					 * send the password to the output
+					 */
+					continue;
 				}
 
 				$config->set($config_name, $config_value);
-- 
cgit v1.2.1