From a0ffbfce315ce45df4085d4c83536f2024e71a3f Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Fri, 3 Jan 2020 10:17:40 +0100 Subject: [ticket/16287] Correctly pass json response to PHP file PHPBB3-16287 --- phpBB/adm/style/ajax.js | 2 +- phpBB/includes/acp/acp_help_phpbb.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/phpBB/adm/style/ajax.js b/phpBB/adm/style/ajax.js index b9424723bb..39b63e4696 100644 --- a/phpBB/adm/style/ajax.js +++ b/phpBB/adm/style/ajax.js @@ -74,7 +74,7 @@ phpbb.prepareSendStats = function () { var $sendStatisticsSuccess = $('', { type: 'hidden', name: 'send_statistics_response', - value: res + value: JSON.stringify(res) }); $sendStatisticsSuccess.appendTo('p.submit-buttons'); diff --git a/phpBB/includes/acp/acp_help_phpbb.php b/phpBB/includes/acp/acp_help_phpbb.php index 2b603d63f4..798cff5cee 100644 --- a/phpBB/includes/acp/acp_help_phpbb.php +++ b/phpBB/includes/acp/acp_help_phpbb.php @@ -90,7 +90,7 @@ class acp_help_phpbb if (!empty($response)) { - $decoded_response = json_decode($response, true); + $decoded_response = json_decode(htmlspecialchars_decode($response), true); if ($decoded_response && isset($decoded_response['status']) && $decoded_response['status'] == 'ok') { -- cgit v1.2.1