| Commit message (Collapse) | Author | Age | Files | Lines |
| |\
| |
| |
| |
| | |
* develop-olympus:
[ticket/10346] Add drop_tables to perform_schema_changes and add tests
|
| | |
| |
| |
| | |
PHPBB3-10346
|
| |\ \
| |/
| |
| |
| | |
* develop-olympus:
[ticket/10335] Add X-PHPBB-IS-BOT header so reverse proxies know about bots.
|
| | |\
| | |
| | |
| | |
| | | |
* github-bantu/ticket/10335:
[ticket/10335] Add X-PHPBB-IS-BOT header so reverse proxies know about bots.
|
| | | |
| | |
| | |
| | | |
PHPBB3-10335
|
| |\ \ \
| |/ /
| | |
| | |
| | |
| | | |
* develop-olympus:
[ticket/10320] Exclude passworded forums when determining "Most active topic".
[ticket/10320] Move phpbb_feed_base::get_passworded_forums() to user class.
|
| | |\ \
| | | |
| | | |
| | | |
| | | |
| | | | |
* github-bantu/ticket/10320:
[ticket/10320] Exclude passworded forums when determining "Most active topic".
[ticket/10320] Move phpbb_feed_base::get_passworded_forums() to user class.
|
| | | | |
| | | |
| | | |
| | | | |
PHPBB3-10320
|
| | | |/
| | |
| | |
| | | |
PHPBB3-10320
|
| |\ \ \
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* develop-olympus:
[ticket/9995] Do not run forum SQL query when marking the whole board read.
[ticket/9995] Always continue when harvesting $forum_ids for markread().
[ticket/9995] Remove useless statement from display_forums()
Conflicts:
phpBB/includes/functions_display.php
|
| | | |
| | |
| | |
| | | |
PHPBB3-9995
|
| | | |
| | |
| | |
| | | |
PHPBB3-9995
|
| | |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The $forum_ids array is only used if $mark_read == 'forums'.
When $mark_read == 'forums', we either continue when
$auth->acl_get('f_list', $forum_id) is false or true.
So this statement is never useful.
PHPBB3-9995
|
| | |
| |
| |
| |
| |
| | |
Introduced by 6b4d0a254218e8d40151ca1bdff8c439f89502e9.
PHPBB3-10329
|
| |\ \
| |/
| |
| |
| | |
* develop-olympus:
[ticket/10240] Reverted a commit which added buggy code.
|
| | |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit f9dbe33fa7917b6220a85a01ed9f395f3f1bb888.
The code which was added also removed new lines and tabs.
PHPBB3-10240
|
| | |
| |
| |
| | |
PHPBB3-9716
|
| | |
| |
| |
| | |
PHPBB3-9716
|
| | |
| |
| |
| | |
PHPBB3-9716
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* develop: (157 commits)
[ticket/10316] Resolve inconsistent move topic behavior
[ticket/9297] Add network to class name of unit tests.
[ticket/9297] Fix typo in localhost.
[ticket/9297] Rename test class to reflect its contents.
[ticket/9297] Adjust comment - IPv6 is needed for IPv6 connections to work.
[ticket/9297] Fix markTestSkipped call in setUpBeforeClass.
[ticket/9608] Remove use of references in topic_review
[ticket/9297] Skip FTP PASV/EPSV test if FTP connection fails.
[ticket/9297] Separate ipv4 and ipv6 tests into separate functions.
[ticket/9297] Update copyright year of unit test file.
[feature/template-engine] Delete _get_locator function.
[feature/template-engine] Clean up template locator usage in bbcode.
[ticket/9297] Make EPSV unit tests work without IPv6.
[ticket/9297] Unit tests for ftp_fsock PASV and EPSV.
[ticket/9297] Add support for Extended Passive Mode (EPSV) in ftp_fsock class.
[ticket/10312] Un-check the shadow option while moving.
[feature/template-engine] Need to call set_template on template.
[feature/template-engine] Update installer for template engine changes.
[feature/template-engine] Dependency inject locator into template.
[feature/template-engine] Delete useless code from set_template.
...
Conflicts:
phpBB/includes/functions.php
|
| | |\ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* igorw/ticket/9608:
[ticket/9608] Remove use of references in topic_review
[ticket/9608] Revert changes to normalizer
[ticket/9608] Remove blank line
[ticket/9608] Remove use of references in captcha and other places
|
| | | | |
| | | |
| | | |
| | | | |
PHPBB3-9608
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
They were breaking the tests.
PHPBB3-9608
|
| | | | |
| | | |
| | | |
| | | | |
PHPBB3-9608
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
References are not really needed in PHP due to copy-on-write. Since
PHP5, objects are always passed around as identifiers, which means they
are mutable. So it is no longer required to pass these by reference
either.
PHPBB3-9608
|
| | |\ \ \
| | | |/
| | |/|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* develop-olympus:
[ticket/9297] Add network to class name of unit tests.
[ticket/9297] Fix typo in localhost.
[ticket/9297] Rename test class to reflect its contents.
[ticket/9297] Adjust comment - IPv6 is needed for IPv6 connections to work.
[ticket/9297] Fix markTestSkipped call in setUpBeforeClass.
[ticket/9297] Skip FTP PASV/EPSV test if FTP connection fails.
[ticket/9297] Separate ipv4 and ipv6 tests into separate functions.
[ticket/9297] Update copyright year of unit test file.
[ticket/9297] Make EPSV unit tests work without IPv6.
[ticket/9297] Unit tests for ftp_fsock PASV and EPSV.
[ticket/9297] Add support for Extended Passive Mode (EPSV) in ftp_fsock class.
|
| | | |\ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* bantu/ticket/9297:
[ticket/9297] Add network to class name of unit tests.
[ticket/9297] Fix typo in localhost.
[ticket/9297] Rename test class to reflect its contents.
[ticket/9297] Adjust comment - IPv6 is needed for IPv6 connections to work.
[ticket/9297] Fix markTestSkipped call in setUpBeforeClass.
[ticket/9297] Skip FTP PASV/EPSV test if FTP connection fails.
[ticket/9297] Separate ipv4 and ipv6 tests into separate functions.
[ticket/9297] Update copyright year of unit test file.
[ticket/9297] Make EPSV unit tests work without IPv6.
[ticket/9297] Unit tests for ftp_fsock PASV and EPSV.
[ticket/9297] Add support for Extended Passive Mode (EPSV) in ftp_fsock class.
|
| | | | | |
| | | | |
| | | | |
| | | | | |
PHPBB3-9297
|
| | |\ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* github-p/feature/template-engine: (87 commits)
[feature/template-engine] Delete _get_locator function.
[feature/template-engine] Clean up template locator usage in bbcode.
[feature/template-engine] Need to call set_template on template.
[feature/template-engine] Update installer for template engine changes.
[feature/template-engine] Dependency inject locator into template.
[feature/template-engine] Delete useless code from set_template.
[feature/template-engine] Delete no longer used $template_filename property.
[feature/template-engine] Delete useless $template globalization.
[feature/template-engine] Use template engine class in bbcode class.
[feature/template-engine] Corrected an error message in template locator.
[feature/template-engine] Remaining documentation.
[feature/template-engine] More documentation for template class.
[feature/template-engine] Create load_and_render to reduce code duplication.
[feature/template-engine] Get rid of orig_tpl_* in template engine.
[feature/template-engine] Delete $style_name param from locator's set_custom_template.
[feature/template-engine] Add constructor to template locator.
[feature/template-engine] Factor template locator out of template class.
[feature/template-engine] Delete $files_template property.
[feature/template-engine] Rename is_absolute to phpbb_is_absolute.
[feature/template-engine] Test template DEFINE statements across files
...
Conflicts:
.gitignore
phpBB/includes/template.php
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
It is no longer needed as locator is injected into template.
PHPBB3-9726
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
PHPBB3-9726
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
PHPBB3-9726
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
PHPBB3-9726
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
set_custom_template performs these calls, repeating them in
set_template is not needed.
PHPBB3-9726
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
PHPBB3-9726
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
PHPBB3-9726
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
PHPBB3-9726
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
PHPBB3-9726
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
PHPBB3-9726
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
PHPBB3-9726
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
PHPBB3-9726
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The origins of orig_tpl_* are not pretty. Please see the following commits
and associated tickets: r9823, r9839, r9847, r10150, r10460.
In short, multiple hacks were required due to template engine reading
inheritance/storedb flags from $user (global) even when the template that
was being looked up or rendered was not the "active style of the
current user".
We no longer store templates in the database, removing half of the problem.
This commit fixes the second half of the problem by deleting
set_template_path function from template locator, and moving that logic
back into the template class' set_template. set_template now calls
set_custom_template, the latter only taking the template path and the
fallback paths as parameters. With this change template locator no longer
uses $user and does not use phpbb root path either.
All logic involving setting the user's "active" template is now
encapsulated in a single template class's function, set_template.
Setting other templates is done via set_custom_template and the caller
is responsible for determining and passing in fallback/inheritance path,
if any.
PHPBB3-9726
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
set_custom_template.
This parameter was unused, it was only used by template's set_custom_template
to determine cache file prefix.
PHPBB3-9726
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
PHPBB3-9726
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Template locator is responsible for maintaining mapping from template
handles to filenames and paths, and provides resolution services
using these mappings.
Template locator is aware of template inheritance and is capable of
checking template file existence on the filesystem.
PHPBB3-9726
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This seems to have been used for db storage of templates.
We no longer offer db storage of templates, and thus currenty
$files_template is only written to but not read anywhere.
PHPBB3-9726
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
PHPBB3-9726
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Add docblocks for phpbb_template_filter, remove the useless constructor.
PHPBB3-9726
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
PHPBB3-9726
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
PHPBB3-9726
|