aboutsummaryrefslogtreecommitdiffstats
path: root/phpBB/includes/functions.php
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | [feature/request-class] Add server(), header() and is_ajax() to requestIgor Wiedler2011-07-151-14/+18
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Extend the request class with helpers for reading server vars (server()) and HTTP request headers (header()). Refactor the existing code base to make use of these helpers, make $_SERVER a deactivated super global. Also introduce an is_ajax() method, which checks the X-Requested-With header for the value 'XMLHttpRequest', which is sent by JavaScript libraries, such as jQuery. PHPBB3-9716
* | | Merge branch 'develop-olympus' into developNils Adermann2011-07-061-1/+1
|\ \ \ | |/ / | | | | | | | | | | | | * develop-olympus: [ticket/9859] Changing all phpBB footers to match the new credit line [ticket/9859] New footer copyright line with registered symbol
| * | [ticket/9859] Changing all phpBB footers to match the new credit lineYuriy Rusko2011-07-061-1/+1
| | | | | | | | | | | | PHPBB3-9859
* | | Merge branch 'develop-olympus' into developAndreas Fischer2011-06-261-16/+15
|\ \ \ | |/ / | | | | | | | | | * develop-olympus: [ticket/10188] Prevent semi-compressed output
| * | [ticket/10188] Prevent semi-compressed outputNils Adermann2011-06-261-16/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a non-fatal error occurs at the beginning of the script before any custom error handler is set one of two situations can be encountered: 1) if the ini option output buffer is disabled: - headers are sent to the http client - the error message is output 2) if the ini option output_buffer is enabled or the script is run within an ob_start()/ob_end() wrapper: - the error message is written to the output buffer Once the script reaches page_header() phpbb starts gzip compression if enabled. This is done through ob_start with a ob_gzhandler as a callback. The compression is skipped if headers have already been sent. In situation 1) the error message sent in plain text comes with headers and this gzip compression is skipped. The client receives a plaintext version of the page. However in situation 2) headers have not been sent yet and the rest of the page will be compressed. The result is a plaintext error message followed by compressed output. The client does not understand this output resulting in either an error message or simply a blank page in the browser. In addition to the above situation this problem occurs with errors that are triggered after the custom error handler is loaded. The problem has been noticed before, and a workaround was found. The error handler would call ob_flush() for particular configuration settings before outputting the error message. This resulted in headers being sent when output buffering was enabled thus disabling gzip compression for the rest of the page. The constraints under which ob_flush() was called were lessened over time whenever a new case was found that would trigger this problem. Eventually ob_flush() would be called even when code causing an E_NOTICE was simply run within an ob_start/ob_end. This makes it impossible to use output buffering to retrieve the content of an error message without prohibiting the page from setting headers afterwards. This commit removes all flushing in msg_handler completely and instead fixes the problem for both errors before and after the error handler is registered. GZIP compression is only enabled if there is at most one level of output buffering (e.g. the output_buffer php.ini option is enabled) and if there has not yet been any output in this buffer. This should avoid any partial output compression. PHPBB3-10188
* | | Merge branch 'develop-olympus' into developNils Adermann2011-06-201-1/+2
|\ \ \ | |/ / | | | | | | | | | * develop-olympus: [ticket/10234] Report E_WARNING errors as "PHP Warning" instead of "PHP Notice"
| * | [ticket/10234] Report E_WARNING errors as "PHP Warning" instead of "PHP Notice"Andreas Fischer2011-06-201-1/+2
| | | | | | | | | | | | PHPBB3-10234
* | | Merge branch 'develop-olympus' into developAndreas Fischer2011-06-091-0/+8
|\ \ \ | |/ / | | | | | | | | | | | | * develop-olympus: [ticket/7057] Use GET for quicksearch and add session id to hidden fields [ticket/7057] Remove trailing whitespace in functions.php
| * | Merge remote-tracking branch 'naderman/ticket/7057' into develop-olympusAndreas Fischer2011-06-091-4/+12
| |\ \ | | | | | | | | | | | | | | | | | | | | * naderman/ticket/7057: [ticket/7057] Use GET for quicksearch and add session id to hidden fields [ticket/7057] Remove trailing whitespace in functions.php
| | * | [ticket/7057] Use GET for quicksearch and add session id to hidden fieldsNils Adermann2011-06-021-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | Without sid a GET form logs a user out if they have cookies disabled. PHPBB3-7057
| | * | [ticket/7057] Remove trailing whitespace in functions.phpNils Adermann2011-06-021-4/+4
| | | | | | | | | | | | | | | | PHPBB3-7057
* | | | Merge branch 'develop-olympus' into developNils Adermann2011-06-051-0/+16
|\ \ \ \ | |/ / / | | | | | | | | | | | | | | | | | | | | * develop-olympus: [ticket/10042] GD CAPTCHA: Call phpbb_mt_rand() where required. [ticket/10042] GD CAPTCHA: Round offset to the next pixel. [ticket/10042] Add mt_rand() wrapper which allows swapping $min and $max.
| * | | Merge branch 'ticket/bantu/10042' into develop-olympusNils Adermann2011-06-051-0/+16
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/bantu/10042: [ticket/10042] GD CAPTCHA: Call phpbb_mt_rand() where required. [ticket/10042] GD CAPTCHA: Round offset to the next pixel. [ticket/10042] Add mt_rand() wrapper which allows swapping $min and $max.
| | * | | [ticket/10042] Add mt_rand() wrapper which allows swapping $min and $max.Andreas Fischer2011-03-051-0/+16
| | | | | | | | | | | | | | | | | | | | PHPBB3-10042
* | | | | Merge branch 'develop-olympus' into developAndreas Fischer2011-06-031-2/+2
|\ \ \ \ \ | |/ / / / | | | | | | | | | | | | | | | * develop-olympus: [ticket/9950] Use actual language instead of user's language in overall header
| * | | | [ticket/9950] Use actual language instead of user's language in overall headerNils Adermann2011-06-021-2/+2
| | | | | | | | | | | | | | | | | | | | PHPBB3-9950
* | | | | Merge branch 'develop-olympus' into developAndreas Fischer2011-05-231-1/+1
|\ \ \ \ \ | |/ / / / | | | | | | | | | | | | | | | * develop-olympus: [ticket/10191] Use ob_get_level in exit_handler for output buffering check.
| * | | | Merge remote-tracking branch 'p/ticket/10191' into develop-olympusAndreas Fischer2011-05-231-1/+1
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | * p/ticket/10191: [ticket/10191] Use ob_get_level in exit_handler for output buffering check.
| | * | | | [ticket/10191] Use ob_get_level in exit_handler for output buffering check.Oleg Pudeyev2011-05-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Calling flush() when output buffering is enabled causes output to be duplicated. Besides phpBB enabling output buffering for gzip compression, output buffering may be enabled externally to phpBB via output_handler or output_buffering directives in php.ini. Use ob_get_level to determine whether output buffering is active and call ob_flush in that case. PHPBB3-10191
* | | | | | Merge branch 'develop-olympus' into developAndreas Fischer2011-05-231-1/+1
|\ \ \ \ \ \ | |/ / / / / | | | | | | | | | | | | | | | | | | * develop-olympus: [ticket/10188] Use ob_get_level in msg_handler for output buffering check.
| * | | | | [ticket/10188] Use ob_get_level in msg_handler for output buffering check.Oleg Pudeyev2011-05-221-1/+1
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Output buffering may be enabled via various approaches, among them: * output_buffering in php.ini; * output_handler in php.ini enables output_buffering; * ob_start call. ob_get_level allows us to query php runtime for the actual output buffering status. PHPBB3-10188
| * | | | Merge remote-tracking branch 'bantu/ticket/10146' into develop-olympusOleg Pudeyev2011-05-131-1/+2
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | * bantu/ticket/10146: [ticket/10146] Firebird: 1 <= precision <= 18 ==> Cast to DECIMAL(18, 0).
| | * | | | [ticket/10146] Firebird: 1 <= precision <= 18 ==> Cast to DECIMAL(18, 0).Andreas Fischer2011-04-221-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10146
* | | | | | Merge branch 'develop-olympus' into developAndreas Fischer2011-04-261-0/+3
|\ \ \ \ \ \ | |/ / / / / | | | | | / | |_|_|_|/ |/| | | | * develop-olympus: [ticket/7941] Added @return to generate_board_url docstring.
| * | | | [ticket/7941] Added @return to generate_board_url docstring.Oleg Pudeyev2011-04-171-0/+3
| |/ / / | | | | | | | | | | | | PHPBB3-7941
* | | | Merge remote-tracking branch 'p/ticket/10136' into developIgor Wiedler2011-04-111-2/+2
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | * p/ticket/10136: [ticket/10136] Added missing $request globalizations in functions.php.
| * | | | [ticket/10136] Added missing $request globalizations in functions.php.Oleg Pudeyev2011-04-101-2/+2
| | | | | | | | | | | | | | | | | | | | PHPBB3-10136
* | | | | [ticket/9684] Fix Forum/Topic-Tracking for global announcementsJoas Schilling2011-04-071-62/+4
|/ / / / | | | | | | | | | | | | | | | | | | | | Should be ready for intensive testing now. PHPBB3-9684
* | | | Merge branch 'develop-olympus' into developOleg Pudeyev2011-03-221-1/+1
|\ \ \ \ | |/ / / | | | | | | | | | | | | | | | | * develop-olympus: [ticket/10101] Add test case for native phpass hashes [ticket/10101] Add support for native phpass hashes
| * | | Merge branch 'ticket/igorw/10101' into develop-olympusOleg Pudeyev2011-03-221-1/+1
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/igorw/10101: [ticket/10101] Add test case for native phpass hashes [ticket/10101] Add support for native phpass hashes
| | * | | [ticket/10101] Add support for native phpass hashesIgor Wiedler2011-03-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | phpass (the hashing library we use) adds a hash identifier to every hash. By default this identifier is '$P$'. For some reason we have changed it to '$H$'. This patch allows both of them to be used for authentication, so that a third party system could create users with '$P$' hashes. PHPBB3-10101
* | | | | Merge branch 'develop-olympus' into developIgor Wiedler2011-03-181-1/+1
|\ \ \ \ \ | |/ / / / | | | | | | | | | | | | | | | * develop-olympus: [ticket/10100] Update rand_seed_last_update before rand_seed in unique_id().
| * | | | [ticket/10100] Update rand_seed_last_update before rand_seed in unique_id().Andreas Fischer2011-03-171-1/+1
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update $config['rand_seed_last_update'] before updating $config['rand_seed'] in unique_id() to mitigate a race condition and unnecessary updates on heavily busy boards. PHPBB3-10100
* | | | Merge branch 'develop-olympus' into developAndreas Fischer2011-03-141-1/+1
|\ \ \ \ | |/ / / | | | | | | | | | | | | | | | | | | | | * develop-olympus: [ticket/10096] Fixed whitespace in functions.php. [ticket/10078] Avoid \n in strings given to echo for portability. [ticket/10092] Ignore overlength comment lines in commit-msg hook.
| * | | [ticket/10096] Fixed whitespace in functions.php.Oleg Pudeyev2011-03-131-1/+1
| | | | | | | | | | | | | | | | PHPBB3-10096
* | | | Merge branch 'develop-olympus' into developIgor Wiedler2011-03-121-1/+1
|\ \ \ \ | |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * develop-olympus: [ticket/10046] Do not link bots to cron.php. [ticket/10046] No longer change $phpbb_root_path to an absolute path for cron. [ticket/10046] Call flush() in cron.php [ticket/10046] Remove calls to register_shutdown_function() in cron.php Conflicts: phpBB/cron.php phpBB/includes/functions.php
| * | | [ticket/10046] Do not link bots to cron.php.Oleg Pudeyev2011-03-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Bots, generally speaking, will not request cron.php immediately, thus telling them to request it is pointless. PHPBB3-10046
| * | | Merge branch 'ticket/p/10016' into develop-olympusAndreas Fischer2011-03-111-1/+5
| |\ \ \ | | |/ / | |/| | | | | | | | | | | | | | | | | | * ticket/p/10016: [ticket/10016] Add comment for text casting (for PostgreSQL 7.x) [ticket/10016] Leave Firebird unchanged. [ticket/10016] Fixed varchar to decimal cast on postgresql 7.x.
| | * | [ticket/10016] Add comment for text casting (for PostgreSQL 7.x)Andreas Fischer2011-03-051-0/+1
| | | | | | | | | | | | | | | | PHPBB3-10016
| | * | [ticket/10016] Leave Firebird unchanged.Andreas Fischer2011-03-051-0/+3
| | | | | | | | | | | | | | | | PHPBB3-10016
| | * | [ticket/10016] Fixed varchar to decimal cast on postgresql 7.x.Oleg Pudeyev2011-01-281-1/+1
| | |/ | | | | | | | | | PHPBB3-10016
* | | [ticket/10080] Allow resetting the request instance used by request_var.Nils Adermann2011-03-071-2/+16
| | | | | | | | | | | | PHPBB3-10080
* | | [feature/system-cron] Refactored cron task naming, loading and running.Oleg Pudeyev2011-02-121-3/+4
| | | | | | | | | | | | PHPBB3-9596
* | | [feature/system-cron] WIP on making cron tasks runnable via system cronOleg Pudeyev2011-02-121-32/+4
| | | | | | | | | | | | PHPBB3-9596
* | | Merge branch 'develop-olympus' into developIgor Wiedler2011-02-121-1/+7
|\ \ \ | |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | * develop-olympus: [ticket/10029] Use $_SERVER['SERVER_PROTOCOL'] for determining HTTP version. [ticket/9805] Setup security repository for developers. [ticket/9805] Move check lower down. [ticket/9805] Better support for already existing repositories. [ticket/9805] Add dry-run option. [ticket/9805] Use getopt(), add a few options, extend show_usage(). [ticket/9805] Script for easily cloning a whole github network.
| * | [ticket/10029] Use $_SERVER['SERVER_PROTOCOL'] for determining HTTP version.Oleg Pudeyev2011-02-091-1/+7
| |/ | | | | | | PHPBB3-10029
* | Merge branch 'develop-olympus' into developNils Adermann2011-01-231-2/+3
|\ \ | |/ | | | | | | * develop-olympus: [ticket/8779] Slow search for 'View unread posts'
| * [ticket/8779] Slow search for 'View unread posts'rxu2011-01-241-2/+3
| | | | | | | | | | | | Adjust SQL query to speedup search for unread posts (thanks naderman). PHPBB3-8779
* | Merge branch 'develop-olympus' into developNils Adermann2011-01-161-1/+1
|\ \ | |/ | | | | | | | | | | | | | | * develop-olympus: [ticket/9859] Remove the years from the copyright statements in docs files. [ticket/9859] Remove the year from the copyright meta tag in docs/*.html [ticket/9859] Remove the meta copyright tag as well. [ticket/9859] Remove the credit line comment from all html files. [ticket/9859] Remove years in credit line from some more files.
| * Merge branch 'ticket/bantu/9859' into develop-olympusNils Adermann2011-01-161-1/+1
| |\ | | | | | | | | | | | | | | | | | | | | | | | | * ticket/bantu/9859: [ticket/9859] Remove the years from the copyright statements in docs files. [ticket/9859] Remove the year from the copyright meta tag in docs/*.html [ticket/9859] Remove the meta copyright tag as well. [ticket/9859] Remove the credit line comment from all html files. [ticket/9859] Remove years in credit line from some more files.