| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| |/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Extend the request class with helpers for reading server vars (server())
and HTTP request headers (header()). Refactor the existing code base
to make use of these helpers, make $_SERVER a deactivated super global.
Also introduce an is_ajax() method, which checks the X-Requested-With
header for the value 'XMLHttpRequest', which is sent by JavaScript
libraries, such as jQuery.
PHPBB3-9716
|
| |\ \ \
| |/ /
| | |
| | |
| | |
| | | |
* develop-olympus:
[ticket/9859] Changing all phpBB footers to match the new credit line
[ticket/9859] New footer copyright line with registered symbol
|
| | | |
| | |
| | |
| | | |
PHPBB3-9859
|
| |\ \ \
| |/ /
| | |
| | |
| | | |
* develop-olympus:
[ticket/10188] Prevent semi-compressed output
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When a non-fatal error occurs at the beginning of the script before any custom
error handler is set one of two situations can be encountered:
1) if the ini option output buffer is disabled:
- headers are sent to the http client
- the error message is output
2) if the ini option output_buffer is enabled or the script
is run within an ob_start()/ob_end() wrapper:
- the error message is written to the output buffer
Once the script reaches page_header() phpbb starts gzip compression if enabled.
This is done through ob_start with a ob_gzhandler as a callback. The
compression is skipped if headers have already been sent. In situation 1) the
error message sent in plain text comes with headers and this gzip compression
is skipped. The client receives a plaintext version of the page. However in
situation 2) headers have not been sent yet and the rest of the page will be
compressed. The result is a plaintext error message followed by compressed
output. The client does not understand this output resulting in either an
error message or simply a blank page in the browser.
In addition to the above situation this problem occurs with errors that are
triggered after the custom error handler is loaded. The problem has been
noticed before, and a workaround was found. The error handler would call
ob_flush() for particular configuration settings before outputting the error
message. This resulted in headers being sent when output buffering was enabled
thus disabling gzip compression for the rest of the page. The constraints under
which ob_flush() was called were lessened over time whenever a new case was
found that would trigger this problem. Eventually ob_flush() would be called
even when code causing an E_NOTICE was simply run within an ob_start/ob_end.
This makes it impossible to use output buffering to retrieve the content of an
error message without prohibiting the page from setting headers afterwards.
This commit removes all flushing in msg_handler completely and instead fixes
the problem for both errors before and after the error handler is registered.
GZIP compression is only enabled if there is at most one level of output
buffering (e.g. the output_buffer php.ini option is enabled) and if there has
not yet been any output in this buffer. This should avoid any partial output
compression.
PHPBB3-10188
|
| |\ \ \
| |/ /
| | |
| | |
| | | |
* develop-olympus:
[ticket/10234] Report E_WARNING errors as "PHP Warning" instead of "PHP Notice"
|
| | | |
| | |
| | |
| | | |
PHPBB3-10234
|
| |\ \ \
| |/ /
| | |
| | |
| | |
| | | |
* develop-olympus:
[ticket/7057] Use GET for quicksearch and add session id to hidden fields
[ticket/7057] Remove trailing whitespace in functions.php
|
| | |\ \
| | | |
| | | |
| | | |
| | | |
| | | | |
* naderman/ticket/7057:
[ticket/7057] Use GET for quicksearch and add session id to hidden fields
[ticket/7057] Remove trailing whitespace in functions.php
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Without sid a GET form logs a user out if they have cookies disabled.
PHPBB3-7057
|
| | | | |
| | | |
| | | |
| | | | |
PHPBB3-7057
|
| |\ \ \ \
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | | |
* develop-olympus:
[ticket/10042] GD CAPTCHA: Call phpbb_mt_rand() where required.
[ticket/10042] GD CAPTCHA: Round offset to the next pixel.
[ticket/10042] Add mt_rand() wrapper which allows swapping $min and $max.
|
| | |\ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* ticket/bantu/10042:
[ticket/10042] GD CAPTCHA: Call phpbb_mt_rand() where required.
[ticket/10042] GD CAPTCHA: Round offset to the next pixel.
[ticket/10042] Add mt_rand() wrapper which allows swapping $min and $max.
|
| | | | | |
| | | | |
| | | | |
| | | | | |
PHPBB3-10042
|
| |\ \ \ \ \
| |/ / / /
| | | | |
| | | | |
| | | | | |
* develop-olympus:
[ticket/9950] Use actual language instead of user's language in overall header
|
| | | | | |
| | | | |
| | | | |
| | | | | |
PHPBB3-9950
|
| |\ \ \ \ \
| |/ / / /
| | | | |
| | | | |
| | | | | |
* develop-olympus:
[ticket/10191] Use ob_get_level in exit_handler for output buffering check.
|
| | |\ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* p/ticket/10191:
[ticket/10191] Use ob_get_level in exit_handler for output buffering check.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Calling flush() when output buffering is enabled causes output to be
duplicated. Besides phpBB enabling output buffering for gzip compression,
output buffering may be enabled externally to phpBB via output_handler
or output_buffering directives in php.ini.
Use ob_get_level to determine whether output buffering is active and
call ob_flush in that case.
PHPBB3-10191
|
| |\ \ \ \ \ \
| |/ / / / /
| | | | | |
| | | | | |
| | | | | | |
* develop-olympus:
[ticket/10188] Use ob_get_level in msg_handler for output buffering check.
|
| | |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Output buffering may be enabled via various approaches, among them:
* output_buffering in php.ini;
* output_handler in php.ini enables output_buffering;
* ob_start call.
ob_get_level allows us to query php runtime for the actual output buffering
status.
PHPBB3-10188
|
| | |\ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* bantu/ticket/10146:
[ticket/10146] Firebird: 1 <= precision <= 18 ==> Cast to DECIMAL(18, 0).
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
PHPBB3-10146
|
| |\ \ \ \ \ \
| |/ / / / /
| | | | | /
| |_|_|_|/
|/| | | | |
* develop-olympus:
[ticket/7941] Added @return to generate_board_url docstring.
|
| | |/ / /
| | | |
| | | |
| | | | |
PHPBB3-7941
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
* p/ticket/10136:
[ticket/10136] Added missing $request globalizations in functions.php.
|
| | | | | |
| | | | |
| | | | |
| | | | | |
PHPBB3-10136
|
| |/ / / /
| | | |
| | | |
| | | |
| | | |
| | | | |
Should be ready for intensive testing now.
PHPBB3-9684
|
| |\ \ \ \
| |/ / /
| | | |
| | | |
| | | |
| | | | |
* develop-olympus:
[ticket/10101] Add test case for native phpass hashes
[ticket/10101] Add support for native phpass hashes
|
| | |\ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* ticket/igorw/10101:
[ticket/10101] Add test case for native phpass hashes
[ticket/10101] Add support for native phpass hashes
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
phpass (the hashing library we use) adds a hash identifier to every
hash. By default this identifier is '$P$'. For some reason we have
changed it to '$H$'.
This patch allows both of them to be used for authentication, so that a
third party system could create users with '$P$' hashes.
PHPBB3-10101
|
| |\ \ \ \ \
| |/ / / /
| | | | |
| | | | |
| | | | | |
* develop-olympus:
[ticket/10100] Update rand_seed_last_update before rand_seed in unique_id().
|
| | |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Update $config['rand_seed_last_update'] before updating $config['rand_seed'] in
unique_id() to mitigate a race condition and unnecessary updates on heavily
busy boards.
PHPBB3-10100
|
| |\ \ \ \
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | | |
* develop-olympus:
[ticket/10096] Fixed whitespace in functions.php.
[ticket/10078] Avoid \n in strings given to echo for portability.
[ticket/10092] Ignore overlength comment lines in commit-msg hook.
|
| | | | |
| | | |
| | | |
| | | | |
PHPBB3-10096
|
| |\ \ \ \
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* develop-olympus:
[ticket/10046] Do not link bots to cron.php.
[ticket/10046] No longer change $phpbb_root_path to an absolute path for cron.
[ticket/10046] Call flush() in cron.php
[ticket/10046] Remove calls to register_shutdown_function() in cron.php
Conflicts:
phpBB/cron.php
phpBB/includes/functions.php
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Bots, generally speaking, will not request cron.php immediately,
thus telling them to request it is pointless.
PHPBB3-10046
|
| | |\ \ \
| | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | | |
* ticket/p/10016:
[ticket/10016] Add comment for text casting (for PostgreSQL 7.x)
[ticket/10016] Leave Firebird unchanged.
[ticket/10016] Fixed varchar to decimal cast on postgresql 7.x.
|
| | | | |
| | | |
| | | |
| | | | |
PHPBB3-10016
|
| | | | |
| | | |
| | | |
| | | | |
PHPBB3-10016
|
| | | |/
| | |
| | |
| | | |
PHPBB3-10016
|
| | | |
| | |
| | |
| | | |
PHPBB3-10080
|
| | | |
| | |
| | |
| | | |
PHPBB3-9596
|
| | | |
| | |
| | |
| | | |
PHPBB3-9596
|
| |\ \ \
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* develop-olympus:
[ticket/10029] Use $_SERVER['SERVER_PROTOCOL'] for determining HTTP version.
[ticket/9805] Setup security repository for developers.
[ticket/9805] Move check lower down.
[ticket/9805] Better support for already existing repositories.
[ticket/9805] Add dry-run option.
[ticket/9805] Use getopt(), add a few options, extend show_usage().
[ticket/9805] Script for easily cloning a whole github network.
|
| | |/
| |
| |
| | |
PHPBB3-10029
|
| |\ \
| |/
| |
| |
| | |
* develop-olympus:
[ticket/8779] Slow search for 'View unread posts'
|
| | |
| |
| |
| |
| |
| | |
Adjust SQL query to speedup search for unread posts (thanks naderman).
PHPBB3-8779
|
| |\ \
| |/
| |
| |
| |
| |
| |
| |
| | |
* develop-olympus:
[ticket/9859] Remove the years from the copyright statements in docs files.
[ticket/9859] Remove the year from the copyright meta tag in docs/*.html
[ticket/9859] Remove the meta copyright tag as well.
[ticket/9859] Remove the credit line comment from all html files.
[ticket/9859] Remove years in credit line from some more files.
|
| | |\
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* ticket/bantu/9859:
[ticket/9859] Remove the years from the copyright statements in docs files.
[ticket/9859] Remove the year from the copyright meta tag in docs/*.html
[ticket/9859] Remove the meta copyright tag as well.
[ticket/9859] Remove the credit line comment from all html files.
[ticket/9859] Remove years in credit line from some more files.
|