aboutsummaryrefslogtreecommitdiffstats
path: root/phpBB/includes/db
Commit message (Collapse)AuthorAgeFilesLines
...
| * | [ticket/10057] Skip ibase_service_attach if firebird connection failed.Oleg Pudeyev2011-03-061-1/+3
| | | | | | | | | | | | | | | | | | | | | ibase_errmsg works for the most recent call. If the connection fails, any error message is clobbered by ibase_service_attach call. PHPBB3-10057
| * | [ticket/10057] Check for interbase function existence.Oleg Pudeyev2011-03-061-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | Calling nonexistent functions with @ destroys the script with no feedback as to the cause of the error. Check whether interbase functions exist before calling them. PHPBB3-10057
| * | [ticket/10057] Split statements in firebird dbal for readability.Oleg Pudeyev2011-03-061-2/+16
| | | | | | | | | | | | PHPBB3-10057
| * | [ticket/10057] Include error collector class file in postgres dbal.Oleg Pudeyev2011-03-061-0/+5
| | | | | | | | | | | | | | | | | | This change is in its own commit because it will be reverted for 3.1. PHPBB3-10057
| * | [ticket/10057] Use a class for error collection.Oleg Pudeyev2011-03-061-4/+6
| | | | | | | | | | | | | | | | | | | | | Replaced error collection functions with a class for a cleaner implementation. PHPBB3-10057
| * | [ticket/10057] More informative error messages in postgres dbal.Oleg Pudeyev2011-03-061-2/+2
| | | | | | | | | | | | | | | | | | | | | When pg_connect/pg_pconnect do not exist, mention that they come with pgsql extension. PHPBB3-10057
| * | [ticket/10057] Report postgres db connection errors.Oleg Pudeyev2011-03-061-1/+14
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Addresses two issues: 1. When pgsql extension is missing, @pg_connect would silently abort execution. Check for pg_connect existence before calling it, same with pg_pconnect. 2. When connection fails, the error reported by php is discarded. User is shown the failure message without the reason for failure, making debugging difficult. Collect the error (if any) via a temporarily installed error handler, and display it if connection failed. PHPBB3-10057
* | Merge branch 'develop-olympus' into developNils Adermann2011-01-161-1/+1
|\ \ | |/ | | | | | | | | | | | | | | * develop-olympus: [ticket/9859] Remove the years from the copyright statements in docs files. [ticket/9859] Remove the year from the copyright meta tag in docs/*.html [ticket/9859] Remove the meta copyright tag as well. [ticket/9859] Remove the credit line comment from all html files. [ticket/9859] Remove years in credit line from some more files.
| * [ticket/9859] Remove years in credit line from some more files.Andreas Fischer2011-01-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Standard HTML output now includes: Powered by <a href="http://www.phpbb.com/">phpBB</a> &copy; phpBB Group Print output now includes: Powered by phpBB &copy; phpBB Group<br />http://www.phpbb.com/ This also fixes an inconsistency where "phpBB Group" was linked instead of "phpBB". PHPBB3-9859
* | [task/config-class] Implemented a config class to replace the global array.Nils Adermann2011-01-103-0/+54
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is a phpbb_config class which simply holds an array and does not persist any data. It implements ArrayAccess, Countable and IteratorAggregate to allow regular use of configuration as if it was still an array. The phpbb_config_db class depends on an instance of the dbal and a cache driver. It obtains the configuration data from cache and database as necessary and persists data to the database. The functions set_config and set_config_count remain for backward compatability but they only call methods on the new config class now instead of directly manipulating the database and cache. PHPBB3-9988
* | [ticket/9574] Remove conditional PHP<5.2 codeIgor Wiedler2010-12-281-8/+1
| | | | | | | | | | | | | | There is a large amount of conditional code for PHP < 5.2 that can be removed with phpBB 3.1. PHPBB3-9574
* | [ticket/9556] Drop php closing tags, add trailing newlineIgor Wiedler2010-11-1111-22/+0
| | | | | | | | | | | | | | | | | | | | | | | | Closing tags converted using Oleg's script. remove-php-end-tags.py -a . Trailing newlines added using the following where $ext is file extension. find . -type f -name "*.$ext" -print | xargs printf "e %s\nw\n" | ed -s; Extensions: php, css, html, js, xml. PHPBB3-9556
* | Merge branch 'develop-olympus' into developAndreas Fischer2010-11-031-6/+20
|\ \ | |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | * develop-olympus: [task/mssql-db-tests] Remove MS SQL helper values from SELECT LIMIT results. [task/mssql-db-tests] Split up database tests into SELECT and write operations [task/mssql-db-tests] PHPUnit output got stuck after unterminated ob_start. [task/mssql-db-tests] sql_query_limit must return all results when total = 0 [task/mssql-db-tests] Add support for odbc & sqlsrv PDO test connections [task/mssql-db-tests] Refactored getConnection into multiple smaller parts. [task/mssql-db-tests] Allow test configuration with environment variables. [task/mssql-db-tests] No longer display an error when skipping db tests. [task/mssql-db-tests] Use a simple getter for test case helpers. Conflicts: tests/template/template.php
| * Merge branch 'task/naderman/mssql-db-tests' into develop-olympusAndreas Fischer2010-11-031-6/+20
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * task/naderman/mssql-db-tests: [task/mssql-db-tests] Remove MS SQL helper values from SELECT LIMIT results. [task/mssql-db-tests] Split up database tests into SELECT and write operations [task/mssql-db-tests] PHPUnit output got stuck after unterminated ob_start. [task/mssql-db-tests] sql_query_limit must return all results when total = 0 [task/mssql-db-tests] Add support for odbc & sqlsrv PDO test connections [task/mssql-db-tests] Refactored getConnection into multiple smaller parts. [task/mssql-db-tests] Allow test configuration with environment variables. [task/mssql-db-tests] No longer display an error when skipping db tests. [task/mssql-db-tests] Use a simple getter for test case helpers.
| | * [task/mssql-db-tests] Remove MS SQL helper values from SELECT LIMIT results.Nils Adermann2010-10-251-1/+6
| | | | | | | | | | | | PHPBB3-9868
| | * [task/mssql-db-tests] sql_query_limit must return all results when total = 0Nils Adermann2010-10-251-5/+14
| | | | | | | | | | | | PHPBB3-9868
* | | Merge branch 'develop-olympus' into developIgor Wiedler2010-10-251-5/+15
|\ \ \ | |/ / | | | | | | | | | | | | | | | | | | | | | * develop-olympus: [ticket/9478] Validate maximum number of allowed recipients per PM value. [ticket/9686] Fix mssqlnative database data export [ticket/9595] List min/max characters indexed by search for mysql_fulltext. [ticket/9101] Remove misleading 'below' from RECAPTCHA_EXPLAIN. [ticket/9853] Change recaptcha theme from default to 'clean'.
| * | [ticket/9686] Fix mssqlnative database data exportNils Adermann2010-10-251-5/+15
| |/ | | | | | | | | | | | | | | | | We require version 1.1 of the sqlsrv extension anyway so the regular sqlsrv_num_rows can be used instead of buffering the result. The result buffer (class result_mssqlnative) should never automatically free the resource it receives - we consistently close resources using sql_freeresult(). PHPBB3-9686
* | [feature/request-class] Check for existence of $requestIgor Wiedler2010-10-121-1/+1
| | | | | | | | PHPBB3-9716
* | [feature/request-class] Convert any direct access to $_* to use $requestIgor Wiedler2010-09-251-1/+2
|/ | | | PHPBB3-9716
* Merge branch 'ticket/evil3/8944' into develop-olympusChris Smith2010-09-051-1/+17
|\ | | | | | | | | | | * ticket/evil3/8944: [ticket/8944] Patch db_tools to support index length for MySQL4 [ticket/8944] Add index length to CREATE INDEX for MySQL4 in database_update
| * [ticket/8944] Patch db_tools to support index length for MySQL4Igor Wiedler2010-09-051-1/+17
| |
* | [ticket/9039] Make mssqlnative.php non-executableIgor Wiedler2010-09-031-0/+0
|/ | | | PHPBB3-9039
* Merge branch 'ticket/kellanved/9521' into develop-olympusAndreas Fischer2010-07-311-1/+7
|\ | | | | | | | | * ticket/kellanved/9521: [ticket/9521] Fix error reporting for the native SQL Server plugin.
| * [ticket/9521] Fix error reporting for the native SQL Server plugin.Henry Sudhof2010-07-311-1/+7
| | | | | | | | | | | | | | | | | | The native SQL Server plugin used to return an error string when calling sql_error. However, some error condition checks are done using is_array. This patch wraps the error into an array to follow the error logic used elsewhere. PHPBB3-9521
* | Merge branch 'ticket/jellydoughnut/9637' into develop-olympusAndreas Fischer2010-07-119-24/+51
|\ \ | | | | | | | | | | | | * ticket/jellydoughnut/9637: [ticket/9637] Do not cache SQL server version in all cases
| * | [ticket/9637] Do not cache SQL server version in all casesJosh Woody2010-07-119-24/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Because the existing cache is global, there is no way to differentiate between each of two databases which may be two different DBAL objects pointing to servers with wildly different versions of an RDBMS. phpBB only has this situation in the UCF, thus only one file changed outside the DBAL. I have added a second optional parameter, $use_cache to each of the implementations of dbal::sql_server_info() PHPBB3-9637
* | | Merge branch 'ticket/bantu/9643' into develop-olympusAndreas Fischer2010-06-201-1/+4
|\ \ \ | | | | | | | | | | | | | | | | * ticket/bantu/9643: [ticket/9643] Only split $port from $sqlserver, if it's not an IPv6 address.
| * | | [ticket/9643] Only split $port from $sqlserver, if it's not an IPv6 address.Andreas Fischer2010-06-081-1/+4
| |/ / | | | | | | | | | PHPBB3-9643
* | | [ticket/9132] Oracle CLOB support is broken, preventing storage of long stringsJosh Woody2010-06-131-0/+5
|/ / | | | | | | | | | | This reverts Oracle support to the state it was in prior to phpBB 3.0.6. That is, storage of long strings works again (e.g. posts > 4 KB), but the database backup/restore functionality is broken. We feel that the ability to store long strings is more important than the DB restore, since Oracle 10g itself provides tools for backing up databases. PHPBB3-9132
* | [ticket/9518] Correctly create new connection on PostgreSQL when new ↵Andreas Fischer2010-05-141-1/+8
|/ | | | | | | | connection is forced. pg_connect() takes an integer as the second parameter, but we were passing a boolean parameter. The function especially requires passing the PGSQL_CONNECT_FORCE_NEW constant if a new connection is to be forced. Passing 0 as the second parameter for 'do not force a new connection' doesn't work as expected, hence we're calling the function without a second parameter in this case. PHPBB3-9518
* Add sql_bit_or() dbal method. Add ability to enable quick reply in all ↵Andreas Fischer2010-02-153-0/+28
| | | | | | forums. -- Voila ;-) git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10491 89ea8834-ac86-4346-8a33-228a782c2dd0
* Forgot to properly update the file header of mssqlnative.php, revising ↵Nils Adermann2010-02-111-2/+4
| | | | | | r10489 [Bug #57055] git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10490 89ea8834-ac86-4346-8a33-228a782c2dd0
* Support for Microsoft's Native SQL Server Driver for PHP - Patch by Chris ↵Nils Adermann2010-02-112-2/+657
| | | | | | | | | | | | | Pucci at Microsoft [Bug #57055] If you are using SQL Server, please try to test this new dbal so we can safely include it in 3.0.8. If you want to try it on a current phpBB version you can apply the latest version of the patch to your board which you can find attached to the bug tracker ticket (look in the comments for the latest version, the one in the ticket itself is outdated): http://www.phpbb.com/bugs/phpbb3/ticket.php?ticket_id=57055 git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10489 89ea8834-ac86-4346-8a33-228a782c2dd0
* Database updater now separates ADD COLUMN from SET NOT NULL and SET DEFAULT, ↵Nils Adermann2010-01-261-1/+23
| | | | | | when using PostgreSQL <= 7.4 [Bug #54435] git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10446 89ea8834-ac86-4346-8a33-228a782c2dd0
* Fix Bug #55785 - Correct call to mysql_pconnect().Andreas Fischer2009-12-231-1/+1
| | | | | | | Note: As pointed out by gn#36, phpBB doesn't use persistent connections at all. git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10375 89ea8834-ac86-4346-8a33-228a782c2dd0
* Several fixes:Meik Sievertsen2009-10-301-1/+1
| | | | | | | | Fix Bug #53335 Fix wrong unique index fetch for oracle and sqlite Fix alter column definition for firebird (although the query will fail in these circumstances [primary key] because firebird (again) does not support simple things... although... mssql/oracle having the same "problems", but there you are able to do more advanced queries) git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10248 89ea8834-ac86-4346-8a33-228a782c2dd0
* Fix another bug in WHERE statement rewrite for oracle. The bug(s) actually ↵Meik Sievertsen2009-10-301-1/+1
| | | | | | consist of not detecting correct parameters and then resulting in partial WHERE statements, where non-detected strings are simply removed. grrrrrr git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10247 89ea8834-ac86-4346-8a33-228a782c2dd0
* saw this bug while debugging... we really really need another layer in 3.1.x ↵Meik Sievertsen2009-10-301-1/+1
| | | | | | (better sooner than later), but retaining backwards compatibility. git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10246 89ea8834-ac86-4346-8a33-228a782c2dd0
* fix table creation in db_tools. Meik Sievertsen2009-10-241-0/+6
| | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10231 89ea8834-ac86-4346-8a33-228a782c2dd0
* I think i need to check other DBMS more often. :/Meik Sievertsen2009-09-241-5/+29
| | | | | | | | - fix index check for sqlite, firebird and oracle - add check for unique index - fix changing default value for column in mssql (add constraint) git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10185 89ea8834-ac86-4346-8a33-228a782c2dd0
* And now i feel even more dirty because i had to adjust the oracle hack to ↵Meik Sievertsen2009-09-211-1/+50
| | | | | | allow for queries > 4k to let it recognise concatenated strings and strings having the character ")" in it. I also added fallback code in case our regex splits too much. :/ git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10175 89ea8834-ac86-4346-8a33-228a782c2dd0
* - replaced the drop down menu log filter thing with log searchingJim Wigginton2009-08-211-2/+2
| | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10041 89ea8834-ac86-4346-8a33-228a782c2dd0
* Lifted minimum requirement for Firebird DBMS from 2.0+ to 2.1+.Meik Sievertsen2009-08-131-2/+2
| | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9970 89ea8834-ac86-4346-8a33-228a782c2dd0
* ok, i am very sorry, but this needs to be fixed.Meik Sievertsen2009-08-123-0/+28
| | | | | | | | | Generally, our config table is not really suited for holding large datasets. Because feed settings for the forums to enable news feeds and excluded forums rely on the forums itself we have decided to introduce a forum_options table where custom options can be stored. Additionally, for this to work across all DBMS we support, we added a new method to the DBAL for the bitwise AND operator. Also moved the forum/topic feed template variable to the location where they belong to (forum and topic view) git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9965 89ea8834-ac86-4346-8a33-228a782c2dd0
* forgot this in r9909Meik Sievertsen2009-08-011-2/+1
| | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9911 89ea8834-ac86-4346-8a33-228a782c2dd0
* return errors if return_on_error is true for multi_insert (Patch by bantu)Meik Sievertsen2009-08-011-2/+7
| | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9909 89ea8834-ac86-4346-8a33-228a782c2dd0
* Fix database updater and db tools to support multiple column ↵Meik Sievertsen2009-07-081-17/+229
| | | | | | changes/additions/removals with SQLite git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9735 89ea8834-ac86-4346-8a33-228a782c2dd0
* - fix sql_column_exists for firebird (had same problem as oracle)Meik Sievertsen2009-06-131-2/+12
| | | | | | - fix sql_column_change for firebird (interbase6 only supports TYPE and SET DEFAULT, but not the same syntax ass ADD COLUMN) git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9586 89ea8834-ac86-4346-8a33-228a782c2dd0
* Fix sql_column_exists for oracle (oracle uses uppercase table names)Meik Sievertsen2009-06-131-1/+1
| | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9583 89ea8834-ac86-4346-8a33-228a782c2dd0