| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | |
| |
| |
| | |
PHPBB3-10146
|
| |\ \
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* develop-olympus:
[ticket/10003] Delete EOL at EOF for the benefit of 3.0 modifications.
[ticket/10003] Ported 1802b9ff9286a7fc24493e71b3432816cbdbfcd8 to db_tools.
[ticket/10003] Ported 5553cfc2ed81ba9eb571804c431def962720b39e to db_tools.
[ticket/10003] Ported 023760c8b2402418310a3717db8349cac0342e42 to db_tools.
[ticket/10003] Ported 54c22ae52a0e18232cac8fed342ea52f2e2a793d to db_tools.
[ticket/10003] Ported 96a30afcca3ebd832c9b3083bb5c9a9f2a2dc54b to db_tools.
[ticket/10003] Ported d7d96223e7bae7cd60b13c6e7896d95838c3633c to db_tools.
|
| | |
| |
| |
| | |
PHPBB3-10003
|
| | |
| |
| |
| |
| |
| |
| | |
Most of it was already in db_tools, these changes could have applied to
code that did not exist in db_tools at the time of the commit.
PHPBB3-10003
|
| | |
| |
| |
| |
| |
| | |
The diff in database_update was only partially relevant.
PHPBB3-10003
|
| | |
| |
| |
| |
| |
| |
| | |
This was painful. Git wanted to patch hunks in wrong places.
Hopefully I got it right.
PHPBB3-10003
|
| | |
| |
| |
| |
| |
| | |
This diff applied cleanly.
PHPBB3-10003
|
| | |
| |
| |
| |
| |
| | |
This change is somewhat questionable, maybe it should be reviewed.
PHPBB3-10003
|
| | |
| |
| |
| | |
PHPBB3-10003
|
| |\ \
| |/
| |
| |
| | |
* develop-olympus:
[ticket/10112] Replaced a couple occurrences of count() with sizeof()
|
| | |\
| | |
| | |
| | |
| | | |
* callumacrae/ticket/10112:
[ticket/10112] Replaced a couple occurrences of count() with sizeof()
|
| | | |
| | |
| | |
| | |
| | |
| | | |
As per the coding guidlines, sizeof() should be used instead of count().
PHPBB3-10112
|
| |\ \ \
| |/ /
| | |
| | |
| | | |
* develop-olympus:
[ticket/9946] Allow storage of data >4kB on Oracle again
|
| | |\ \
| | | |
| | | |
| | | |
| | | | |
* ticket/jellydoughnut/9946:
[ticket/9946] Allow storage of data >4kB on Oracle again
|
| | | |/
| | |
| | |
| | |
| | |
| | | |
This fixes the fix to PHPBB3-9132, which introduced a fatal error on Oracle.
PHPBB3-9946
|
| |\ \ \
| |/ /
| | |
| | |
| | | |
* develop-olympus:
[ticket/9685] Buffer posts for search indexing when using mssqlnative.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
To have a generic solution there is now a sql_buffer_nested_transaction()
which indicates that the given SQL driver requires buffering to run a
transaction while iterating over another result set.
PHPBB3-9685
|
| |\ \ \
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* develop-olympus:
[ticket/10057] Fixes for a bunch of small problems.
[ticket/10035] ACP template edit feature allows to read any files on webserver.
[ticket/10057] Handle the case of missing interbase extension better.
[ticket/10057] Fixed wrong usage of sql_error again, in firebird.
[ticket/10057] Fixed usage of sql_error again.
[ticket/10057] Condition file/line display on DEBUG_EXTRA or IN_INSTALL.
[ticket/10057] Fixed wrong usage of sql_error in postgres dbal.
[ticket/10057] Skip ibase_service_attach if firebird connection failed.
[ticket/10057] Check for interbase function existence.
[ticket/10057] Split statements in firebird dbal for readability.
[ticket/10057] Include error collector class file in postgres dbal.
[ticket/10057] Moved error collector class into its own file.
[ticket/10057] Use a class for error collection.
[ticket/10057] More informative error messages in postgres dbal.
[ticket/10057] No negative array indexing.
[ticket/10057] Report postgres db connection errors.
|
| | | |
| | |
| | |
| | | |
PHPBB3-10057
|
| | | |
| | |
| | |
| | | |
PHPBB3-10057
|
| | | |
| | |
| | |
| | |
| | |
| | | |
This necessitates adding connect_error property to firebird.
PHPBB3-10057
|
| | | |
| | |
| | |
| | | |
PHPBB3-10057
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
pg_last_error does not work if no connection was ever established.
Therefore we must keep track of connection errors in postgres
dbal ourselves.
PHPBB3-10057
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
ibase_errmsg works for the most recent call. If the connection
fails, any error message is clobbered by ibase_service_attach call.
PHPBB3-10057
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Calling nonexistent functions with @ destroys the script with
no feedback as to the cause of the error. Check whether
interbase functions exist before calling them.
PHPBB3-10057
|
| | | |
| | |
| | |
| | | |
PHPBB3-10057
|
| | | |
| | |
| | |
| | |
| | |
| | | |
This change is in its own commit because it will be reverted for 3.1.
PHPBB3-10057
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
Replaced error collection functions with a class for a cleaner
implementation.
PHPBB3-10057
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
When pg_connect/pg_pconnect do not exist, mention that they come
with pgsql extension.
PHPBB3-10057
|
| | |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Addresses two issues:
1. When pgsql extension is missing, @pg_connect would silently
abort execution. Check for pg_connect existence before calling it,
same with pg_pconnect.
2. When connection fails, the error reported by php is discarded.
User is shown the failure message without the reason for failure,
making debugging difficult. Collect the error (if any) via a
temporarily installed error handler, and display it if connection
failed.
PHPBB3-10057
|
| |\ \
| |/
| |
| |
| |
| |
| |
| |
| | |
* develop-olympus:
[ticket/9859] Remove the years from the copyright statements in docs files.
[ticket/9859] Remove the year from the copyright meta tag in docs/*.html
[ticket/9859] Remove the meta copyright tag as well.
[ticket/9859] Remove the credit line comment from all html files.
[ticket/9859] Remove years in credit line from some more files.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Standard HTML output now includes:
Powered by <a href="http://www.phpbb.com/">phpBB</a> © phpBB Group
Print output now includes:
Powered by phpBB © phpBB Group<br />http://www.phpbb.com/
This also fixes an inconsistency where "phpBB Group" was linked instead of
"phpBB".
PHPBB3-9859
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
There is a phpbb_config class which simply holds an array and does not persist
any data. It implements ArrayAccess, Countable and IteratorAggregate to allow
regular use of configuration as if it was still an array. The phpbb_config_db
class depends on an instance of the dbal and a cache driver. It obtains the
configuration data from cache and database as necessary and persists data to
the database.
The functions set_config and set_config_count remain for backward compatability
but they only call methods on the new config class now instead of directly
manipulating the database and cache.
PHPBB3-9988
|
| | |
| |
| |
| |
| |
| |
| | |
There is a large amount of conditional code for PHP < 5.2 that can be
removed with phpBB 3.1.
PHPBB3-9574
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Closing tags converted using Oleg's script.
remove-php-end-tags.py -a .
Trailing newlines added using the following where $ext is file extension.
find . -type f -name "*.$ext" -print | xargs printf "e %s\nw\n" | ed -s;
Extensions: php, css, html, js, xml.
PHPBB3-9556
|
| |\ \
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* develop-olympus:
[task/mssql-db-tests] Remove MS SQL helper values from SELECT LIMIT results.
[task/mssql-db-tests] Split up database tests into SELECT and write operations
[task/mssql-db-tests] PHPUnit output got stuck after unterminated ob_start.
[task/mssql-db-tests] sql_query_limit must return all results when total = 0
[task/mssql-db-tests] Add support for odbc & sqlsrv PDO test connections
[task/mssql-db-tests] Refactored getConnection into multiple smaller parts.
[task/mssql-db-tests] Allow test configuration with environment variables.
[task/mssql-db-tests] No longer display an error when skipping db tests.
[task/mssql-db-tests] Use a simple getter for test case helpers.
Conflicts:
tests/template/template.php
|
| | |\
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* task/naderman/mssql-db-tests:
[task/mssql-db-tests] Remove MS SQL helper values from SELECT LIMIT results.
[task/mssql-db-tests] Split up database tests into SELECT and write operations
[task/mssql-db-tests] PHPUnit output got stuck after unterminated ob_start.
[task/mssql-db-tests] sql_query_limit must return all results when total = 0
[task/mssql-db-tests] Add support for odbc & sqlsrv PDO test connections
[task/mssql-db-tests] Refactored getConnection into multiple smaller parts.
[task/mssql-db-tests] Allow test configuration with environment variables.
[task/mssql-db-tests] No longer display an error when skipping db tests.
[task/mssql-db-tests] Use a simple getter for test case helpers.
|
| | | |
| | |
| | |
| | | |
PHPBB3-9868
|
| | | |
| | |
| | |
| | | |
PHPBB3-9868
|
| |\ \ \
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* develop-olympus:
[ticket/9478] Validate maximum number of allowed recipients per PM value.
[ticket/9686] Fix mssqlnative database data export
[ticket/9595] List min/max characters indexed by search for mysql_fulltext.
[ticket/9101] Remove misleading 'below' from RECAPTCHA_EXPLAIN.
[ticket/9853] Change recaptcha theme from default to 'clean'.
|
| | |/
| |
| |
| |
| |
| |
| |
| |
| | |
We require version 1.1 of the sqlsrv extension anyway so the regular
sqlsrv_num_rows can be used instead of buffering the result. The result
buffer (class result_mssqlnative) should never automatically free the
resource it receives - we consistently close resources using sql_freeresult().
PHPBB3-9686
|
| | |
| |
| |
| | |
PHPBB3-9716
|
| |/
|
|
| |
PHPBB3-9716
|
| |\
| |
| |
| |
| |
| | |
* ticket/evil3/8944:
[ticket/8944] Patch db_tools to support index length for MySQL4
[ticket/8944] Add index length to CREATE INDEX for MySQL4 in database_update
|
| | | |
|
| |/
|
|
| |
PHPBB3-9039
|
| |\
| |
| |
| |
| | |
* ticket/kellanved/9521:
[ticket/9521] Fix error reporting for the native SQL Server plugin.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
The native SQL Server plugin used to return an error string when calling
sql_error. However, some error condition checks are done using is_array.
This patch wraps the error into an array to follow the error logic used
elsewhere.
PHPBB3-9521
|
| |\ \
| | |
| | |
| | |
| | | |
* ticket/jellydoughnut/9637:
[ticket/9637] Do not cache SQL server version in all cases
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Because the existing cache is global, there is no way to differentiate between
each of two databases which may be two different DBAL objects pointing to
servers with wildly different versions of an RDBMS. phpBB only has this
situation in the UCF, thus only one file changed outside the DBAL. I have
added a second optional parameter, $use_cache to each of the implementations
of dbal::sql_server_info()
PHPBB3-9637
|