aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | Merge remote-tracking branch 'p/ticket/11265' into develop-olympusAndreas Fischer2012-12-131-3/+11
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * p/ticket/11265: [ticket/11265] Add assertions for board installation success.
| * | | | | | | [ticket/11265] Add assertions for board installation success.Oleg Pudeyev2012-12-131-3/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-11265
* | | | | | | | Merge remote-tracking branch 'EXreaction/ticket/11262' into develop-olympusAndreas Fischer2012-12-131-1/+1
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | * EXreaction/ticket/11262: [ticket/11262] Add .lock in cache directory to .gitignore
| * | | | | | | [ticket/11262] Add .lock in cache directory to .gitignoreNathan Guse2012-12-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-11262
* | | | | | | | Merge PR #1119 branch 'p/ticket/10491' into develop-olympusOleg Pudeyev2012-12-131-25/+29
|\ \ \ \ \ \ \ \ | |_|_|_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * p/ticket/10491: [ticket/10491] Make recreate_database static. [ticket/10491] Install board once per test run. [ticket/10491] Move board installation into setup before class. [ticket/10491] Set up functional tests sensibly.
| * | | | | | | [ticket/10491] Make recreate_database static.Oleg Pudeyev2012-12-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10491
| * | | | | | | [ticket/10491] Install board once per test run.Oleg Pudeyev2012-12-101-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is how things used to be. Installing for each test class brings 3-4x performance penalty compared to installing once for the entire test run. However, with a single installation for all tests an individual test can see different data when it is invoked by itself vs when it is executed as part of the entire test suite. PHPBB3-10491
| * | | | | | | [ticket/10491] Move board installation into setup before class.Oleg Pudeyev2012-12-041-16/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Functional posting test already assumed that board is installed once per test case and not once per test. PHPBB3-10491
| * | | | | | | [ticket/10491] Set up functional tests sensibly.Oleg Pudeyev2012-12-041-16/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB_FUNCTIONAL_URL goes into setup before class. Drop PHPBB_FUNCTIONAL_URL check in board installation and silent return if it is not set. Take board installation out of constructor. Install board in setup method. PHPBB3-10491
* | | | | | | | Merge PR #1125 branch 'p/ticket/10972' into develop-olympusOleg Pudeyev2012-12-104-3/+138
|\ \ \ \ \ \ \ \ | |_|/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * p/ticket/10972: [ticket/10972] Drop user deletion. [ticket/10972] Tweak user addition. [ticket/10972] Add destroy method to mock cache. [ticket/10972] Add mock null cache. [ticket/10972] Backport get_db from develop. [ticket/10972] Added explicit checks for creating duplicate users. [ticket/10972] Moved tests into appropriate places and added comments [ticket/10972] Added methods for creating and deleting basic users
| * | | | | | | [ticket/10972] Drop user deletion.Oleg Pudeyev2012-12-062-16/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Users should not be deleted in tests that test user creation. Tests should use unique user names to avoid collisions. User deletion should use user_remove anyway. PHPBB3-10972
| * | | | | | | [ticket/10972] Tweak user addition.Oleg Pudeyev2012-12-062-29/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Always add users, do not keep track of which users have been added. The tests should know whether users they want exist or not. Use more unique user names in tests for robustness. Added some more assertions here and there. PHPBB3-10972
| * | | | | | | [ticket/10972] Add destroy method to mock cache.Oleg Pudeyev2012-12-061-1/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I actually needed the version that destroys tables, therefore I ended up writing a mock null cache. This code is currently unused but will probably be handy at some point. PHPBB3-10972
| * | | | | | | [ticket/10972] Add mock null cache.Oleg Pudeyev2012-12-061-0/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The mock cache has instrumentation methods and therefore is non-trivial to implement. For those times when we don't care that the cache caches, null cache is a simpler implementation. PHPBB3-10972
| * | | | | | | [ticket/10972] Backport get_db from develop.Oleg Pudeyev2012-12-061-0/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10972
| * | | | | | | [ticket/10972] Added explicit checks for creating duplicate users.Fyorl2012-12-061-2/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10972
| * | | | | | | [ticket/10972] Moved tests into appropriate places and added commentsFyorl2012-12-063-45/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10972
| * | | | | | | [ticket/10972] Added methods for creating and deleting basic usersFyorl2012-12-062-2/+88
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Modified the login method to allow logging in of an arbitrary user. Also added tests for the new functionality. PHPBB3-10972
| | | | * | | | [ticket/8610] Use phpbb_update_rows_avoiding_duplicatesNathan Guse2012-12-132-22/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-8610
| | | | * | | | [ticket/8610] Revert some funky merging I did from rebaseNathan Guse2012-12-133-12/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-8610
| | | | * | | | [ticket/8610] Add some commentsNathan Guse2012-12-132-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-8610
| | | | * | | | [ticket/8610] Update Bookmarks and Subscriptions when splitting topicsNathaniel Guse2012-12-132-4/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update bookmarks and subscriptions to add bookmarks/subscriptions to the new topic when using the split_topic function PHPBB3-8610
| | | | * | | | [ticket/8610] Update Bookmarks when merging posts into another topicNathaniel Guse2012-12-131-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update bookmarks to the new topic when merging posts into another topic using the merge_posts function. PHPBB3-8610
| | | | * | | | [ticket/8610] Update Bookmarks when forking topicsNathaniel Guse2012-12-131-1/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update bookmarks to the new topic when forking topics using the mcp_fork_topic function. PHPBB3-8610
| | | | * | | | [ticket/8610] Update Bookmarks when merging topicsNathaniel Guse2012-12-131-1/+9
| |_|_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update bookmarks to the new topic when merging multiple topics using the merge_topics function. PHPBB3-8610
* | | | | | | Merge remote-tracking branch 'p/ticket/10205' into develop-olympusAndreas Fischer2012-12-089-76/+305
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * p/ticket/10205: [ticket/10205] Reduce nesting in mysql drivers. [ticket/10205] Rewrite _sql_error implementations to have a single return. [ticket/10205] Cosmetic changes. [ticket/10205] Add some columns to the empty fixture file for mssqlnative. [ticket/10205] Delete stray return. [ticket/10205] Test failed connection attempts. [ticket/10205] Check for function existence in mssql connect method. [ticket/10205] Convert mssqlnative driver to the same logic. [ticket/10205] Fix a parse error in oracle driver. [ticket/10205] Fix remaining db drivers. [ticket/10205] Avoid calling mysqli functions when mysqli is missing. [ticket/10205] Account for potentially missing extensions in dbal.
| * | | | | | | [ticket/10205] Reduce nesting in mysql drivers.Oleg Pudeyev2012-12-042-28/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10205
| * | | | | | | [ticket/10205] Rewrite _sql_error implementations to have a single return.Oleg Pudeyev2012-12-045-20/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10205
| * | | | | | | [ticket/10205] Cosmetic changes.Oleg Pudeyev2012-12-046-9/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10205
| * | | | | | | [ticket/10205] Add some columns to the empty fixture file for mssqlnative.Oleg Pudeyev2012-12-041-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Supposedly it choked on the version without any columns thusly: phpbb_dbal_connect_test::test_failing_connect PDOException: SQLSTATE[HY090]: [Microsoft][ODBC Driver Manager] Invalid string or buffer length PHPBB3-10205
| * | | | | | | [ticket/10205] Delete stray return.Oleg Pudeyev2012-12-041-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10205
| * | | | | | | [ticket/10205] Test failed connection attempts.Oleg Pudeyev2012-12-042-0/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10205
| * | | | | | | [ticket/10205] Check for function existence in mssql connect method.Oleg Pudeyev2012-12-041-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10205
| * | | | | | | [ticket/10205] Convert mssqlnative driver to the same logic.Oleg Pudeyev2012-12-041-20/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10205
| * | | | | | | [ticket/10205] Fix a parse error in oracle driver.Oleg Pudeyev2012-12-041-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10205
| * | | | | | | [ticket/10205] Fix remaining db drivers.Oleg Pudeyev2012-12-045-43/+93
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10205
| * | | | | | | [ticket/10205] Avoid calling mysqli functions when mysqli is missing.Oleg Pudeyev2012-12-041-4/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10205
| * | | | | | | [ticket/10205] Account for potentially missing extensions in dbal.Oleg Pudeyev2012-12-045-4/+93
| | |/ / / / / | |/| | | | | | | | | | | | | | | | | | | PHPBB3-10205
* | | | | | | Merge remote-tracking branch 'p/ticket/11248' into develop-olympusIgor Wiedler2012-12-071-51/+50
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | * p/ticket/11248: [ticket/11248] Line endings to LF.
| * | | | | | [ticket/11248] Line endings to LF.Oleg Pudeyev2012-12-051-51/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-11248
* | | | | | | Merge PR #1101 branch 'Noxwizard/ticket/11219' into develop-olympusOleg Pudeyev2012-12-063-1/+181
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Noxwizard/ticket/11219: [ticket/11219] Coding guidelines and naming consistency changes [ticket/11219] Only update sequences that are affected by a fixture [ticket/11219] Recreate Oracle sequences instead of altering them [ticket/11219] Add unit test for inserting into a sequence column [ticket/11219] Update sequence values after loading fixtures
| * | | | | | [ticket/11219] Coding guidelines and naming consistency changesPatrick Webster2012-12-052-12/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-11219
| * | | | | | [ticket/11219] Only update sequences that are affected by a fixturePatrick Webster2012-12-012-36/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-11219
| * | | | | | [ticket/11219] Recreate Oracle sequences instead of altering themPatrick Webster2012-11-201-53/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous method would always leave a gap between the last value and the new one due to how you have to update the sequence values. To remove gaps in all situations, the options are to alter the USER_SEQUENCES table or just drop the sequence and recreate it. The prior requires elevated priveleges and the latter can break attached objects. Since we don't attach objects to the sequences, we won't have any problems doing it for the tests. PHPBB3-11219
| * | | | | | [ticket/11219] Add unit test for inserting into a sequence columnJoas Schilling2012-11-191-0/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-11219
| * | | | | | [ticket/11219] Update sequence values after loading fixturesPatrick Webster2012-11-182-0/+139
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If a value is provide for an auto_increment type of column, certain DBMSes do not update their internal sequencers. If a row is inserted later, it can be given an ID that is already in use, resulting in an error. The database test cases now resynchronise the sequencers before the tests are run. PHPBB3-11219
* | | | | | | Merge PR #1053 branch 'p/ticket/10841' into develop-olympusOleg Pudeyev2012-12-053-6/+42
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * p/ticket/10841: [ticket/10841] Revert more whitespace changes. [ticket/10841] Revert whitespace changes. [ticket/10841] adding space after if [ticket/10841] removing unnecessary spacing [ticket/10841] changing affectedrows check to COUNT in sql [ticket/10841] Modifying style and language selectors in UCP
| * | | | | | | [ticket/10841] Revert more whitespace changes.Oleg Pudeyev2012-12-051-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10841
| * | | | | | | [ticket/10841] Revert whitespace changes.Oleg Pudeyev2012-12-052-20/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10841
| * | | | | | | [ticket/10841] adding space after ifSenky2012-12-051-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10841