13 files changed, 473 insertions, 9 deletions
diff --git a/tests/RUNNING_TESTS.txt b/tests/RUNNING_TESTS.md
index de9c751238..26a93f0430 100644
--- a/tests/RUNNING_TESTS.txt
+++ b/tests/RUNNING_TESTS.md
@@ -7,9 +7,14 @@ Prerequisites
 PHPUnit
 -------
 
-phpBB unit tests use PHPUnit framework. Version 3.5 or better is required
-to run the tests. PHPUnit prefers to be installed via PEAR; refer to
-http://www.phpunit.de/ for more information.
+phpBB unit tests use the PHPUnit framework (see http://www.phpunit.de for more
+information). Version 3.5 or higher is required to run the tests. PHPUnit can
+be installed via Composer together with other development dependencies as
+follows.
+
+    $ cd phpBB
+    $ php ../composer.phar install --dev
+    $ cd ..
 
 PHP extensions
 --------------
@@ -74,14 +79,16 @@ In order to run tests on some of the databases that we support, it will be
 necessary to provide a custom DSN string in test_config.php. This is only
 needed for MSSQL 2000+ (PHP module), MSSQL via ODBC, and Firebird when
 PDO_Firebird does not work on your system
-(https://bugs.php.net/bug.php?id=61183). The variable must be named $custom_dsn.
+(https://bugs.php.net/bug.php?id=61183). The variable must be named `$custom_dsn`.
 
 Examples:
 Firebird using http://www.firebirdsql.org/en/odbc-driver/
-$custom_dsn = "Driver={Firebird/InterBase(r) driver};dbname=$dbhost:$dbname";
+
+    $custom_dsn = "Driver={Firebird/InterBase(r) driver};dbname=$dbhost:$dbname";
 
 MSSQL
-$custom_dsn = "Driver={SQL Server Native Client 10.0};Server=$dbhost;Database=$dbname";
+
+    $custom_dsn = "Driver={SQL Server Native Client 10.0};Server=$dbhost;Database=$dbname";
 
 The other fields in test_config.php should be filled out as you would normally
 to connect to that database in phpBB.
@@ -95,7 +102,7 @@ Running
 Once the prerequisites are installed, run the tests from the project root
 directory (above phpBB):
 
-    $ phpunit
+    $ phpBB/vendor/bin/phpunit
 
 Slow tests
 --------------
@@ -105,7 +112,7 @@ Thus these tests are in the `slow` group, which is excluded by default. You can
 enable slow tests by copying the phpunit.xml.all file to phpunit.xml. If you
 only want the slow tests, run:
 
-    $ phpunit --group slow
+    $ phpBB/vendor/bin/phpunit --group slow
 
 More Information
 ================
diff --git a/tests/dbal/order_lower_test.php b/tests/dbal/order_lower_test.php
index b50494d506..b07f1baa91 100644
--- a/tests/dbal/order_lower_test.php
+++ b/tests/dbal/order_lower_test.php
@@ -14,7 +14,7 @@ class phpbb_dbal_order_lower_test extends phpbb_database_test_case
 		return $this->createXMLDataSet(dirname(__FILE__).'/fixtures/styles.xml');
 	}
 
-	public function test_cross_join()
+	public function test_order_lower()
 	{
 		$db = $this->new_dbal();
 
diff --git a/tests/functional/acp_groups_test.php b/tests/functional/acp_groups_test.php
new file mode 100644
index 0000000000..3d8cabb086
--- /dev/null
+++ b/tests/functional/acp_groups_test.php
@@ -0,0 +1,21 @@
+<?php
+/**
+*
+* @package testing
+* @copyright (c) 2013 phpBB Group
+* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
+*
+*/
+
+require_once dirname(__FILE__) . '/common_groups_test.php';
+
+/**
+* @group functional
+*/
+class phpbb_functional_acp_groups_test extends phpbb_functional_common_groups_test
+{
+	protected function get_url()
+	{
+		return 'adm/index.php?i=groups&mode=manage&action=edit';
+	}
+}
diff --git a/tests/functional/common_groups_test.php b/tests/functional/common_groups_test.php
new file mode 100644
index 0000000000..7ccd78421e
--- /dev/null
+++ b/tests/functional/common_groups_test.php
@@ -0,0 +1,45 @@
+<?php
+/**
+*
+* @package testing
+* @copyright (c) 2013 phpBB Group
+* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
+*
+*/
+
+/**
+* @group functional
+*/
+abstract class phpbb_functional_common_groups_test extends phpbb_functional_test_case
+{
+	abstract protected function get_url();
+
+	public function groups_manage_test_data()
+	{
+		return array(
+			array('', 'GROUP_UPDATED'),
+			array('aa0000', 'GROUP_UPDATED'),
+
+			array('AAG000','WRONG_DATA_COLOUR'),
+			array('#AA0000', 'WRONG_DATA_COLOUR'),
+		);
+	}
+
+	/**
+	* @dataProvider groups_manage_test_data
+	*/
+	public function test_groups_manage($input, $expected)
+	{
+		$this->login();
+		$this->admin_login();
+		$this->add_lang(array('ucp', 'acp/groups'));
+
+		// Manage Administrators group
+		$crawler = $this->request('GET', $this->get_url() . '&g=5&sid=' . $this->sid);
+		$this->assert_response_success();
+		$form = $crawler->selectButton($this->lang('SUBMIT'))->form();
+		$form['group_colour']->setValue($input);
+		$crawler = $this->client->submit($form);
+		$this->assertContains($this->lang($expected), $crawler->text());
+	}
+}
diff --git a/tests/functional/ucp_groups_test.php b/tests/functional/ucp_groups_test.php
new file mode 100644
index 0000000000..9c6b1edc5e
--- /dev/null
+++ b/tests/functional/ucp_groups_test.php
@@ -0,0 +1,21 @@
+<?php
+/**
+*
+* @package testing
+* @copyright (c) 2013 phpBB Group
+* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
+*
+*/
+
+require_once dirname(__FILE__) . '/common_groups_test.php';
+
+/**
+* @group functional
+*/
+class phpbb_functional_ucp_groups_test extends phpbb_functional_common_groups_test
+{
+	protected function get_url()
+	{
+		return 'ucp.php?i=groups&mode=manage&action=edit';
+	}
+}
diff --git a/tests/functions/fixtures/language_select.xml b/tests/functions/fixtures/language_select.xml
new file mode 100644
index 0000000000..d7232a3d28
--- /dev/null
+++ b/tests/functions/fixtures/language_select.xml
@@ -0,0 +1,21 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<dataset>
+	<table name="phpbb_lang">
+		<column>lang_id</column>
+		<column>lang_iso</column>
+		<column>lang_local_name</column>
+		<column>lang_english_name</column>
+		<row>
+			<value>1</value>
+			<value>en</value>
+			<value>English</value>
+			<value>English</value>
+		</row>
+		<row>
+			<value>2</value>
+			<value>cs</value>
+			<value>Čeština</value>
+			<value>Czech</value>
+		</row>
+	</table>
+</dataset>
diff --git a/tests/functions/fixtures/style_select.xml b/tests/functions/fixtures/style_select.xml
new file mode 100644
index 0000000000..12d6392ab5
--- /dev/null
+++ b/tests/functions/fixtures/style_select.xml
@@ -0,0 +1,23 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<dataset>
+	<table name="phpbb_styles">
+		<column>style_id</column>
+		<column>style_name</column>
+		<column>style_active</column>
+		<row>
+			<value>1</value>
+			<value>prosilver</value>
+			<value>1</value>
+		</row>
+		<row>
+			<value>2</value>
+			<value>subsilver2</value>
+			<value>1</value>
+		</row>
+		<row>
+			<value>3</value>
+			<value>zoo</value>
+			<value>0</value>
+		</row>
+	</table>
+</dataset>
diff --git a/tests/functions/is_absolute_test.php b/tests/functions/is_absolute_test.php
new file mode 100644
index 0000000000..7630b7c58c
--- /dev/null
+++ b/tests/functions/is_absolute_test.php
@@ -0,0 +1,56 @@
+<?php
+/**
+*
+* @package testing
+* @copyright (c) 2013 phpBB Group
+* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
+*
+*/
+
+require_once dirname(__FILE__) . '/../../phpBB/includes/functions.php';
+
+class phpbb_functions_is_absolute_test extends phpbb_test_case
+{
+	static public function is_absolute_data()
+	{
+		return array(
+			// Empty
+			array('', false),
+
+			// Absolute unix style
+			array('/etc/phpbb', true),
+			// Unix does not support \ so that is not an absolute path
+			array('\etc\phpbb', false),
+
+			// Absolute windows style
+			array('c:\windows', true),
+			array('C:\Windows', true),
+			array('c:/windows', true),
+			array('C:/Windows', true),
+
+			// Executable
+			array('etc/phpbb', false),
+			array('explorer.exe', false),
+
+			// Relative subdir
+			array('Windows\System32', false),
+			array('Windows\System32\explorer.exe', false),
+			array('Windows/System32', false),
+			array('Windows/System32/explorer.exe', false),
+
+			// Relative updir
+			array('..\Windows\System32', false),
+			array('..\Windows\System32\explorer.exe', false),
+			array('../Windows/System32', false),
+			array('../Windows/System32/explorer.exe', false),
+		);
+	}
+
+	/**
+	* @dataProvider is_absolute_data
+	*/
+	public function test_is_absolute($path, $expected)
+	{
+		$this->assertEquals($expected, is_absolute($path));
+	}
+}
diff --git a/tests/functions/language_select_test.php b/tests/functions/language_select_test.php
new file mode 100644
index 0000000000..3341e2a256
--- /dev/null
+++ b/tests/functions/language_select_test.php
@@ -0,0 +1,39 @@
+<?php
+/**
+*
+* @package testing
+* @copyright (c) 2013 phpBB Group
+* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
+*
+*/
+
+require_once dirname(__FILE__) . '/../../phpBB/includes/functions.php';
+
+class phpbb_functions_language_select_test extends phpbb_database_test_case
+{
+	public function getDataSet()
+	{
+		return $this->createXMLDataSet(dirname(__FILE__).'/fixtures/language_select.xml');
+	}
+
+	static public function language_select_data()
+	{
+		return array(
+			array('', '<option value="cs">Čeština</option><option value="en">English</option>'),
+			array('en', '<option value="cs">Čeština</option><option value="en" selected="selected">English</option>'),
+			array('cs', '<option value="cs" selected="selected">Čeština</option><option value="en">English</option>'),
+			array('de', '<option value="cs">Čeština</option><option value="en">English</option>'),
+		);
+	}
+
+	/**
+	* @dataProvider language_select_data
+	*/
+	public function test_language_select($default, $expected)
+	{
+		global $db;
+		$db = $this->new_dbal();
+
+		$this->assertEquals($expected, language_select($default));
+	}
+}
diff --git a/tests/functions/style_select_test.php b/tests/functions/style_select_test.php
new file mode 100644
index 0000000000..1e44f3c2cb
--- /dev/null
+++ b/tests/functions/style_select_test.php
@@ -0,0 +1,41 @@
+<?php
+/**
+*
+* @package testing
+* @copyright (c) 2013 phpBB Group
+* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
+*
+*/
+
+require_once dirname(__FILE__) . '/../../phpBB/includes/functions.php';
+
+class phpbb_functions_style_select_test extends phpbb_database_test_case
+{
+	public function getDataSet()
+	{
+		return $this->createXMLDataSet(dirname(__FILE__).'/fixtures/style_select.xml');
+	}
+
+	static public function style_select_data()
+	{
+		return array(
+			array('', false, '<option value="1">prosilver</option><option value="2">subsilver2</option>'),
+			array('', true, '<option value="1">prosilver</option><option value="2">subsilver2</option><option value="3">zoo</option>'),
+			array('1', false, '<option value="1" selected="selected">prosilver</option><option value="2">subsilver2</option>'),
+			array('1', true, '<option value="1" selected="selected">prosilver</option><option value="2">subsilver2</option><option value="3">zoo</option>'),
+			array('3', false, '<option value="1">prosilver</option><option value="2">subsilver2</option>'),
+			array('3', true, '<option value="1">prosilver</option><option value="2">subsilver2</option><option value="3" selected="selected">zoo</option>'),
+		);
+	}
+
+	/**
+	* @dataProvider style_select_data
+	*/
+	public function test_style_select($default, $all, $expected)
+	{
+		global $db;
+		$db = $this->new_dbal();
+
+		$this->assertEquals($expected, style_select($default, $all));
+	}
+}
diff --git a/tests/functions/validate_hex_colour_test.php b/tests/functions/validate_hex_colour_test.php
new file mode 100644
index 0000000000..812ebe5eeb
--- /dev/null
+++ b/tests/functions/validate_hex_colour_test.php
@@ -0,0 +1,121 @@
+<?php
+/**
+*
+* @package testing
+* @copyright (c) 2013 phpBB Group
+* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
+*
+*/
+
+require_once dirname(__FILE__) . '/../../phpBB/includes/functions_user.php';
+
+class phpbb_functions_validate_hex_colour_test extends phpbb_test_case
+{
+	public function positive_match_data()
+	{
+		return array(
+			array('a00'),
+			array('AFF'),
+			array('AA0000'),
+			array('aa00FF'),
+			array('000'),
+			array('000000'),
+		);
+	}
+
+	public function negative_match_data()
+	{
+		return array(
+			// Invalid prefix
+			array('#aa0'),
+			array('#AA0000'),
+			array('vAA0000'),
+
+			// Invalid suffix
+			array('AA0000v'),
+
+			// Correct length, but out of hex range
+			array('ag0'),
+			array('AAG000'),
+
+			// Too long
+			array('AA00000'),
+			array('AA0000 '),
+			array('AA0000 abf'),
+			array('AA0000 AA0000'),
+
+			// empty()
+			array('0'),
+		);
+	}
+
+	public function optional_only_data()
+	{
+		return array(
+			// The empty colour, i.e. "no colour".
+			array(''),
+		);
+	}
+
+	public function strict_negative_match_data()
+	{
+		return array_merge(
+			$this->negative_match_data(),
+			$this->optional_only_data()
+		);
+	}
+
+	public function nonstrict_positive_match_data()
+	{
+		return array_merge(
+			$this->positive_match_data(),
+			$this->optional_only_data()
+		);
+	}
+
+	/**
+	* @dataProvider positive_match_data
+	*/
+	public function test_strict_positive_match($input)
+	{
+		$this->assertFalse(
+			phpbb_validate_hex_colour($input, false),
+			"Failed asserting that $input passes as a valid hex colour."
+		);
+	}
+
+	/**
+	* @dataProvider strict_negative_match_data
+	*/
+	public function test_strict_negative_match($input)
+	{
+		$this->assertSame(
+			'WRONG_DATA',
+			phpbb_validate_hex_colour($input, false),
+			"Failed asserting that $input does not pass as a valid hex colour."
+		);
+	}
+
+	/**
+	* @dataProvider nonstrict_positive_match_data
+	*/
+	public function test_nonstrict_positive_match($input)
+	{
+		$this->assertFalse(
+			phpbb_validate_hex_colour($input, true),
+			"Failed asserting that $input passes as a valid or optional hex colour."
+		);
+	}
+
+	/**
+	* @dataProvider negative_match_data
+	*/
+	public function test_nonstrict_negative_match($input)
+	{
+		$this->assertSame(
+			'WRONG_DATA',
+			phpbb_validate_hex_colour($input, true),
+			"Failed asserting that $input does not pass as a valid or optional hex colour."
+		);
+	}
+}
diff --git a/tests/test_framework/phpbb_database_test_connection_manager.php b/tests/test_framework/phpbb_database_test_connection_manager.php
index 3b8c2e99ae..bcd52b1794 100644
--- a/tests/test_framework/phpbb_database_test_connection_manager.php
+++ b/tests/test_framework/phpbb_database_test_connection_manager.php
@@ -142,6 +142,28 @@ class phpbb_database_test_connection_manager
 		}
 
 		$this->pdo->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
+
+		switch ($this->config['dbms'])
+		{
+			case 'mysql':
+			case 'mysqli':
+				$this->pdo->exec('SET NAMES utf8');
+
+				/*
+				* The phpBB MySQL drivers set the STRICT_ALL_TABLES and
+				* STRICT_TRANS_TABLES flags/modes, so as a minimum requirement
+				* we want to make sure those are set for the PDO side of the
+				* test suite.
+				*
+				* The TRADITIONAL flag implies STRICT_ALL_TABLES and
+				* STRICT_TRANS_TABLES as well as other useful strictness flags
+				* the phpBB MySQL driver does not set.
+				*/
+				$this->pdo->exec("SET SESSION sql_mode='TRADITIONAL'");
+			break;
+
+			default:
+		}
 	}
 
 	/**
diff --git a/tests/test_framework/phpbb_functional_test_case.php b/tests/test_framework/phpbb_functional_test_case.php
index 8ab6469e9a..b1352b247e 100644
--- a/tests/test_framework/phpbb_functional_test_case.php
+++ b/tests/test_framework/phpbb_functional_test_case.php
@@ -299,6 +299,50 @@ class phpbb_functional_test_case extends phpbb_test_case
 		}
 	}
 
+	/**
+	* Login to the ACP
+	* You must run login() before calling this.
+	*/
+	protected function admin_login($username = 'admin')
+	{
+		$this->add_lang('acp/common');
+
+		// Requires login first!
+		if (empty($this->sid))
+		{
+			$this->fail('$this->sid is empty. Make sure you call login() before admin_login()');
+			return;
+		}
+
+		$crawler = $this->request('GET', 'adm/index.php?sid=' . $this->sid);
+		$this->assertContains($this->lang('LOGIN_ADMIN_CONFIRM'), $crawler->filter('html')->text());
+
+		$form = $crawler->selectButton($this->lang('LOGIN'))->form();
+
+		foreach ($form->getValues() as $field => $value)
+		{
+			if (strpos($field, 'password_') === 0)
+			{
+				$crawler = $this->client->submit($form, array('username' => $username, $field => $username));
+				$this->assert_response_success();
+				$this->assertContains($this->lang('LOGIN_ADMIN_SUCCESS'), $crawler->filter('html')->text());
+
+				$cookies = $this->cookieJar->all();
+
+				// The session id is stored in a cookie that ends with _sid - we assume there is only one such cookie
+				foreach ($cookies as $cookie);
+				{
+					if (substr($cookie->getName(), -4) == '_sid')
+					{
+						$this->sid = $cookie->getValue();
+					}
+				}
+
+				break;
+			}
+		}
+	}
+
 	protected function add_lang($lang_file)
 	{
 		if (is_array($lang_file))
@@ -349,5 +393,8 @@ class phpbb_functional_test_case extends phpbb_test_case
 		$this->assertEquals(200, $this->client->getResponse()->getStatus());
 		$content = $this->client->getResponse()->getContent();
 		$this->assertNotContains('Fatal error:', $content);
+		$this->assertNotContains('Notice:', $content);
+		$this->assertNotContains('Warning:', $content);
+		$this->assertNotContains('[phpBB Debug]', $content);
 	}
 }