diff options
Diffstat (limited to 'phpBB')
23 files changed, 172 insertions, 48 deletions
| diff --git a/phpBB/composer.lock b/phpBB/composer.lock index 2c338bf292..7d4f355e64 100644 --- a/phpBB/composer.lock +++ b/phpBB/composer.lock @@ -342,7 +342,7 @@                  "oauth",                  "security"              ], -            "time": "2016-07-12T22:15:00+00:00" +            "time": "2018-02-14T22:37:14+00:00"          },          {              "name": "marc1706/fast-image-size", @@ -505,7 +505,7 @@                  "pseudorandom",                  "random"              ], -            "time": "2017-03-13T16:22:52+00:00" +            "time": "2018-04-04T21:48:54+00:00"          },          {              "name": "patchwork/utf8", @@ -661,16 +661,16 @@          },          {              "name": "s9e/text-formatter", -            "version": "1.4.2", +            "version": "1.4.5",              "source": {                  "type": "git",                  "url": "https://github.com/s9e/TextFormatter.git", -                "reference": "dc7efff70b67b9cee00881ad3bef0a1da076b31e" +                "reference": "6857c53658929b66dc0d92daece17f211c64ea61"              },              "dist": {                  "type": "zip", -                "url": "https://api.github.com/repos/s9e/TextFormatter/zipball/dc7efff70b67b9cee00881ad3bef0a1da076b31e", -                "reference": "dc7efff70b67b9cee00881ad3bef0a1da076b31e", +                "url": "https://api.github.com/repos/s9e/TextFormatter/zipball/6857c53658929b66dc0d92daece17f211c64ea61", +                "reference": "6857c53658929b66dc0d92daece17f211c64ea61",                  "shasum": ""              },              "require": { @@ -682,6 +682,7 @@              "require-dev": {                  "matthiasmullie/minify": "*",                  "php-coveralls/php-coveralls": "*", +                "phpunit/phpunit": "<6",                  "s9e/regexp-builder": "1.*"              },              "suggest": { @@ -722,7 +723,7 @@                  "parser",                  "shortcodes"              ], -            "time": "2019-03-27T14:19:41+00:00" +            "time": "2019-06-04T15:47:55+00:00"          },          {              "name": "symfony/config", @@ -2293,7 +2294,8 @@              "authors": [                  {                      "name": "Michiel Rook", -                    "email": "mrook@php.net" +                    "email": "mrook@php.net", +                    "role": "Lead"                  },                  {                      "name": "Phing Community", diff --git a/phpBB/docs/events.md b/phpBB/docs/events.md index fb782ee452..c77691a048 100644 --- a/phpBB/docs/events.md +++ b/phpBB/docs/events.md @@ -1910,6 +1910,20 @@ posting_preview_poll_after  * Since: 3.1.7-RC1  * Purpose: Add content after the poll preview block +posting_review_row_post_author_username_append +=== +* Locations: +    + styles/prosilver/template/posting_review.html +* Since: 3.2.8-RC1 +* Purpose: Append information to post author username of member + +posting_review_row_post_author_username_prepend +=== +* Locations: +    + styles/prosilver/template/posting_review.html +* Since: 3.2.8-RC1 +* Purpose: Prepend information to post author username of member +  posting_topic_review_row_content_after  ===  * Locations: @@ -1917,6 +1931,20 @@ posting_topic_review_row_content_after  * Since: 3.2.4-RC1  * Purpose: Add content after the message content in topic review +posting_topic_review_row_post_author_username_append +=== +* Locations: +    + styles/prosilver/template/posting_topic_review.html +* Since: 3.2.8-RC1 +* Purpose: Append information to post author username of member + +posting_topic_review_row_post_author_username_prepend +=== +* Locations: +    + styles/prosilver/template/posting_topic_review.html +* Since: 3.2.8-RC1 +* Purpose: Prepend information to post author username of member +  posting_topic_review_row_post_details_after  ===  * Locations: @@ -2364,6 +2392,20 @@ ucp_pm_history_review_before  * Since: 3.1.6-RC1  * Purpose: Add content before the private messages history review. +ucp_pm_history_row_message_author_username_append +=== +* Locations: +    + styles/prosilver/template/ucp_pm_history.html +* Since: 3.2.8-RC1 +* Purpose: Append information to message author username of member + +ucp_pm_history_row_message_author_username_prepend +=== +* Locations: +    + styles/prosilver/template/ucp_pm_history.html +* Since: 3.2.8-RC1 +* Purpose: Prepend information to message author username of member +  ucp_pm_viewmessage_avatar_after  ===  * Locations: diff --git a/phpBB/includes/acp/acp_attachments.php b/phpBB/includes/acp/acp_attachments.php index 5b1db5c31b..a7035f38b7 100644 --- a/phpBB/includes/acp/acp_attachments.php +++ b/phpBB/includes/acp/acp_attachments.php @@ -1240,13 +1240,17 @@ class acp_attachments  					$display_cat = isset($extensions[$row['extension']]['display_cat']) ? $extensions[$row['extension']]['display_cat'] : ATTACHMENT_CATEGORY_NONE;  					$l_downloaded_viewed = ($display_cat == ATTACHMENT_CATEGORY_NONE) ? 'DOWNLOAD_COUNTS' : 'VIEWED_COUNTS'; +					// Capitalises the group name and checks if its key exists in the language file +					$up_group_name = utf8_strtoupper($extensions[$row['extension']]['group_name']); +					$ext_group_name = (!empty($up_group_name)) ? (isset($user->lang['EXT_GROUP_' .  $up_group_name]) ? $user->lang['EXT_GROUP_' .  $up_group_name] : '') : ''; +  					$template->assign_block_vars('attachments', array(  						'ATTACHMENT_POSTER'	=> get_username_string('full', (int) $row['poster_id'], (string) $row['username'], (string) $row['user_colour'], (string) $row['username']),  						'FILESIZE'			=> get_formatted_filesize((int) $row['filesize']),  						'FILETIME'			=> $user->format_date((int) $row['filetime']),  						'REAL_FILENAME'		=> (!$row['in_message']) ? utf8_basename((string) $row['real_filename']) : '',  						'PHYSICAL_FILENAME'	=> utf8_basename((string) $row['physical_filename']), -						'EXT_GROUP_NAME'	=> (!empty($extensions[$row['extension']]['group_name'])) ? $user->lang['EXT_GROUP_' . $extensions[$row['extension']]['group_name']] : '', +						'EXT_GROUP_NAME'	=> $ext_group_name,  						'COMMENT'			=> $comment,  						'TOPIC_TITLE'		=> (!$row['in_message']) ? (string) $row['topic_title'] : '',  						'ATTACH_ID'			=> (int) $row['attach_id'], diff --git a/phpBB/includes/acp/acp_forums.php b/phpBB/includes/acp/acp_forums.php index be5a7a2f26..cb0593b14a 100644 --- a/phpBB/includes/acp/acp_forums.php +++ b/phpBB/includes/acp/acp_forums.php @@ -986,6 +986,13 @@ class acp_forums  			$errors[] = $user->lang['FORUM_NAME_EMPTY'];  		} +		// No Emojis +		if (preg_match_all('/[\x{10000}-\x{10FFFF}]/u', $forum_data_ary['forum_name'], $matches)) +		{ +			$character_list = implode('<br>', $matches[0]); +			$errors[] = $user->lang('FORUM_NAME_EMOJI', $character_list); +		} +  		if (utf8_strlen($forum_data_ary['forum_desc']) > 4000)  		{  			$errors[] = $user->lang['FORUM_DESC_TOO_LONG']; diff --git a/phpBB/includes/acp/acp_update.php b/phpBB/includes/acp/acp_update.php index 9124a59ef2..fa3afa6ce3 100644 --- a/phpBB/includes/acp/acp_update.php +++ b/phpBB/includes/acp/acp_update.php @@ -59,17 +59,19 @@ class acp_update  		$update_link = $phpbb_root_path . 'install/app.' . $phpEx; -		$template->assign_vars(array( -			'S_UP_TO_DATE'			=> empty($updates_available), -			'U_ACTION'				=> $this->u_action, -			'U_VERSIONCHECK_FORCE'	=> append_sid($this->u_action . '&versioncheck_force=1'), +		$template_ary = [ +			'S_UP_TO_DATE'				=> empty($updates_available), +			'U_ACTION'					=> $this->u_action, +			'U_VERSIONCHECK_FORCE'		=> append_sid($this->u_action . '&versioncheck_force=1'), -			'CURRENT_VERSION'		=> $config['version'], +			'CURRENT_VERSION'			=> $config['version'], -			'UPDATE_INSTRUCTIONS'	=> sprintf($user->lang['UPDATE_INSTRUCTIONS'], $update_link), +			'UPDATE_INSTRUCTIONS'		=> $user->lang('UPDATE_INSTRUCTIONS', $update_link),  			'S_VERSION_UPGRADEABLE'		=> !empty($upgrades_available),  			'UPGRADE_INSTRUCTIONS'		=> !empty($upgrades_available) ? $user->lang('UPGRADE_INSTRUCTIONS', $upgrades_available['current'], $upgrades_available['announcement']) : false, -		)); +		]; + +		$template->assign_vars($template_ary);  		// Incomplete update?  		if (phpbb_version_compare($config['version'], PHPBB_VERSION, '<')) diff --git a/phpBB/includes/functions_download.php b/phpBB/includes/functions_download.php index 7be12baa13..1f409be58c 100644 --- a/phpBB/includes/functions_download.php +++ b/phpBB/includes/functions_download.php @@ -196,7 +196,7 @@ function send_file_to_browser($attachment, $upload_dir, $category)  	}  	// Now the tricky part... let's dance -	header('Cache-Control: public'); +	header('Cache-Control: private');  	// Send out the Headers. Do not set Content-Disposition to inline please, it is a security measure for users using the Internet Explorer.  	header('Content-Type: ' . $attachment['mimetype']); @@ -451,7 +451,7 @@ function set_modified_headers($stamp, $browser)  		{  			send_status_line(304, 'Not Modified');  			// seems that we need those too ... browsers -			header('Cache-Control: public'); +			header('Cache-Control: private');  			header('Expires: ' . gmdate('D, d M Y H:i:s', time() + 31536000) . ' GMT');  			return true;  		} diff --git a/phpBB/includes/functions_messenger.php b/phpBB/includes/functions_messenger.php index 4f0d40031d..f44bcc6fb7 100644 --- a/phpBB/includes/functions_messenger.php +++ b/phpBB/includes/functions_messenger.php @@ -181,10 +181,9 @@ class messenger  	/**  	* Adds X-AntiAbuse headers  	* -	* @param array $config		Configuration array -	* @param user $user			A user object -	* -	* @return null +	* @param \phpbb\config\config	$config		Config object +	* @param \phpbb\user			$user		User object +	* @return void  	*/  	function anti_abuse_headers($config, $user)  	{ diff --git a/phpBB/includes/functions_posting.php b/phpBB/includes/functions_posting.php index 3640f543d9..c5a7400ddf 100644 --- a/phpBB/includes/functions_posting.php +++ b/phpBB/includes/functions_posting.php @@ -978,6 +978,30 @@ function topic_review($topic_id, $forum_id, $mode = 'topic_review', $cur_post_id  			AND u.user_id = p.poster_id',  	); +	/** +	* Event to modify the SQL query for topic reviews +	* +	* @event core.topic_review_modify_sql_ary +	* @var	int		topic_id			The topic ID that is being reviewed +	* @var	int		forum_id			The topic's forum ID +	* @var	string	mode				The topic review mode +	* @var	int		cur_post_id			Post offset ID +	* @var	bool	show_quote_button	Flag indicating if the quote button should be displayed +	* @var	array	post_list			Array with the post IDs +	* @var	array	sql_ary				Array with the SQL query +	* @since 3.2.8-RC1 +	*/ +	$vars = array( +		'topic_id', +		'forum_id', +		'mode', +		'cur_post_id', +		'show_quote_button', +		'post_list', +		'sql_ary', +	); +	extract($phpbb_dispatcher->trigger_event('core.topic_review_modify_sql_ary', compact($vars))); +  	$sql = $db->sql_build_query('SELECT', $sql_ary);  	$result = $db->sql_query($sql); @@ -1284,6 +1308,7 @@ function delete_post($forum_id, $topic_id, $post_id, &$data, $is_soft = false, $  				delete_topics('topic_id', array($topic_id), false);  				$phpbb_content_visibility->remove_topic_from_statistic($data, $sql_data); +				$config->increment('num_posts', -1, false);  				$update_sql = update_post_information('forum', $forum_id, true);  				if (count($update_sql)) diff --git a/phpBB/includes/functions_privmsgs.php b/phpBB/includes/functions_privmsgs.php index 444bf2c7e0..a7a4b050fe 100644 --- a/phpBB/includes/functions_privmsgs.php +++ b/phpBB/includes/functions_privmsgs.php @@ -490,7 +490,7 @@ function place_pm_into_folder(&$global_privmsgs_rules, $release = false)  				'bcc'				=> explode(':', $row['bcc_address']),  				'friend'			=> (isset($zebra[$row['author_id']])) ? $zebra[$row['author_id']]['friend'] : 0,  				'foe'				=> (isset($zebra[$row['author_id']])) ? $zebra[$row['author_id']]['foe'] : 0, -				'user_in_group'		=> array($user->data['group_id']), +				'user_in_group'		=> $user->data['group_id'],  				'author_in_group'	=> array())  			); diff --git a/phpBB/includes/ucp/ucp_attachments.php b/phpBB/includes/ucp/ucp_attachments.php index c1b623cd71..7808fed325 100644 --- a/phpBB/includes/ucp/ucp_attachments.php +++ b/phpBB/includes/ucp/ucp_attachments.php @@ -29,7 +29,7 @@ class ucp_attachments  	function main($id, $mode)  	{ -		global $template, $user, $db, $config, $phpEx, $phpbb_root_path, $phpbb_container, $request; +		global $template, $user, $db, $config, $phpEx, $phpbb_root_path, $phpbb_container, $request, $auth;  		$start		= $request->variable('start', 0);  		$sort_key	= $request->variable('sk', 'a'); @@ -41,16 +41,27 @@ class ucp_attachments  		if ($delete && count($delete_ids))  		{  			// Validate $delete_ids... -			$sql = 'SELECT attach_id -				FROM ' . ATTACHMENTS_TABLE . ' -				WHERE poster_id = ' . $user->data['user_id'] . ' -					AND is_orphan = 0 -					AND ' . $db->sql_in_set('attach_id', $delete_ids); +			$sql = 'SELECT a.attach_id, p.post_edit_locked, t.topic_status, f.forum_id, f.forum_status +				FROM ' . ATTACHMENTS_TABLE . ' a +				LEFT JOIN ' . POSTS_TABLE . ' p +					ON (a.post_msg_id = p.post_id AND a.in_message = 0) +				LEFT JOIN ' . TOPICS_TABLE . ' t +					ON (t.topic_id = p.topic_id AND a.in_message = 0) +				LEFT JOIN ' . FORUMS_TABLE . ' f +					ON (f.forum_id = t.forum_id AND a.in_message = 0) +				WHERE a.poster_id = ' . $user->data['user_id'] . ' +					AND a.is_orphan = 0 +					AND ' . $db->sql_in_set('a.attach_id', $delete_ids);  			$result = $db->sql_query($sql);  			$delete_ids = array();  			while ($row = $db->sql_fetchrow($result))  			{ +				if (!$auth->acl_get('m_edit', $row['forum_id']) && ($row['forum_status'] == ITEM_LOCKED || $row['topic_status'] == ITEM_LOCKED || $row['post_edit_locked'])) +				{ +					continue; +				} +  				$delete_ids[] = $row['attach_id'];  			}  			$db->sql_freeresult($result); @@ -124,10 +135,12 @@ class ucp_attachments  		$pagination = $phpbb_container->get('pagination');  		$start = $pagination->validate_start($start, $config['topics_per_page'], $num_attachments); -		$sql = 'SELECT a.*, t.topic_title, p.message_subject as message_title +		$sql = 'SELECT a.*, t.topic_title, pr.message_subject as message_title, p.post_edit_locked, t.topic_status, f.forum_id, f.forum_status  			FROM ' . ATTACHMENTS_TABLE . ' a +				LEFT JOIN ' . POSTS_TABLE . ' p ON (a.post_msg_id = p.post_id AND a.in_message = 0)  				LEFT JOIN ' . TOPICS_TABLE . ' t ON (a.topic_id = t.topic_id AND a.in_message = 0) -				LEFT JOIN ' . PRIVMSGS_TABLE . ' p ON (a.post_msg_id = p.msg_id AND a.in_message = 1) +				LEFT JOIN ' . FORUMS_TABLE . ' f ON (f.forum_id = t.forum_id AND a.in_message = 0) +				LEFT JOIN ' . PRIVMSGS_TABLE . ' pr ON (a.post_msg_id = pr.msg_id AND a.in_message = 1)  			WHERE a.poster_id = ' . $user->data['user_id'] . "  				AND a.is_orphan = 0  			ORDER BY $order_by"; @@ -164,6 +177,7 @@ class ucp_attachments  					'TOPIC_ID'			=> $row['topic_id'],  					'S_IN_MESSAGE'		=> $row['in_message'], +					'S_LOCKED'			=> !$row['in_message'] && !$auth->acl_get('m_edit', $row['forum_id']) && ($row['forum_status'] == ITEM_LOCKED || $row['topic_status'] == ITEM_LOCKED || $row['post_edit_locked']),  					'U_VIEW_ATTACHMENT'	=> append_sid("{$phpbb_root_path}download/file.$phpEx", 'id=' . $row['attach_id']),  					'U_VIEW_TOPIC'		=> $view_topic) diff --git a/phpBB/language/en/acp/board.php b/phpBB/language/en/acp/board.php index 9b45ffa45b..378dd3fc38 100644 --- a/phpBB/language/en/acp/board.php +++ b/phpBB/language/en/acp/board.php @@ -44,7 +44,7 @@ $lang = array_merge($lang, array(  	'BOARD_STYLE'					=> 'Board style',  	'CUSTOM_DATEFORMAT'				=> 'Custom…',  	'DEFAULT_DATE_FORMAT'			=> 'Date format', -	'DEFAULT_DATE_FORMAT_EXPLAIN'	=> 'The date format is the same as the PHP <code>date</code> function.', +	'DEFAULT_DATE_FORMAT_EXPLAIN'	=> 'The date format is the same as the PHP <code><a href="https://secure.php.net/manual/function.date.php">date()</a></code> function.',  	'DEFAULT_LANGUAGE'				=> 'Default language',  	'DEFAULT_STYLE'					=> 'Default style',  	'DEFAULT_STYLE_EXPLAIN'			=> 'The default style for new users.', diff --git a/phpBB/language/en/acp/forums.php b/phpBB/language/en/acp/forums.php index 7a7176369f..d92d3f8c9e 100644 --- a/phpBB/language/en/acp/forums.php +++ b/phpBB/language/en/acp/forums.php @@ -97,6 +97,7 @@ $lang = array_merge($lang, array(  	'FORUM_LINK_TRACK_EXPLAIN'			=> 'Records the number of times a forum link was clicked.',  	'FORUM_NAME'						=> 'Forum name',  	'FORUM_NAME_EMPTY'					=> 'You must enter a name for this forum.', +	'FORUM_NAME_EMOJI'					=> 'The forum name you entered is invalid.<br>It contains the following unsupported characters:<br>%s',  	'FORUM_PARENT'						=> 'Parent forum',  	'FORUM_PASSWORD'					=> 'Forum password',  	'FORUM_PASSWORD_CONFIRM'			=> 'Confirm forum password', diff --git a/phpBB/language/en/acp/permissions_phpbb.php b/phpBB/language/en/acp/permissions_phpbb.php index 64740b311b..2c7b3d3aee 100644 --- a/phpBB/language/en/acp/permissions_phpbb.php +++ b/phpBB/language/en/acp/permissions_phpbb.php @@ -81,8 +81,8 @@ $lang = array_merge($lang, array(  	'ACL_U_SIG'			=> 'Can use signature',  	'ACL_U_SENDPM'		=> 'Can send private messages', -	'ACL_U_MASSPM'		=> 'Can send messages to multiple users', -	'ACL_U_MASSPM_GROUP'=> 'Can send messages to groups', +	'ACL_U_MASSPM'		=> 'Can send private messages to multiple users', +	'ACL_U_MASSPM_GROUP'=> 'Can send private messages to groups',  	'ACL_U_READPM'		=> 'Can read private messages',  	'ACL_U_PM_EDIT'		=> 'Can edit own private messages',  	'ACL_U_PM_DELETE'	=> 'Can remove private messages from own folder', diff --git a/phpBB/language/en/ucp.php b/phpBB/language/en/ucp.php index 2622fb57b7..8549230b9f 100644 --- a/phpBB/language/en/ucp.php +++ b/phpBB/language/en/ucp.php @@ -89,6 +89,7 @@ $lang = array_merge($lang, array(  	'ATTACHMENTS_EXPLAIN'			=> 'This is a list of attachments you have made in posts to this board.',  	'ATTACHMENTS_DELETED'			=> 'Attachments successfully deleted.',  	'ATTACHMENT_DELETED'			=> 'Attachment successfully deleted.', +	'ATTACHMENT_LOCKED'				=> 'This topic is locked, you cannot delete the attachment.',  	'AUTOLOGIN_SESSION_KEYS_DELETED'=> 'The selected "Remember Me" login keys were successfully deleted.',  	'AVATAR_CATEGORY'				=> 'Category',  	'AVATAR_DRIVER_GRAVATAR_TITLE'	=> 'Gravatar', @@ -115,7 +116,7 @@ $lang = array_merge($lang, array(  	'BIRTHDAY'					=> 'Birthday',  	'BIRTHDAY_EXPLAIN'			=> 'Setting a year will list your age when it is your birthday.',  	'BOARD_DATE_FORMAT'			=> 'My date format', -	'BOARD_DATE_FORMAT_EXPLAIN'	=> 'The syntax used is identical to the PHP <a href="http://www.php.net/date">date()</a> function.', +	'BOARD_DATE_FORMAT_EXPLAIN'	=> 'The syntax used is identical to the PHP <a href="https://secure.php.net/manual/function.date.php">date()</a> function.',  	'BOARD_LANGUAGE'			=> 'My language',  	'BOARD_STYLE'				=> 'My board style',  	'BOARD_TIMEZONE'			=> 'My timezone', diff --git a/phpBB/phpbb/auth/provider/oauth/oauth.php b/phpBB/phpbb/auth/provider/oauth/oauth.php index 93419d2915..1a3083d42e 100644 --- a/phpBB/phpbb/auth/provider/oauth/oauth.php +++ b/phpBB/phpbb/auth/provider/oauth/oauth.php @@ -264,7 +264,7 @@ class oauth extends \phpbb\auth\provider\base  			}  			// Retrieve the user's account -			$sql = 'SELECT user_id, username, user_password, user_passchg, user_email, user_type, user_login_attempts +			$sql = 'SELECT user_id, username, user_password, user_passchg, user_email, user_ip, user_type, user_login_attempts  				FROM ' . $this->users_table . '  					WHERE user_id = ' . (int) $row['user_id'];  			$result = $this->db->sql_query($sql); @@ -423,7 +423,7 @@ class oauth extends \phpbb\auth\provider\base  			if ($credentials['key'] && $credentials['secret'])  			{  				$actual_name = str_replace('auth.provider.oauth.service.', '', $service_name); -				$redirect_url = build_url(false) . '&login=external&oauth_service=' . $actual_name; +				$redirect_url = generate_board_url() . '/ucp.' . $this->php_ext . '?mode=login&login=external&oauth_service=' . $actual_name;  				$login_data['BLOCK_VARS'][$service_name] = array(  					'REDIRECT_URL'	=> redirect($redirect_url, true),  					'SERVICE_NAME'	=> $this->user->lang['AUTH_PROVIDER_OAUTH_SERVICE_' . strtoupper($actual_name)], diff --git a/phpBB/phpbb/auth/provider/provider_interface.php b/phpBB/phpbb/auth/provider/provider_interface.php index 35e0f559a1..463324ff46 100644 --- a/phpBB/phpbb/auth/provider/provider_interface.php +++ b/phpBB/phpbb/auth/provider/provider_interface.php @@ -71,9 +71,10 @@ interface provider_interface  	 * options with whatever configuraton values are passed to it as an array.  	 * It then returns the name of the acp file related to this authentication  	 * provider. -	 * @param	array	$new_config Contains the new configuration values that -	 *								have been set in acp_board. -	 * @return	array|null		Returns null if not implemented or an array with +	 * +	 * @param \phpbb\config\config	$new_config	Contains the new configuration values +	 * 											that have been set in acp_board. +	 * @return array|null		Returns null if not implemented or an array with  	 *							the template file name and an array of the vars  	 *							that the template needs that must conform to the  	 *							following example: diff --git a/phpBB/phpbb/db/migration/data/v32x/timezone_p3.php b/phpBB/phpbb/db/migration/data/v32x/timezone_p3.php new file mode 100644 index 0000000000..433f62ace9 --- /dev/null +++ b/phpBB/phpbb/db/migration/data/v32x/timezone_p3.php @@ -0,0 +1,29 @@ +<?php +/** +* +* This file is part of the phpBB Forum Software package. +* +* @copyright (c) phpBB Limited <https://www.phpbb.com> +* @license GNU General Public License, version 2 (GPL-2.0) +* +* For full copyright and license information, please see +* the docs/CREDITS.txt file. +* +*/ + +namespace phpbb\db\migration\data\v32x; + +class timezone_p3 extends \phpbb\db\migration\migration +{ +	static public function depends_on() +	{ +		return array('\phpbb\db\migration\data\v310\timezone'); +	} + +	public function update_data() +	{ +		return array( +			array('config.remove', array('board_dst')), +		); +	} +} diff --git a/phpBB/phpbb/db/tools/tools.php b/phpBB/phpbb/db/tools/tools.php index d21d34b8a9..c3352a1f66 100644 --- a/phpBB/phpbb/db/tools/tools.php +++ b/phpBB/phpbb/db/tools/tools.php @@ -576,7 +576,7 @@ class tools implements tools_interface  			{  				foreach ($indexes as $index_name)  				{ -					if (!$this->sql_index_exists($table, $index_name)) +					if (!$this->sql_index_exists($table, $index_name) && !$this->sql_unique_index_exists($table, $index_name))  					{  						continue;  					} diff --git a/phpBB/styles/prosilver/template/posting_review.html b/phpBB/styles/prosilver/template/posting_review.html index 1304046b23..033a88485e 100644 --- a/phpBB/styles/prosilver/template/posting_review.html +++ b/phpBB/styles/prosilver/template/posting_review.html @@ -22,7 +22,7 @@  					<i class="icon fa-file fa-fw icon-lightgray icon-md" aria-hidden="true"></i><span class="sr-only">{post_review_row.MINI_POST}</span>  				</a>  			<!-- ENDIF --> -			{L_POST_BY_AUTHOR}<strong>  {post_review_row.POST_AUTHOR_FULL}</strong> » {post_review_row.POST_DATE} +			{L_POST_BY_AUTHOR} <!-- EVENT posting_review_row_post_author_username_prepend --><strong>{post_review_row.POST_AUTHOR_FULL}</strong><!-- EVENT posting_review_row_post_author_username_append --> » {post_review_row.POST_DATE}  		</p>  		<div class="content">{post_review_row.MESSAGE}</div> diff --git a/phpBB/styles/prosilver/template/posting_topic_review.html b/phpBB/styles/prosilver/template/posting_topic_review.html index 93c4484ff8..8faece3447 100644 --- a/phpBB/styles/prosilver/template/posting_topic_review.html +++ b/phpBB/styles/prosilver/template/posting_topic_review.html @@ -54,7 +54,7 @@  						<i class="icon fa-file fa-fw icon-lightgray icon-md" aria-hidden="true"></i><span class="sr-only">{topic_review_row.MINI_POST}</span>  					</a>  				<!-- ENDIF --> -				{L_POST_BY_AUTHOR} <strong>{topic_review_row.POST_AUTHOR_FULL}</strong> » {topic_review_row.POST_DATE} +				{L_POST_BY_AUTHOR} <!-- EVENT posting_topic_review_row_post_author_username_prepend --><strong>{topic_review_row.POST_AUTHOR_FULL}</strong><!-- EVENT posting_topic_review_row_post_author_username_append --> » {topic_review_row.POST_DATE}  			</p>  			<!-- EVENT posting_topic_review_row_post_details_after --> diff --git a/phpBB/styles/prosilver/template/ucp_agreement.html b/phpBB/styles/prosilver/template/ucp_agreement.html index ace65254d7..d4fef9f0a5 100644 --- a/phpBB/styles/prosilver/template/ucp_agreement.html +++ b/phpBB/styles/prosilver/template/ucp_agreement.html @@ -62,8 +62,6 @@  		<div class="content">  			<h2 class="sitename-title">{SITENAME} - {AGREEMENT_TITLE}</h2>  			<p>{AGREEMENT_TEXT}</p> -			<hr class="dashed" /> -			<p><a href="{U_BACK}" class="button2">{L_BACK}</a></p>  		</div>  		</div>  	</div> diff --git a/phpBB/styles/prosilver/template/ucp_attachments.html b/phpBB/styles/prosilver/template/ucp_attachments.html index 696f621116..cfdbf9c7ea 100644 --- a/phpBB/styles/prosilver/template/ucp_attachments.html +++ b/phpBB/styles/prosilver/template/ucp_attachments.html @@ -44,7 +44,7 @@  				</dt>  				<dd class="extra">{attachrow.DOWNLOAD_COUNT}</dd>  				<dd class="time"><span>{attachrow.POST_TIME}</span></dd> -				<dd class="mark"><input type="checkbox" name="attachment[{attachrow.ATTACH_ID}]" value="1" /></dd> +				<dd class="mark"><input type="checkbox" name="attachment[{attachrow.ATTACH_ID}]" value="1"{% if attachrow.S_LOCKED %} disabled title="{{ lang('ATTACHMENT_LOCKED') }}"{% endif %} /></dd>  			</dl>  		</li>  		<!-- END attachrow --> diff --git a/phpBB/styles/prosilver/template/ucp_pm_history.html b/phpBB/styles/prosilver/template/ucp_pm_history.html index 6362a0b824..b53eb0c7ec 100644 --- a/phpBB/styles/prosilver/template/ucp_pm_history.html +++ b/phpBB/styles/prosilver/template/ucp_pm_history.html @@ -36,7 +36,7 @@  			<p class="author">  				<span><i class="icon fa-file fa-fw icon-lightgray icon-md" aria-hidden="true"></i><span class="sr-only">{history_row.MINI_POST}</span></span> {L_SENT_AT}{L_COLON} <strong>{history_row.SENT_DATE}</strong>  				<br /> -				{L_MESSAGE_BY_AUTHOR} {history_row.MESSAGE_AUTHOR_FULL} +				{L_MESSAGE_BY_AUTHOR} <!-- EVENT ucp_pm_history_row_message_author_username_prepend -->{history_row.MESSAGE_AUTHOR_FULL}<!-- EVENT ucp_pm_history_row_message_author_username_append -->  			</p>  			<div class="content"><!-- IF history_row.MESSAGE -->{history_row.MESSAGE}<!-- ELSE --><span class="error">{L_MESSAGE_REMOVED_FROM_OUTBOX}</span><!-- ENDIF --></div>  			<div id="message_{history_row.MSG_ID}" style="display: none;">{history_row.DECODED_MESSAGE}</div> @@ -54,4 +54,3 @@  		<i class="icon fa-chevron-circle-up fa-fw icon-gray" aria-hidden="true"></i><span>{L_BACK_TO_TOP}</span>  	</a>  </p> - | 
