4 files changed, 241 insertions, 37 deletions
diff --git a/phpBB/phpbb/textformatter/s9e/bbcode_merger.php b/phpBB/phpbb/textformatter/s9e/bbcode_merger.php
new file mode 100644
index 0000000000..a05ca3c2b8
--- /dev/null
+++ b/phpBB/phpbb/textformatter/s9e/bbcode_merger.php
@@ -0,0 +1,183 @@
+<?php
+/**
+*
+* This file is part of the phpBB Forum Software package.
+*
+* @copyright (c) phpBB Limited <https://www.phpbb.com>
+* @license GNU General Public License, version 2 (GPL-2.0)
+*
+* For full copyright and license information, please see
+* the docs/CREDITS.txt file.
+*
+*/
+
+namespace phpbb\textformatter\s9e;
+
+use phpbb\textformatter\s9e\factory;
+use s9e\TextFormatter\Configurator\Helpers\TemplateHelper;
+use s9e\TextFormatter\Configurator\Items\UnsafeTemplate;
+
+class bbcode_merger
+{
+	/**
+	* @var \s9e\TextFormatter\Configurator $configurator Configurator instance used to inspect BBCodes
+	*/
+	protected $configurator;
+
+	/**
+	* @param \phpbb\textformatter\s9e\factory $factory
+	*/
+	public function __construct(factory $factory)
+	{
+		$this->configurator = $factory->get_configurator();
+	}
+
+	/**
+	* Merge two BBCode definitions
+	*
+	* All of the arrays contain a "usage" element and a "template" element
+	*
+	* @throws InvalidArgumentException if a definition cannot be interpreted
+	* @throws RuntimeException if something unexpected occurs
+	*
+	* @param  array $without BBCode definition without an attribute
+	* @param  array $with    BBCode definition with an attribute
+	* @return array          Merged definition
+	*/
+	public function merge_bbcodes(array $without, array $with)
+	{
+		$without = $this->create_bbcode($without);
+		$with    = $this->create_bbcode($with);
+
+		// Select the appropriate strategy for merging this BBCode
+		if ($this->is_content_bbcode($without, $with))
+		{
+			$merged = $this->merge_content_bbcode($without, $with);
+		}
+		else
+		{
+			$merged = $this->merge_optional_bbcode($without, $with);
+		}
+
+		$merged['template'] = $this->normalize_template($merged['template']);
+
+		return $merged;
+	}
+
+	/**
+	* Create a custom BBCode for inspection
+	*
+	* @param  array $definition Original BBCode definition
+	* @return array             Updated definition containing a BBCode object and a Tag
+	*/
+	protected function create_bbcode(array $definition)
+	{
+		$bbcode = $this->configurator->BBCodes->addCustom(
+			$definition['usage'],
+			new UnsafeTemplate($definition['template'])
+		);
+
+		$definition['bbcode'] = $bbcode;
+		$definition['tag']    = $this->configurator->tags[$bbcode->tagName];
+
+		return $definition;
+	}
+
+	/**
+	* Indent given template for readability
+	*
+	* @param  string $template
+	* @return string
+	*/
+	protected function indent_template($template)
+	{
+		$dom = TemplateHelper::loadTemplate($template);
+		$dom->formatOutput = true;
+		$template = TemplateHelper::saveTemplate($dom);
+
+		// Remove the first level of indentation if the template starts with whitespace
+		if (preg_match('(^\\n +)', $template, $m))
+		{
+			$template = str_replace($m[0], "\n", $template);
+		}
+
+		return trim($template);
+	}
+
+	/**
+	* Test whether the two definitions form a "content"-style BBCode
+	*
+	* Such BBCodes include the [URL] BBCode, which uses its text content as
+	* attribute if none is provided
+	*
+	* @param  array $without BBCode definition without an attribute
+	* @param  array $with    BBCode definition with an attribute
+	* @return array          Merged definition
+	*/
+	protected function is_content_bbcode(array $without, array $with)
+	{
+		// Test whether we find the same non-TEXT token between "]" and "[" in the usage
+		// as between ">" and "<" in the template
+		return (preg_match('(\\]\\s*(\\{(?!TEXT)[^}]+\\})\\s*\\[)', $without['usage'], $m)
+			&& preg_match('(>[^<]*?' . preg_quote($m[1]) . '[^>]*?<)s', $without['template']));
+	}
+
+	/**
+	* Merge the two BBCode definitions of a "content"-style BBCode
+	*
+	* @param  array $without BBCode definition without an attribute
+	* @param  array $with    BBCode definition with an attribute
+	* @return array          Merged definition
+	*/
+	protected function merge_content_bbcode(array $without, array $with)
+	{
+		// Convert [X={X}] into [X={X;useContent}]
+		$usage = preg_replace('(\\})', ';useContent}', $with['usage'], 1);
+
+		// Use the template from the definition that uses an attribute
+		$template = $with['tag']->template;
+
+		return ['usage' => $usage, 'template' => $template];
+	}
+
+	/**
+	* Merge the two BBCode definitions of a BBCode with an optional argument
+	*
+	* Such BBCodes include the [QUOTE] BBCode, which takes an optional argument
+	* but otherwise does not behave differently
+	*
+	* @param  array $without BBCode definition without an attribute
+	* @param  array $with    BBCode definition with an attribute
+	* @return array          Merged definition
+	*/
+	protected function merge_optional_bbcode(array $without, array $with)
+	{
+		// Convert [X={X}] into [X={X?}]
+		$usage = preg_replace('(\\})', '?}', $with['usage'], 1);
+
+		// Build a template for both versions
+		$template = '<xsl:choose><xsl:when test="@' . $with['bbcode']->defaultAttribute . '">' . $with['tag']->template . '</xsl:when><xsl:otherwise>' . $without['tag']->template . '</xsl:otherwise></xsl:choose>';
+
+		return ['usage' => $usage, 'template' => $template];
+	}
+
+	/**
+	* Normalize a template
+	*
+	* @param  string $template
+	* @return string
+	*/
+	protected function normalize_template($template)
+	{
+		// Normalize the template to simplify it
+		$template = $this->configurator->templateNormalizer->normalizeTemplate($template);
+
+		// Convert xsl:value-of elements back to {L_} tokens where applicable
+		$template = preg_replace('(<xsl:value-of select="\\$(L_\\w+)"/>)', '{$1}', $template);
+
+		// Beautify the template
+		$template = $this->indent_template($template);
+
+		return $template;
+	}
+}
diff --git a/phpBB/phpbb/textformatter/s9e/factory.php b/phpBB/phpbb/textformatter/s9e/factory.php
index d5ad8283d9..6191b9a315 100644
--- a/phpBB/phpbb/textformatter/s9e/factory.php
+++ b/phpBB/phpbb/textformatter/s9e/factory.php
@@ -78,7 +78,7 @@ class factory implements \phpbb\textformatter\cache_interface
 		'b'     => '[B]{TEXT}[/B]',
 		'code'  => '[CODE lang={IDENTIFIER;optional}]{TEXT}[/CODE]',
 		'color' => '[COLOR={COLOR}]{TEXT}[/COLOR]',
-		'email' => '[EMAIL={EMAIL;useContent} subject={TEXT;optional;postFilter=rawurlencode} body={TEXT;optional;postFilter=rawurlencode}]{TEXT}[/EMAIL]',
+		'email' => '[EMAIL={EMAIL;useContent} subject={TEXT1;optional;postFilter=rawurlencode} body={TEXT2;optional;postFilter=rawurlencode}]{TEXT}[/EMAIL]',
 		'flash' => '[FLASH={NUMBER1},{NUMBER2} width={NUMBER1;postFilter=#flashwidth} height={NUMBER2;postFilter=#flashheight} url={URL;useContent} /]',
 		'i'     => '[I]{TEXT}[/I]',
 		'img'   => '[IMG src={IMAGEURL;useContent}]',
@@ -132,6 +132,11 @@ class factory implements \phpbb\textformatter\cache_interface
 	protected $dispatcher;
 
 	/**
+	* @var \phpbb\log\log_interface
+	*/
+	protected $log;
+
+	/**
 	* Constructor
 	*
 	* @param \phpbb\textformatter\data_access $data_access
@@ -139,11 +144,12 @@ class factory implements \phpbb\textformatter\cache_interface
 	* @param \phpbb\event\dispatcher_interface $dispatcher
 	* @param \phpbb\config\config $config
 	* @param \phpbb\textformatter\s9e\link_helper $link_helper
+	* @param \phpbb\log\log_interface $log
 	* @param string $cache_dir          Path to the cache dir
 	* @param string $cache_key_parser   Cache key used for the parser
 	* @param string $cache_key_renderer Cache key used for the renderer
 	*/
-	public function __construct(\phpbb\textformatter\data_access $data_access, \phpbb\cache\driver\driver_interface $cache, \phpbb\event\dispatcher_interface $dispatcher, \phpbb\config\config $config, \phpbb\textformatter\s9e\link_helper $link_helper, $cache_dir, $cache_key_parser, $cache_key_renderer)
+	public function __construct(\phpbb\textformatter\data_access $data_access, \phpbb\cache\driver\driver_interface $cache, \phpbb\event\dispatcher_interface $dispatcher, \phpbb\config\config $config, \phpbb\textformatter\s9e\link_helper $link_helper, \phpbb\log\log_interface $log, $cache_dir, $cache_key_parser, $cache_key_renderer)
 	{
 		$this->link_helper = $link_helper;
 		$this->cache = $cache;
@@ -153,6 +159,7 @@ class factory implements \phpbb\textformatter\cache_interface
 		$this->config = $config;
 		$this->data_access = $data_access;
 		$this->dispatcher = $dispatcher;
+		$this->log = $log;
 	}
 
 	/**
@@ -266,12 +273,13 @@ class factory implements \phpbb\textformatter\cache_interface
 			->addParameterByName('logger')
 			->addParameterByName('max_img_height')
 			->addParameterByName('max_img_width')
-			->markAsSafeAsURL();
+			->markAsSafeAsURL()
+			->setJS('UrlFilter.filter');
 
 		// Add default BBCodes
 		foreach ($this->get_default_bbcodes($configurator) as $bbcode)
 		{
-			$configurator->BBCodes->addCustom($bbcode['usage'], $bbcode['template']);
+			$this->add_bbcode($configurator, $bbcode['usage'], $bbcode['template']);
 		}
 		if (isset($configurator->tags['QUOTE']))
 		{
@@ -298,17 +306,7 @@ class factory implements \phpbb\textformatter\cache_interface
 				},
 				$row['bbcode_tpl']
 			);
-
-			try
-			{
-				$configurator->BBCodes->addCustom($row['bbcode_match'], new UnsafeTemplate($tpl));
-			}
-			catch (\Exception $e)
-			{
-				/**
-				* @todo log an error?
-				*/
-			}
+			$this->add_bbcode($configurator, $row['bbcode_match'], $tpl);
 		}
 
 		// Load smilies
@@ -355,9 +353,15 @@ class factory implements \phpbb\textformatter\cache_interface
 		$configurator->registeredVars['max_img_width'] = 0;
 
 		// Load the Emoji plugin and modify its tag's template to obey viewsmilies
-		$configurator->Emoji->omitImageSize();
-		$configurator->Emoji->useSVG();
 		$tag = $configurator->Emoji->getTag();
+		$tag->template = '<xsl:choose>
+			<xsl:when test="@tseq">
+				<img alt="{.}" class="emoji" draggable="false" src="//twemoji.maxcdn.com/2/svg/{@tseq}.svg"/>
+			</xsl:when>
+			<xsl:otherwise>
+				<img alt="{.}" class="emoji" draggable="false" src="https://cdn.jsdelivr.net/gh/s9e/emoji-assets-twemoji@11.2/dist/svgz/{@seq}.svgz"/>
+			</xsl:otherwise>
+		</xsl:choose>';
 		$tag->template = '<xsl:choose><xsl:when test="$S_VIEWSMILIES">' . str_replace('class="emoji"', 'class="emoji smilies"', $tag->template) . '</xsl:when><xsl:otherwise><xsl:value-of select="."/></xsl:otherwise></xsl:choose>';
 
 		/**
@@ -420,6 +424,26 @@ class factory implements \phpbb\textformatter\cache_interface
 	}
 
 	/**
+	* Add a BBCode to given configurator
+	*
+	* @param  Configurator $configurator
+	* @param  string       $usage
+	* @param  string       $template
+	* @return void
+	*/
+	protected function add_bbcode(Configurator $configurator, $usage, $template)
+	{
+		try
+		{
+			$configurator->BBCodes->addCustom($usage, new UnsafeTemplate($template));
+		}
+		catch (\Exception $e)
+		{
+			$this->log->add('critical', null, null, 'LOG_BBCODE_CONFIGURATION_ERROR', false, [$usage, $e->getMessage()]);
+		}
+	}
+
+	/**
 	* Configure the Autolink / Autoemail plugins used to linkify text
 	*
 	* @param  \s9e\TextFormatter\Configurator $configurator
diff --git a/phpBB/phpbb/textformatter/s9e/link_helper.php b/phpBB/phpbb/textformatter/s9e/link_helper.php
index 0f44603dec..483794a83e 100644
--- a/phpBB/phpbb/textformatter/s9e/link_helper.php
+++ b/phpBB/phpbb/textformatter/s9e/link_helper.php
@@ -23,14 +23,16 @@ class link_helper
 	*
 	* @param  \s9e\TextFormatter\Parser\Tag $tag    LINK_TEXT tag
 	* @param  \s9e\TextFormatter\Parser     $parser Parser
-	* @return bool                                  Whether the tag is valid
+	* @return void
 	*/
 	public function cleanup_tag(\s9e\TextFormatter\Parser\Tag $tag, \s9e\TextFormatter\Parser $parser)
 	{
 		// Invalidate if the content of the tag matches the text attribute
 		$text = substr($parser->getText(), $tag->getPos(), $tag->getLen());
-
-		return ($text !== $tag->getAttribute('text'));
+		if ($text === $tag->getAttribute('text'))
+		{
+			$tag->invalidate();
+		}
 	}
 
 	/**
@@ -40,7 +42,7 @@ class link_helper
 	*
 	* @param  \s9e\TextFormatter\Parser\Tag $tag    URL tag (start tag)
 	* @param  \s9e\TextFormatter\Parser     $parser Parser
-	* @return bool                                  Always true to indicate that the tag is valid
+	* @return void
 	*/
 	public function generate_link_text_tag(\s9e\TextFormatter\Parser\Tag $tag, \s9e\TextFormatter\Parser $parser)
 	{
@@ -49,7 +51,7 @@ class link_helper
 		// the [url] BBCode when its content is used for the URL
 		if (!$tag->getEndTag() || !$this->should_shorten($tag, $parser->getText()))
 		{
-			return true;
+			return;
 		}
 
 		// Capture the text between the start tag and its end tag
@@ -58,10 +60,10 @@ class link_helper
 		$length = $end - $start;
 		$text   = substr($parser->getText(), $start, $length);
 
-		// Create a tag that consumes the link's text
-		$parser->addSelfClosingTag('LINK_TEXT', $start, $length)->setAttribute('text', $text);
-
-		return true;
+		// Create a tag that consumes the link's text and make it depends on this tag
+		$link_text_tag = $parser->addSelfClosingTag('LINK_TEXT', $start, $length);
+		$link_text_tag->setAttribute('text', $text);
+		$tag->cascadeInvalidationTo($link_text_tag);
 	}
 
 	/**
@@ -84,7 +86,7 @@ class link_helper
 	*
 	* @param  \s9e\TextFormatter\Parser\Tag $tag       LINK_TEXT tag
 	* @param  string                        $board_url Forum's root URL (with trailing slash)
-	* @return bool                                     Always true to indicate that the tag is valid
+	* @return void
 	*/
 	public function truncate_local_url(\s9e\TextFormatter\Parser\Tag $tag, $board_url)
 	{
@@ -93,15 +95,13 @@ class link_helper
 		{
 			$tag->setAttribute('text', substr($text, strlen($board_url)));
 		}
-
-		return true;
 	}
 
 	/**
 	* Truncate the replacement text set in a LINK_TEXT tag
 	*
 	* @param  \s9e\TextFormatter\Parser\Tag $tag LINK_TEXT tag
-	* @return bool                               Always true to indicate that the tag is valid
+	* @return void
 	*/
 	public function truncate_text(\s9e\TextFormatter\Parser\Tag $tag)
 	{
@@ -109,10 +109,7 @@ class link_helper
 		if (utf8_strlen($text) > 55)
 		{
 			$text = utf8_substr($text, 0, 39) . ' ... ' . utf8_substr($text, -10);
+			$tag->setAttribute('text', $text);
 		}
-
-		$tag->setAttribute('text', $text);
-
-		return true;
 	}
 }
diff --git a/phpBB/phpbb/textformatter/s9e/parser.php b/phpBB/phpbb/textformatter/s9e/parser.php
index 05ddfffa11..3698dca224 100644
--- a/phpBB/phpbb/textformatter/s9e/parser.php
+++ b/phpBB/phpbb/textformatter/s9e/parser.php
@@ -13,7 +13,7 @@
 
 namespace phpbb\textformatter\s9e;
 
-use s9e\TextFormatter\Parser\BuiltInFilters;
+use s9e\TextFormatter\Parser\AttributeFilters\UrlFilter;
 use s9e\TextFormatter\Parser\Logger;
 
 /**
@@ -196,7 +196,7 @@ class parser implements \phpbb\textformatter\parser_interface
 	public function get_errors()
 	{
 		$errors = array();
-		foreach ($this->parser->getLogger()->get() as $entry)
+		foreach ($this->parser->getLogger()->getLogs() as $entry)
 		{
 			list(, $msg, $context) = $entry;
 
@@ -365,7 +365,7 @@ class parser implements \phpbb\textformatter\parser_interface
 	static public function filter_img_url($url, array $url_config, Logger $logger, $max_height, $max_width)
 	{
 		// Validate the URL
-		$url = BuiltInFilters::filterUrl($url, $url_config, $logger);
+		$url = UrlFilter::filter($url, $url_config, $logger);
 		if ($url === false)
 		{
 			return false;