4 files changed, 95 insertions, 9 deletions
diff --git a/phpBB/includes/functions_display.php b/phpBB/includes/functions_display.php
index 77447c62f6..745eb20c77 100644
--- a/phpBB/includes/functions_display.php
+++ b/phpBB/includes/functions_display.php
@@ -649,6 +649,28 @@ function display_forums($root_data = '', $display_moderators = true, $return_mod
 		'UNAPPROVED_POST_IMG'	=> $user->img('icon_topic_unapproved', 'POSTS_UNAPPROVED_FORUM'),
 	));
 
+	/**
+	* Event to perform additional actions after the forum list has been generated
+	*
+	* @event core.display_forums_after
+	* @var	array	active_forum_ary	Array with forum data to display active topics
+	* @var	bool	display_moderators	Flag indicating if we display forum moderators
+	* @var	array	forum_moderators	Array with forum moderators list
+	* @var	array	forum_rows			Data array of all forums we display
+	* @var	bool	return_moderators	Flag indicating if moderators list should be returned
+	* @var	array	root_data			Array with the root forum data
+	* @since 3.1.0-RC5
+	*/
+	$vars = array(
+		'active_forum_ary',
+		'display_moderators',
+		'forum_moderators',
+		'forum_rows',
+		'return_moderators',
+		'root_data',
+	);
+	extract($phpbb_dispatcher->trigger_event('core.display_forums_after', compact($vars)));
+
 	if ($return_moderators)
 	{
 		return array($active_forum_ary, $forum_moderators);
diff --git a/phpBB/includes/functions_download.php b/phpBB/includes/functions_download.php
index 704939b176..fbeae50f55 100644
--- a/phpBB/includes/functions_download.php
+++ b/phpBB/includes/functions_download.php
@@ -50,7 +50,7 @@ function send_avatar_to_browser($file, $browser)
 		$image_data = @getimagesize($file_path);
 		header('Content-Type: ' . image_type_to_mime_type($image_data[2]));
 
-		if ((strpos(strtolower($user->browser), 'msie') !== false) && !phpbb_is_greater_ie_version($browser, 7))
+		if ((strpos(strtolower($browser), 'msie') !== false) && !phpbb_is_greater_ie_version($browser, 7))
 		{
 			header('Content-Disposition: attachment; ' . header_filename($file));
 
diff --git a/phpBB/phpbb/console/command/db/migrate.php b/phpBB/phpbb/console/command/db/migrate.php
index 86545c237d..c760cde5b5 100644
--- a/phpBB/phpbb/console/command/db/migrate.php
+++ b/phpBB/phpbb/console/command/db/migrate.php
@@ -55,6 +55,8 @@ class migrate extends \phpbb\console\command\command
 	{
 		$this->migrator->create_migrations_table();
 
+		$this->cache->purge();
+
 		$this->load_migrations();
 		$orig_version = $this->config['version'];
 		while (!$this->migrator->finished())
diff --git a/phpBB/phpbb/db/migration/data/v310/notifications_use_full_name.php b/phpBB/phpbb/db/migration/data/v310/notifications_use_full_name.php
index f749b32119..112c1e85e8 100644
--- a/phpBB/phpbb/db/migration/data/v310/notifications_use_full_name.php
+++ b/phpBB/phpbb/db/migration/data/v310/notifications_use_full_name.php
@@ -92,10 +92,41 @@ class notifications_use_full_name extends \phpbb\db\migration\migration
 
 		foreach ($this->notification_types as $notification_type)
 		{
-			$sql = 'UPDATE ' . NOTIFICATION_TYPES_TABLE . "
-				SET notification_type_name = 'notification.type.{$notification_type}'
-				WHERE notification_type_name = '{$notification_type}'";
-			$this->db->sql_query($sql);
+			$sql = 'SELECT notification_type_id
+				FROM ' . NOTIFICATION_TYPES_TABLE . "
+				WHERE notification_type_name = 'notification.type.{$notification_type}'";
+			$result = $this->db->sql_query($sql);
+			$new_type_id = (int) $this->db->sql_fetchfield('notification_type_id');
+			$this->db->sql_freeresult($result);
+
+			if ($new_type_id)
+			{
+				// New type name already exists,
+				// so we delete the old type and update the type id of existing entries.
+				$sql = 'SELECT notification_type_id
+					FROM ' . NOTIFICATION_TYPES_TABLE . "
+					WHERE notification_type_name = '{$notification_type}'";
+				$result = $this->db->sql_query($sql);
+				$old_type_id = (int) $this->db->sql_fetchfield('notification_type_id');
+				$this->db->sql_freeresult($result);
+
+				$sql = 'UPDATE ' . NOTIFICATIONS_TABLE . '
+					SET notification_type_id = ' . (int) $new_type_id . '
+					WHERE notification_type_id = ' . (int) $old_type_id;
+				$this->db->sql_query($sql);
+
+				$sql = 'DELETE FROM ' . NOTIFICATION_TYPES_TABLE . "
+					WHERE notification_type_name = '{$notification_type}'";
+				$this->db->sql_query($sql);
+			}
+			else
+			{
+				// Otherwise we just update the name
+				$sql = 'UPDATE ' . NOTIFICATION_TYPES_TABLE . "
+					SET notification_type_name = 'notification.type.{$notification_type}'
+					WHERE notification_type_name = '{$notification_type}'";
+				$this->db->sql_query($sql);
+			}
 
 			$sql = 'UPDATE ' . USER_NOTIFICATIONS_TABLE . "
 				SET item_type = 'notification.type.{$notification_type}'
@@ -108,10 +139,41 @@ class notifications_use_full_name extends \phpbb\db\migration\migration
 	{
 		foreach ($this->notification_types as $notification_type)
 		{
-			$sql = 'UPDATE ' . NOTIFICATION_TYPES_TABLE . "
-				SET notification_type_name = '{$notification_type}'
-				WHERE notification_type_name = 'notification.type.{$notification_type}'";
-			$this->db->sql_query($sql);
+			$sql = 'SELECT notification_type_id
+				FROM ' . NOTIFICATION_TYPES_TABLE . "
+				WHERE notification_type_name = '{$notification_type}'";
+			$result = $this->db->sql_query($sql);
+			$new_type_id = (int) $this->db->sql_fetchfield('notification_type_id');
+			$this->db->sql_freeresult($result);
+
+			if ($new_type_id)
+			{
+				// New type name already exists,
+				// so we delete the old type and update the type id of existing entries.
+				$sql = 'SELECT notification_type_id
+					FROM ' . NOTIFICATION_TYPES_TABLE . "
+					WHERE notification_type_name = 'notification.type.{$notification_type}'";
+				$result = $this->db->sql_query($sql);
+				$old_type_id = (int) $this->db->sql_fetchfield('notification_type_id');
+				$this->db->sql_freeresult($result);
+
+				$sql = 'UPDATE ' . NOTIFICATIONS_TABLE . '
+					SET notification_type_id = ' . (int) $new_type_id . '
+					WHERE notification_type_id = ' . (int) $old_type_id;
+				$this->db->sql_query($sql);
+
+				$sql = 'DELETE FROM ' . NOTIFICATION_TYPES_TABLE . "
+					WHERE notification_type_name = 'notification.type.{$notification_type}'";
+				$this->db->sql_query($sql);
+			}
+			else
+			{
+				// Otherwise we just update the name
+				$sql = 'UPDATE ' . NOTIFICATION_TYPES_TABLE . "
+					SET notification_type_name = '{$notification_type}'
+					WHERE notification_type_name = 'notification.type.{$notification_type}'";
+				$this->db->sql_query($sql);
+			}
 
 			$sql = 'UPDATE ' . USER_NOTIFICATIONS_TABLE . "
 				SET item_type = '{$notification_type}'