diff options
| -rw-r--r-- | phpBB/config/default/container/services_console.yml | 2 | ||||
| -rw-r--r-- | phpBB/phpbb/console/command/thumbnail/delete.php | 11 | ||||
| -rw-r--r-- | phpBB/phpbb/console/command/thumbnail/generate.php | 13 | ||||
| -rw-r--r-- | tests/console/thumbnail_test.php | 5 | 
4 files changed, 24 insertions, 7 deletions
diff --git a/phpBB/config/default/container/services_console.yml b/phpBB/config/default/container/services_console.yml index a327b74ac4..05e467ff8d 100644 --- a/phpBB/config/default/container/services_console.yml +++ b/phpBB/config/default/container/services_console.yml @@ -208,6 +208,7 @@ services:      console.command.thumbnail.delete:          class: phpbb\console\command\thumbnail\delete          arguments: +            - '@config'              - '@user'              - '@dbal.conn'              - '%core.root_path%' @@ -217,6 +218,7 @@ services:      console.command.thumbnail.generate:          class: phpbb\console\command\thumbnail\generate          arguments: +            - '@config'              - '@user'              - '@dbal.conn'              - '@cache' diff --git a/phpBB/phpbb/console/command/thumbnail/delete.php b/phpBB/phpbb/console/command/thumbnail/delete.php index 9f2ee822be..7b95c20cf2 100644 --- a/phpBB/phpbb/console/command/thumbnail/delete.php +++ b/phpBB/phpbb/console/command/thumbnail/delete.php @@ -19,6 +19,11 @@ use Symfony\Component\Console\Style\SymfonyStyle;  class delete extends \phpbb\console\command\command  {  	/** +	* @var \phpbb\config\config +	*/ +	protected $config; + +	/**  	* @var \phpbb\db\driver\driver_interface  	*/  	protected $db; @@ -32,12 +37,14 @@ class delete extends \phpbb\console\command\command  	/**  	* Constructor  	* +	* @param \config\config $config The config  	* @param \phpbb\user $user The user object (used to get language information)  	* @param \phpbb\db\driver\driver_interface $db Database connection  	* @param string $phpbb_root_path Root path  	*/ -	public function __construct(\phpbb\user $user, \phpbb\db\driver\driver_interface $db, $phpbb_root_path) +	public function __construct(\phpbb\config\config $config, \phpbb\user $user, \phpbb\db\driver\driver_interface $db, $phpbb_root_path)  	{ +		$this->config = $config;  		$this->db = $db;  		$this->phpbb_root_path = $phpbb_root_path; @@ -101,7 +108,7 @@ class delete extends \phpbb\console\command\command  		$return = 0;  		while ($row = $this->db->sql_fetchrow($result))  		{ -			$thumbnail_path = $this->phpbb_root_path . 'files/thumb_' . $row['physical_filename']; +			$thumbnail_path = $this->phpbb_root_path . $this->config['upload_path'] . '/thumb_' . $row['physical_filename'];  			if (@unlink($thumbnail_path))  			{ diff --git a/phpBB/phpbb/console/command/thumbnail/generate.php b/phpBB/phpbb/console/command/thumbnail/generate.php index 64f7555336..1f6582b17b 100644 --- a/phpBB/phpbb/console/command/thumbnail/generate.php +++ b/phpBB/phpbb/console/command/thumbnail/generate.php @@ -20,6 +20,11 @@ use Symfony\Component\Console\Style\SymfonyStyle;  class generate extends \phpbb\console\command\command  {  	/** +	* @var \phpbb\config\config +	*/ +	protected $config; + +	/**  	* @var \phpbb\db\driver\driver_interface  	*/  	protected $db; @@ -45,14 +50,16 @@ class generate extends \phpbb\console\command\command  	/**  	* Constructor  	* +	* @param \config\config $config The config  	* @param \phpbb\user $user The user object (used to get language information)  	* @param \phpbb\db\driver\driver_interface $db Database connection  	* @param \phpbb\cache\service $cache The cache service  	* @param string $phpbb_root_path Root path  	* @param string $php_ext PHP extension  	*/ -	public function __construct(\phpbb\user $user, \phpbb\db\driver\driver_interface $db, \phpbb\cache\service $cache, $phpbb_root_path, $php_ext) +	public function __construct(\phpbb\config\config $config, \phpbb\user $user, \phpbb\db\driver\driver_interface $db, \phpbb\cache\service $cache, $phpbb_root_path, $php_ext)  	{ +		$this->config = $config;  		$this->db = $db;  		$this->cache = $cache;  		$this->phpbb_root_path = $phpbb_root_path; @@ -126,8 +133,8 @@ class generate extends \phpbb\console\command\command  		{  			if (isset($extensions[$row['extension']]['display_cat']) && $extensions[$row['extension']]['display_cat'] == ATTACHMENT_CATEGORY_IMAGE)  			{ -				$source = $this->phpbb_root_path . 'files/' . $row['physical_filename']; -				$destination = $this->phpbb_root_path . 'files/thumb_' . $row['physical_filename']; +				$source = $this->phpbb_root_path . $this->config['upload_path'] . '/' . $row['physical_filename']; +				$destination = $this->phpbb_root_path . $this->config['upload_path'] . '/thumb_' . $row['physical_filename'];  				if (create_thumbnail($source, $destination, $row['mimetype']))  				{ diff --git a/tests/console/thumbnail_test.php b/tests/console/thumbnail_test.php index d5fbfa0fed..e425d998a2 100644 --- a/tests/console/thumbnail_test.php +++ b/tests/console/thumbnail_test.php @@ -46,6 +46,7 @@ class phpbb_console_command_thumbnail_test extends phpbb_database_test_case  		$config = $this->config = new \phpbb\config\config(array(  			'img_min_thumb_filesize' => 2,  			'img_max_thumb_width' => 2, +			'upload_path' => 'files',  		));  		$this->db = $this->db = $this->new_dbal(); @@ -63,8 +64,8 @@ class phpbb_console_command_thumbnail_test extends phpbb_database_test_case  		)));  		$this->application = new Application(); -		$this->application->add(new generate($this->user, $this->db, $this->cache, $this->phpbb_root_path, $this->phpEx)); -		$this->application->add(new delete($this->user, $this->db, $this->phpbb_root_path)); +		$this->application->add(new generate($config, $this->user, $this->db, $this->cache, $this->phpbb_root_path, $this->phpEx)); +		$this->application->add(new delete($config, $this->user, $this->db, $this->phpbb_root_path));  		$this->application->add(new recreate($this->user));  		$phpbb_filesystem = new \phpbb\filesystem\filesystem();  | 
