diff options
| author | JoshyPHP <s9e.dev@gmail.com> | 2015-05-09 19:06:48 +0200 |
|---|---|---|
| committer | JoshyPHP <s9e.dev@gmail.com> | 2015-05-30 17:26:00 +0200 |
| commit | 7a8ac4bb714299d2544ec215c24018fe07caa0ec (patch) | |
| tree | a0f76bb63b26f26237b6b7386413c8918bc36c0a | |
| parent | ae6ad754a430309796e1963684b59c01739ba4dd (diff) | |
| download | forums-7a8ac4bb714299d2544ec215c24018fe07caa0ec.tar forums-7a8ac4bb714299d2544ec215c24018fe07caa0ec.tar.gz forums-7a8ac4bb714299d2544ec215c24018fe07caa0ec.tar.bz2 forums-7a8ac4bb714299d2544ec215c24018fe07caa0ec.tar.xz forums-7a8ac4bb714299d2544ec215c24018fe07caa0ec.zip | |
[ticket/13803] Added get_max_id() tests
PHPBB3-13803
| -rw-r--r-- | phpBB/phpbb/textreparser/row_based_plugin.php | 2 | ||||
| -rw-r--r-- | tests/text_reparser/test_row_based_plugin.php | 6 |
2 files changed, 7 insertions, 1 deletions
diff --git a/phpBB/phpbb/textreparser/row_based_plugin.php b/phpBB/phpbb/textreparser/row_based_plugin.php index 6b63ffeeaf..05a6e19553 100644 --- a/phpBB/phpbb/textreparser/row_based_plugin.php +++ b/phpBB/phpbb/textreparser/row_based_plugin.php @@ -51,7 +51,7 @@ abstract class row_based_plugin extends base { $columns = $this->get_columns(); - $sql = 'SELECT MAX(' . $columns['id'] . ' AS max_id FROM ' . $this->get_table_name(); + $sql = 'SELECT MAX(' . $columns['id'] . ') AS max_id FROM ' . $this->get_table_name(); $result = $this->db->sql_query($sql); $max_id = (int) $this->db->sql_fetchfield('max_id'); $this->db->sql_freeresult($result); diff --git a/tests/text_reparser/test_row_based_plugin.php b/tests/text_reparser/test_row_based_plugin.php index 4d4d64a56d..489dff280b 100644 --- a/tests/text_reparser/test_row_based_plugin.php +++ b/tests/text_reparser/test_row_based_plugin.php @@ -32,6 +32,12 @@ abstract class phpbb_textreparser_test_row_based_plugin extends phpbb_database_t parent::setUp(); } + public function test_get_max_id() + { + $reparser = $this->get_reparser(); + $this->assertEquals(1000, $reparser->get_max_id()); + } + /** * @dataProvider getReparseTests */ |