From a60171ca78b4b601b72274f2132816ea247ca55d Mon Sep 17 00:00:00 2001
From: "lpsolit%gmail.com" <>
Date: Sat, 17 May 2008 18:59:07 +0000
Subject: =?UTF-8?q?Bug=20434062:=20Attachment=20flags=20can=20only=20be=20?=
 =?UTF-8?q?set=20once=20per=20bug=20(regression)=20-=20Patch=20by=20Fr?=
 =?UTF-8?q?=C3=83=C2=A9d=C3=83=C2=A9ric=20Buclin=20<LpSolit@gmail.com>=20a?=
 =?UTF-8?q?=3DLpSolit=20(module=20owner)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 Bugzilla/Flag.pm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

(limited to 'Bugzilla')

diff --git a/Bugzilla/Flag.pm b/Bugzilla/Flag.pm
index a65a8268b..6266b0c0c 100644
--- a/Bugzilla/Flag.pm
+++ b/Bugzilla/Flag.pm
@@ -228,12 +228,12 @@ sub match {
     # If the caller specified only bug or attachment flags,
     # limit the query to those kinds of flags.
     if (my $type = delete $criteria->{'target_type'}) {
-        if ($type eq 'attachment') {
-            $criteria->{'attach_id'} = NOT_NULL;
-        }
-        else {
+        if ($type eq 'bug') {
             $criteria->{'attach_id'} = IS_NULL;
         }
+        elsif (!defined $criteria->{'attach_id'}) {
+            $criteria->{'attach_id'} = NOT_NULL;
+        }
     }
     # Flag->snapshot() calls Flag->match() with bug_id and attach_id
     # as hash keys, even if attach_id is undefined.
-- 
cgit v1.2.1