From 648127eb7ee4ab3623af6c4d9770ea84aae2aca2 Mon Sep 17 00:00:00 2001 From: "mkanat%bugzilla.org" <> Date: Wed, 24 Dec 2008 19:08:20 +0000 Subject: Bug 347707: Changing parameters could silently fail because we weren't correctly checking the return code from "rename" Patch By Max Kanat-Alexander r=justdave, a=mkanat --- Bugzilla/Config.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Bugzilla') diff --git a/Bugzilla/Config.pm b/Bugzilla/Config.pm index 3666861f0..14f10bed9 100644 --- a/Bugzilla/Config.pm +++ b/Bugzilla/Config.pm @@ -287,7 +287,7 @@ sub write_params { close $fh; rename $tmpname, $param_file - || die "Can't rename $tmpname to $param_file: $!"; + or die "Can't rename $tmpname to $param_file: $!"; ChmodDataFile($param_file, 0666); -- cgit v1.2.1