From 84982d8b04f6232d4eaa38fde78e8bfa67d496bb Mon Sep 17 00:00:00 2001 From: Tiago Mello Date: Sun, 19 Feb 2012 15:36:22 -0200 Subject: Bug 722580: Move 'ReviewBoard' and 'Rietveld' BugUrl sub-classes to a new 'MoreBugUrl' extension. r/a=LpSolit --- Bugzilla/BugUrl/ReviewBoard.pm | 42 --------------------------------------- Bugzilla/BugUrl/Rietveld.pm | 45 ------------------------------------------ 2 files changed, 87 deletions(-) delete mode 100644 Bugzilla/BugUrl/ReviewBoard.pm delete mode 100644 Bugzilla/BugUrl/Rietveld.pm (limited to 'Bugzilla/BugUrl') diff --git a/Bugzilla/BugUrl/ReviewBoard.pm b/Bugzilla/BugUrl/ReviewBoard.pm deleted file mode 100644 index 3c1ed56ba..000000000 --- a/Bugzilla/BugUrl/ReviewBoard.pm +++ /dev/null @@ -1,42 +0,0 @@ -# This Source Code Form is subject to the terms of the Mozilla Public -# License, v. 2.0. If a copy of the MPL was not distributed with this -# file, You can obtain one at http://mozilla.org/MPL/2.0/. -# -# This Source Code Form is "Incompatible With Secondary Licenses", as -# defined by the Mozilla Public License, v. 2.0. - -package Bugzilla::BugUrl::ReviewBoard; -use strict; -use base qw(Bugzilla::BugUrl); - -############################### -#### Methods #### -############################### - -sub should_handle { - my ($class, $uri) = @_; - return ($uri->path =~ m|/r/\d+/?$|) ? 1 : 0; -} - -sub _check_value { - my $class = shift; - - my $uri = $class->SUPER::_check_value(@_); - - # Review Board URLs have only one form (the trailing slash is optional): - # http://reviews.reviewboard.org/r/111/ - - # Make sure there are no query parameters. - $uri->query(undef); - # And remove any # part if there is one. - $uri->fragment(undef); - - # make sure the trailing slash is present - if ($uri->path !~ m|/$|) { - $uri->path($uri->path . '/'); - } - - return $uri; -} - -1; diff --git a/Bugzilla/BugUrl/Rietveld.pm b/Bugzilla/BugUrl/Rietveld.pm deleted file mode 100644 index 9baf85d8d..000000000 --- a/Bugzilla/BugUrl/Rietveld.pm +++ /dev/null @@ -1,45 +0,0 @@ -# This Source Code Form is subject to the terms of the Mozilla Public -# License, v. 2.0. If a copy of the MPL was not distributed with this -# file, You can obtain one at http://mozilla.org/MPL/2.0/. -# -# This Source Code Form is "Incompatible With Secondary Licenses", as -# defined by the Mozilla Public License, v. 2.0. - -package Bugzilla::BugUrl::Rietveld; -use strict; -use base qw(Bugzilla::BugUrl); - -############################### -#### Methods #### -############################### - -sub should_handle { - my ($class, $uri) = @_; - return ($uri->authority =~ /\.appspot\.com$/i - and $uri->path =~ m#^/\d+(?:/|/show)?$#) ? 1 : 0; -} - -sub _check_value { - my ($class, $uri) = @_; - - $uri = $class->SUPER::_check_value($uri); - - # Rietveld URLs have three forms: - # http(s)://example.appspot.com/1234 - # http(s)://example.appspot.com/1234/ - # http(s)://example.appspot.com/1234/show - if ($uri->path =~ m#^/(\d+)(?:/|/show)$#) { - # This is the shortest standard URL form for Rietveld issues, - # and so we reduce all URLs to this. - $uri->path('/' . $1); - } - - # Make sure there are no query parameters. - $uri->query(undef); - # And remove any # part if there is one. - $uri->fragment(undef); - - return $uri; -} - -1; -- cgit v1.2.1