From 99cbf8f5ff129558390942a759e9d872c24012c9 Mon Sep 17 00:00:00 2001 From: "lpsolit%gmail.com" <> Date: Fri, 22 Dec 2006 04:45:41 +0000 Subject: =?UTF-8?q?Bug=2091761:=20sanitycheck.cgi=20is=20too=20broadly=20a?= =?UTF-8?q?ccessible=20-=20Patch=20by=20Fr=C3=83=C2=A9d=C3=83=C2=A9ric=20B?= =?UTF-8?q?uclin=20=20r/a=3Djustdave?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- sanitycheck.cgi | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/sanitycheck.cgi b/sanitycheck.cgi index dd9e50598..4b25fa038 100755 --- a/sanitycheck.cgi +++ b/sanitycheck.cgi @@ -79,15 +79,11 @@ my $cgi = Bugzilla->cgi; my $dbh = Bugzilla->dbh; my $template = Bugzilla->template; -# Make sure the user is authorized to access sanitycheck.cgi. Access -# is restricted to logged-in users who have "editbugs" privileges, -# which is a reasonable compromise between allowing all users to access -# the script (creating the potential for denial of service attacks) -# and restricting access to this installation's administrators (which -# prevents users with a legitimate interest in Bugzilla integrity -# from accessing the script). -Bugzilla->user->in_group("editbugs") - || ThrowUserError("auth_failure", {group => "editbugs", +# Make sure the user is authorized to access sanitycheck.cgi. +# As this script can now alter the group_control_map table, we no longer +# let users with editbugs privs run it anymore. +Bugzilla->user->in_group("editcomponents") + || ThrowUserError("auth_failure", {group => "editcomponents", action => "run", object => "sanity_check"}); -- cgit v1.2.1