From 6cae1b669d427648bf129be14d713ab63b1899da Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Buclin?= Date: Tue, 19 Aug 2014 12:34:36 +0200 Subject: Bug 1053802: Groups used for the comment_taggers_group and debug_group parameters can be deleted r=sgreen a=glob --- Bugzilla/Group.pm | 6 ++++-- editgroups.cgi | 3 --- template/en/default/admin/groups/list.html.tmpl | 3 ++- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Bugzilla/Group.pm b/Bugzilla/Group.pm index a750e353e..07b78e366 100644 --- a/Bugzilla/Group.pm +++ b/Bugzilla/Group.pm @@ -56,8 +56,10 @@ use constant UPDATE_COLUMNS => qw( ); # Parameters that are lists of groups. -use constant GROUP_PARAMS => qw(chartgroup insidergroup timetrackinggroup - querysharegroup); +use constant GROUP_PARAMS => qw( + chartgroup comment_taggers_group debug_group insidergroup + querysharegroup timetrackinggroup +); ############################### #### Accessors ###### diff --git a/editgroups.cgi b/editgroups.cgi index 2fd9f569a..9c33a0ee3 100755 --- a/editgroups.cgi +++ b/editgroups.cgi @@ -22,9 +22,6 @@ use Bugzilla::Product; use Bugzilla::User; use Bugzilla::Token; -use constant SPECIAL_GROUPS => ('chartgroup', 'insidergroup', - 'timetrackinggroup', 'querysharegroup'); - my $cgi = Bugzilla->cgi; my $dbh = Bugzilla->dbh; my $template = Bugzilla->template; diff --git a/template/en/default/admin/groups/list.html.tmpl b/template/en/default/admin/groups/list.html.tmpl index 7a15703df..29e39f65f 100644 --- a/template/en/default/admin/groups/list.html.tmpl +++ b/template/en/default/admin/groups/list.html.tmpl @@ -75,7 +75,8 @@ } %] -[% FOREACH group IN ["chartgroup", "insidergroup", "timetrackinggroup", "querysharegroup"] %] +[% FOREACH group IN ["chartgroup", "comment_taggers_group", "debug_group", + "insidergroup", "querysharegroup", "timetrackinggroup"] %] [% special_group = Param(group) %] [% IF special_group %] -- cgit v1.2.1