diff options
author | bbaetz%student.usyd.edu.au <> | 2002-03-16 14:03:09 +0000 |
---|---|---|
committer | bbaetz%student.usyd.edu.au <> | 2002-03-16 14:03:09 +0000 |
commit | 2b22c65aae9bbb3aa43dd5e4d8a813ab60ae3b0f (patch) | |
tree | f86d8180ae5d1c283a0cf2c981804b6d79d9f2ef /CGI.pl | |
parent | 9ff5677ed0e31bbd9ee290d19833d57fcea0a00d (diff) | |
download | bugs-2b22c65aae9bbb3aa43dd5e4d8a813ab60ae3b0f.tar bugs-2b22c65aae9bbb3aa43dd5e4d8a813ab60ae3b0f.tar.gz bugs-2b22c65aae9bbb3aa43dd5e4d8a813ab60ae3b0f.tar.bz2 bugs-2b22c65aae9bbb3aa43dd5e4d8a813ab60ae3b0f.tar.xz bugs-2b22c65aae9bbb3aa43dd5e4d8a813ab60ae3b0f.zip |
Bug 129466 - use IP addr (not hostname) in logincookies table
r=gerv, justdave
Diffstat (limited to 'CGI.pl')
-rw-r--r-- | CGI.pl | 12 |
1 files changed, 3 insertions, 9 deletions
@@ -695,15 +695,12 @@ sub quietly_check_login() { if (defined $::COOKIE{"Bugzilla_login"} && defined $::COOKIE{"Bugzilla_logincookie"}) { ConnectToDatabase(); - if (!defined $ENV{'REMOTE_HOST'}) { - $ENV{'REMOTE_HOST'} = $ENV{'REMOTE_ADDR'}; - } SendSQL("SELECT profiles.userid, profiles.groupset, " . "profiles.login_name, " . "profiles.login_name = " . SqlQuote($::COOKIE{"Bugzilla_login"}) . - " AND logincookies.hostname = " . - SqlQuote($ENV{"REMOTE_HOST"}) . + " AND logincookies.ipaddr = " . + SqlQuote($ENV{"REMOTE_ADDR"}) . ", profiles.disabledtext " . " FROM profiles, logincookies WHERE logincookies.cookie = " . SqlQuote($::COOKIE{"Bugzilla_logincookie"}) . @@ -988,10 +985,7 @@ sub confirm_login { # the cookies. if($enteredlogin ne "") { $::COOKIE{"Bugzilla_login"} = $enteredlogin; - if (!defined $ENV{'REMOTE_HOST'}) { - $ENV{'REMOTE_HOST'} = $ENV{'REMOTE_ADDR'}; - } - SendSQL("insert into logincookies (userid,hostname) values (@{[DBNameToIdAndCheck($enteredlogin)]}, @{[SqlQuote($ENV{'REMOTE_HOST'})]})"); + SendSQL("insert into logincookies (userid,ipaddr) values (@{[DBNameToIdAndCheck($enteredlogin)]}, @{[SqlQuote($ENV{'REMOTE_ADDR'})]})"); SendSQL("select LAST_INSERT_ID()"); my $logincookie = FetchOneColumn(); |