diff options
author | mkanat%bugzilla.org <> | 2008-10-25 04:11:30 +0000 |
---|---|---|
committer | mkanat%bugzilla.org <> | 2008-10-25 04:11:30 +0000 |
commit | 3cea91884b28b52df4e38f2ba88c00b65071a81f (patch) | |
tree | c0f451235176b2b542a38b0c935dcddf0453a1ee /Bugzilla/Object.pm | |
parent | e0da20baba17b7f068946c8647fb6d67e77c39b7 (diff) | |
download | bugs-3cea91884b28b52df4e38f2ba88c00b65071a81f.tar bugs-3cea91884b28b52df4e38f2ba88c00b65071a81f.tar.gz bugs-3cea91884b28b52df4e38f2ba88c00b65071a81f.tar.bz2 bugs-3cea91884b28b52df4e38f2ba88c00b65071a81f.tar.xz bugs-3cea91884b28b52df4e38f2ba88c00b65071a81f.zip |
Bug 291433: Ability to have custom fields whose visibility depends on the values of other fields
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=bbaetz, a=mkanat
Diffstat (limited to 'Bugzilla/Object.pm')
-rw-r--r-- | Bugzilla/Object.pm | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/Bugzilla/Object.pm b/Bugzilla/Object.pm index 1e624e5f7..53720327b 100644 --- a/Bugzilla/Object.pm +++ b/Bugzilla/Object.pm @@ -117,12 +117,10 @@ sub check { if (!ref $param) { $param = { name => $param }; } - # Don't allow empty names. - if (exists $param->{name}) { - $param->{name} = trim($param->{name}); - $param->{name} || ThrowUserError('object_name_not_specified', - { class => $class }); - } + # Don't allow empty names or ids. + my $check_param = exists $param->{id} ? $param->{id} : $param->{name}; + $check_param = trim($check_param); + $check_param || ThrowUserError('object_not_specified', { class => $class }); my $obj = $class->new($param) || ThrowUserError('object_does_not_exist', {%$param, class => $class}); return $obj; |