diff options
author | Max Kanat-Alexander <mkanat@bugzilla.org> | 2010-04-27 12:01:24 -0700 |
---|---|---|
committer | Max Kanat-Alexander <mkanat@bugzilla.org> | 2010-04-27 12:01:24 -0700 |
commit | 68af4d3c22ce1cb25793af5fb9f422bbb6ebe80e (patch) | |
tree | 1283a8a34de7cdbf7675aa05514e3289602c34d7 /Bugzilla/DB/Oracle.pm | |
parent | b7fbcf61cf1267564edaf343833fa15f1a806430 (diff) | |
download | bugs-68af4d3c22ce1cb25793af5fb9f422bbb6ebe80e.tar bugs-68af4d3c22ce1cb25793af5fb9f422bbb6ebe80e.tar.gz bugs-68af4d3c22ce1cb25793af5fb9f422bbb6ebe80e.tar.bz2 bugs-68af4d3c22ce1cb25793af5fb9f422bbb6ebe80e.tar.xz bugs-68af4d3c22ce1cb25793af5fb9f422bbb6ebe80e.zip |
Bug 561322: Make Bugzilla::DB::_connect and related functions take their
parameters as a hashref, to improve the API and to avoid exposing the
database password on error.
r=mkanat, a=mkanat (module owner)
Diffstat (limited to 'Bugzilla/DB/Oracle.pm')
-rw-r--r-- | Bugzilla/DB/Oracle.pm | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/Bugzilla/DB/Oracle.pm b/Bugzilla/DB/Oracle.pm index 5dd127882..6fa7a9869 100644 --- a/Bugzilla/DB/Oracle.pm +++ b/Bugzilla/DB/Oracle.pm @@ -54,7 +54,9 @@ use constant ISOLATION_LEVEL => 'READ COMMITTED'; use constant BLOB_TYPE => { ora_type => ORA_BLOB }; sub new { - my ($class, $user, $pass, $host, $dbname, $port) = @_; + my ($class, $params) = @_; + my ($user, $pass, $host, $dbname, $port) = + @$params{qw(db_user db_pass db_host db_name db_port)}; # You can never connect to Oracle without a DB name, # and there is no default DB. @@ -70,7 +72,8 @@ sub new { LongReadLen => ( Bugzilla->params->{'maxattachmentsize'} || 1000 ) * 1024, }; - my $self = $class->db_new($dsn, $user, $pass, $attrs); + my $self = $class->db_new({ dsn => $dsn, user => $user, + pass => $pass, attrs => $attrs }); # Needed by TheSchwartz $self->{private_bz_dsn} = $dsn; |