diff options
author | Simon Green <sgreen@redhat.com> | 2014-10-06 14:49:38 +0000 |
---|---|---|
committer | David Lawrence <dkl@mozilla.com> | 2014-10-06 14:49:38 +0000 |
commit | fa954ab78cc60aba43aedb85e2b4f98d56d7bf9d (patch) | |
tree | 01b1eeaeeecd240a743cb280e2dbf101ad2aac37 /Bugzilla/Bug.pm | |
parent | f33b119d68d21074d08a6bd72f960319276e182b (diff) | |
download | bugs-fa954ab78cc60aba43aedb85e2b4f98d56d7bf9d.tar bugs-fa954ab78cc60aba43aedb85e2b4f98d56d7bf9d.tar.gz bugs-fa954ab78cc60aba43aedb85e2b4f98d56d7bf9d.tar.bz2 bugs-fa954ab78cc60aba43aedb85e2b4f98d56d7bf9d.tar.xz bugs-fa954ab78cc60aba43aedb85e2b4f98d56d7bf9d.zip |
Bug 1064140: [SECURITY] Private comments can be shown to flagmail recipients who aren't in the insider group
r=glob,a=glob
Diffstat (limited to 'Bugzilla/Bug.pm')
-rw-r--r-- | Bugzilla/Bug.pm | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm index a92a7077b..aa5085fe7 100644 --- a/Bugzilla/Bug.pm +++ b/Bugzilla/Bug.pm @@ -1030,12 +1030,6 @@ sub update { join(', ', @added_names)]; } - # Flags - my ($removed, $added) = Bugzilla::Flag->update_flags($self, $old_bug, $delta_ts); - if ($removed || $added) { - $changes->{'flagtypes.name'} = [$removed, $added]; - } - # Comments foreach my $comment (@{$self->{added_comments} || []}) { # Override the Comment's timestamp to be identical to the update @@ -1058,6 +1052,9 @@ sub update { $user->id, $delta_ts, $comment->id); } + # Clear the cache of comments + delete $self->{comments}; + # Insert the values into the multiselect value tables my @multi_selects = grep {$_->type == FIELD_TYPE_MULTI_SELECT} Bugzilla->active_custom_fields; @@ -1090,6 +1087,12 @@ sub update { join(', ', map { $_->name } @$added_see)]; } + # Flags + my ($removed, $added) = Bugzilla::Flag->update_flags($self, $old_bug, $delta_ts); + if ($removed || $added) { + $changes->{'flagtypes.name'} = [$removed, $added]; + } + $_->update foreach @{ $self->{_update_ref_bugs} || [] }; delete $self->{_update_ref_bugs}; |