[Mageia-dev] NEED REVIEW: drakdisk refresh feature

Mon Nov 12 01:24:55 CET 2012

Op maandag 15 oktober 2012 23:25:08 schreef AL13N:
+[...]
+> -> actively look for new devices (or size-changed devices) and handle those;
+> and thus not change all the changes you've made already.
+> 
+> The point of this is more like stepping stone towards the real things: ie:
+> not aborting if there are no disks. and later adding installable
+> network-based disks (for diskless systems).
+> 
+> And also, if your one of your hotplugged disks isn't correctly in it, i'd
+> like to refresh it, so the 4th one is detected and so i can add it to the
+> raid, for instance. instead of exiting the installer, etc...
+> 
+> in any case, it seems like someone found that it showed gray for a all
+> disks, so it might not be that good after all...
+> 
+> but it would be nice for me though if i could pick your brain about the code
+> and the way of programming though... it's not always easy to get around
+> this kind of code.
+> 
+> Can i ask you in the future to look at this from time to time?
+[...]
+
+Ok, so this is a new patch; this time, it's next to the toggle for expert 
+button.
+
+I do a new device check, in a separate variable and check with device file as 
+unique; if there's one that isn't in the old list. (or if it's changed size). 
+in that case i put the new entry into the old list.
+
+however, it seems that a VM shuts itself off on executing the check when a new 
+USB disk was added. :-(
+
+Maybe i'm doing some fundamentals wrong, so i'm asking here if anyone has an 
+insight, idea or direction i should go to instead.
+
+i'm thinking because i only do 1 of the 5 preparation checks for new disks, 
+that maybe not everything is done correctly yet: but a halting VM is not 
+exactly what i expected...
+
+AL13N
+-------------- next part --------------
+A non-text attachment was scrubbed...
+Name: drakdisk_refresh-2012-11-11.patch
+Type: text/x-patch
+Size: 1848 bytes
+Desc: not available
+URL: </pipermail/mageia-dev/attachments/20121112/557570ea/attachment.bin>
+