[Mageia-dev] [soft-commits] [6416] Initial commit of Admin Panel.

Tue Nov 6 20:55:01 CET 2012

Le 06/11/2012 16:33, Matteo Pasotti a écrit :
+> -----BEGIN PGP SIGNED MESSAGE-----
+> Hash: SHA1
+>
+> On 06/11/2012 13:16, Guillaume Rousse wrote:
+>> information in every single file, whereas a single top-level README
+>> file would be enough.
+>>
+> Hello Guillaume,
+>
+> GPLv2 says:
+> It is safest to attach them to the start of each source file to most
+> effectively convey the exclusion of warranty; and each file should
+> have at least the "copyright" line and a pointer to where the full
+> notice is found.
+>
+> http://www.gnu.org/licenses/gpl-2.0.html
+Come on, you really think someone will sue you because running your code 
+crashed his system, and you have to be that "safe" ? It's a pain to have 
+to skip multiple lines of legal bullshit before reaching the code, and 
+you'll need to update a gazillion files in just a few monthes because 
+we'll change year.
+
+[..]
+>>> +use Data::Dumper;
+>> Unused anywere. Don't load debug-related modules in production
+>> coed.
+>>
+> afaik, apanel is not "in production" so what's your concern?.
+Don't bloat memory by loading unused modules. Keep your debug code in 
+your working directory, not in svn.
+
+[..]
+>>> + +sub ask_for_authentication { +    my @args = @ARGV; +    my
+>>> $command = wrap_command($0); +    unshift(@args, $command->[2]);
+>>> +    exec { $command->[0] } $command->[1], @args or die ("command
+>>> %s missing", $command->[0]); +    die "You must be root to run
+>>> this program" if $>; +}
+>> You're duplicating the condition from previous function here. die
+>> "You must be root to run this program" if
+>> !require_root_capability();
+>>
+> Don't blame me too much for readability and duplications, please.
+> I was inspired by /usr/lib/libDrakX/common.pm and other modules that
+> are not very readable and that contain similar duplications.
+I wouldn't consider drakxtools a reference for readability...
+
+-- 
+BOFH excuse #23:
+
+improperly oriented keyboard
+