From edd0ffaff6022cb6ce29bd6a6e76c1d1518725b7 Mon Sep 17 00:00:00 2001 From: Thierry Vignaud Date: Tue, 20 Mar 2012 19:52:28 +0000 Subject: perl_checker cleanups --- Rpmdrake/gui.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Rpmdrake/gui.pm b/Rpmdrake/gui.pm index 6a4dc745..4962a586 100644 --- a/Rpmdrake/gui.pm +++ b/Rpmdrake/gui.pm @@ -401,7 +401,7 @@ my ($common, $w, %wtree, %ptree, %pix); sub set_node_state { my ($iter, $state, $model) = @_; - ($state eq 'XXX' || !$state) and return; + return if $state eq 'XXX' || !$state; $pix{$state} ||= gtkcreate_pixbuf('state_' . $state); $model->set($iter, $pkg_columns{state_icon} => $pix{$state}); $model->set($iter, $pkg_columns{state} => $state); @@ -638,7 +638,7 @@ sub pkgs_provider { ); my %tmp_filter_methods = ( all => sub { - [ difference2([ keys %$pkgs ], $h->{inactive_backports}) ] + [ difference2([ keys %$pkgs ], $h->{inactive_backports}) ]; }, all_updates => sub { # potential "updates" from media not tagged as updates: @@ -651,10 +651,10 @@ sub pkgs_provider { }, backports => sub { $h->{backports} }, meta_pkgs => sub { - [ difference2($h->{meta_pkgs}, $h->{inactive_backports}) ] + [ difference2($h->{meta_pkgs}, $h->{inactive_backports}) ]; }, gui_pkgs => sub { - [ difference2($h->{gui_pkgs}, $h->{inactive_backports}) ] + [ difference2($h->{gui_pkgs}, $h->{inactive_backports}) ]; }, ); foreach my $importance (qw(bugfix security normal)) { -- cgit v1.2.1