From 62351b2809381dfc0f3baf7044b84f7f9971236f Mon Sep 17 00:00:00 2001
From: Thierry Vignaud <tv@mandriva.org>
Date: Mon, 25 Feb 2008 19:20:25 +0000
Subject: (is_updatable) split it out of pkgs_provider() for readability

---
 Rpmdrake/gui.pm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/Rpmdrake/gui.pm b/Rpmdrake/gui.pm
index e32048cd..2b494110 100644
--- a/Rpmdrake/gui.pm
+++ b/Rpmdrake/gui.pm
@@ -478,6 +478,11 @@ sub switch_pkg_list_mode {
     $filter_methods{$mode}->();
 }
 
+sub is_updatable {
+    my $p = $pkgs->{$_[0]};
+    $p->{pkg} && !$p->{selected} && $p->{pkg}->flag_installed && $p->{pkg}->flag_upgrade;
+}
+
 sub pkgs_provider {
     my ($options, $mode, %options) = @_;
     return if !$mode;
@@ -489,7 +494,8 @@ sub pkgs_provider {
         installed => sub { @filtered_pkgs = @{$h->{installed}} },
         non_installed => sub { @filtered_pkgs = @{$h->{installable}} },
         all_updates => sub {
-            my @pkgs = $options{pure_updates} ? () : (grep { my $p = $pkgs->{$_}; $p->{pkg} && !$p->{selected} && $p->{pkg}->flag_installed && $p->{pkg}->flag_upgrade } @{$h->{installable}});
+            my @pkgs = $options{pure_updates} ? () :
+              (grep { is_updatable($_) } @{$h->{installable}});
             @filtered_pkgs = @{$h->{updates}}, @pkgs;
         },
         backports => sub { @filtered_pkgs = @{$h->{backports}} },
-- 
cgit v1.2.1