From 4676e0c59f32e2224fb7365a413e34e6f6519922 Mon Sep 17 00:00:00 2001
From: Thierry Vignaud <tv@mandriva.org>
Date: Wed, 18 Mar 2009 15:09:06 +0000
Subject: (run_treeview_dialog) do not harcode column id and fix it (in
 'toggled' signal handler too) ;

this means we got the right cell renderer and thus the 'toggled'
signal handler does be connected ;

this means we stop ignoring selected/unselected packages (embarassing
bug #29835)

(this regression was introduced in r242980 on 2008-06-18:
"(refresh_packages_list, run_treeview_dialog) show type of update in
mandrivaupdate: fix, security, ... (spec 216)")
---
 MandrivaUpdate | 4 ++--
 NEWS           | 5 +++++
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/MandrivaUpdate b/MandrivaUpdate
index e84ecb90..65d8b43b 100755
--- a/MandrivaUpdate
+++ b/MandrivaUpdate
@@ -212,7 +212,7 @@ sub run_treeview_dialog {
 
 
     $list->set_rules_hint(1);
-    my $bool_col = $list->get_column(0);
+    my $bool_col = $list->get_column($pkg_columns{selected});
     $bool_col->set_fixed_width(24);
     $bool_col->set_sizing('fixed');
     $bool_col->set_sort_column_id($pkg_columns{selected});
@@ -259,7 +259,7 @@ sub run_treeview_dialog {
     my $cell = ($bool_col->get_cell_renderers)[0];
     $cell->signal_connect(toggled => sub {
 	my ($_cell, $text_path) = @_;
-	my ($_val, $name) = @{$list->{data}[$text_path]};
+	my $name = @{$list->{data}[$text_path]}[$pkg_columns{text}];
 	gtkset_mousecursor_wait($w->{real_window}->window);
 	my $_guard = before_leaving(sub { gtkset_mousecursor_normal($w->{real_window}->window) });
 	toggle($list, $name);
diff --git a/NEWS b/NEWS
index f720e484..decb406b 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,8 @@
+- MandrivaUpdate:
+  o fix ignoring selected/unselected packages (embarassing bug #29835)
+    (regression introduced in 4.10 on 24 June 2008: "show type of
+    update in mandrivaupdate (fix, security, ...)")
+
 Version 5.9 - 23 February 2009, Thierry Vignaud
 
 - rpmdrake:
-- 
cgit v1.2.1