diff options
| author | Thierry Vignaud <tv@mageia.org> | 2012-09-21 16:15:57 +0000 |
|---|---|---|
| committer | Thierry Vignaud <tv@mageia.org> | 2012-09-21 16:15:57 +0000 |
| commit | 2292feb7bc25dafe8794b2cde71c733b28ab07a2 (patch) | |
| tree | 2066b5557373989400fdc692e3fe8b06c3a621ac | |
| parent | d8b8fdb5e7448fa36e71a8c57b8f7e23fbdeb4de (diff) | |
| download | rpmdrake-2292feb7bc25dafe8794b2cde71c733b28ab07a2.tar rpmdrake-2292feb7bc25dafe8794b2cde71c733b28ab07a2.tar.gz rpmdrake-2292feb7bc25dafe8794b2cde71c733b28ab07a2.tar.bz2 rpmdrake-2292feb7bc25dafe8794b2cde71c733b28ab07a2.tar.xz rpmdrake-2292feb7bc25dafe8794b2cde71c733b28ab07a2.zip | |
(extract_header) only call costly ->files method once
(backported from trunk)
| -rw-r--r-- | Rpmdrake/pkg.pm | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/Rpmdrake/pkg.pm b/Rpmdrake/pkg.pm index ee7e78a7..11c97b1e 100644 --- a/Rpmdrake/pkg.pm +++ b/Rpmdrake/pkg.pm @@ -158,8 +158,10 @@ sub extract_header { warn "Warning, could not extract header for $name from $medium!"; goto header_non_available; }; + my @files = $p->files; + @files = N("(none)") if !@files; add2hash($pkg, { description => rpm_description($p->description), - files => scalar($p->files) ? [ $p->files ] : [ N("(none)") ], + files => \@files, url => $p->url, changelog => format_changelog_changelogs($o_installed_version, $p->changelogs) }); $p->pack_header; # needed in order to call methods on objects outside ->traverse |