diff options
author | Thierry Vignaud <tv@mageia.org> | 2012-09-27 17:18:52 +0000 |
---|---|---|
committer | Thierry Vignaud <tv@mageia.org> | 2012-09-27 17:18:52 +0000 |
commit | 0aaa6cc55802b0ccd0d923bdc862851fdcd41b65 (patch) | |
tree | 66f628e258eebb67a1c51271587f4d8ce8d51be2 | |
parent | 1f9167357fc2ac2ec04a54e80851cf441d8255c9 (diff) | |
download | rpmdrake-0aaa6cc55802b0ccd0d923bdc862851fdcd41b65.tar rpmdrake-0aaa6cc55802b0ccd0d923bdc862851fdcd41b65.tar.gz rpmdrake-0aaa6cc55802b0ccd0d923bdc862851fdcd41b65.tar.bz2 rpmdrake-0aaa6cc55802b0ccd0d923bdc862851fdcd41b65.tar.xz rpmdrake-0aaa6cc55802b0ccd0d923bdc862851fdcd41b65.zip |
do not store {selected} in memory if not needed
-rwxr-xr-x | MageiaUpdate | 2 | ||||
-rw-r--r-- | Rpmdrake/gui.pm | 2 | ||||
-rw-r--r-- | Rpmdrake/pkg.pm | 2 | ||||
-rwxr-xr-x | rpmdrake | 4 |
4 files changed, 5 insertions, 5 deletions
diff --git a/MageiaUpdate b/MageiaUpdate index 5358a7c4..dea9090b 100755 --- a/MageiaUpdate +++ b/MageiaUpdate @@ -77,7 +77,7 @@ sub refresh_packages_list { # don't select packages in skip list: if (!$initialized) { - $pkgs->{$_}{selected} = 0 foreach @requested; + undef $pkgs->{$_}{selected} foreach @requested; my @selectable = grep { !$pkgs->{$_}{pkg}->flag_skip } @requested; toggle($list, @selectable) if @selectable; $initialized = 1; diff --git a/Rpmdrake/gui.pm b/Rpmdrake/gui.pm index 9dcb3bf4..34c65b1f 100644 --- a/Rpmdrake/gui.pm +++ b/Rpmdrake/gui.pm @@ -875,7 +875,7 @@ sub toggle_nodes { #- not upgradable (older than what currently installed) exists $pkgs->{$_} or next; if (!$pkgs->{$_}{pkg}) { #- can't be removed # FIXME; what about next packages in the loop? - $pkgs->{$_}{selected} = 0; + undef $pkgs->{$_}{selected}; log::explanations("can't be removed: $_"); } else { $pkgs->{$_}{selected} = $new_state; diff --git a/Rpmdrake/pkg.pm b/Rpmdrake/pkg.pm index ac136116..3a474b65 100644 --- a/Rpmdrake/pkg.pm +++ b/Rpmdrake/pkg.pm @@ -353,7 +353,7 @@ sub get_installed_packages { my $fullname = urpm_name($pkg); return if $fullname =~ /@/; $all_pkgs->{$fullname} = { - selected => 0, pkg => $pkg, urpm_name => $fullname, + pkg => $pkg, urpm_name => $fullname, } if !($all_pkgs->{$fullname} && $all_pkgs->{$fullname}{description}); if (my $name = $base{$fullname}) { $all_pkgs->{$fullname}{base} = \$name; @@ -560,7 +560,7 @@ sub run_treeview_dialog { map { if_($pkgs->{$_}{selected}, $pkgs->{$_}{pkg}) } keys %$pkgs, ); } - $pkgs->{$_}{selected} = 0 foreach keys %$pkgs; + undef $pkgs->{$_}{selected} foreach keys %$pkgs; reset_search(); $size_selected = 0; $force_displaying_group = 1; @@ -766,7 +766,7 @@ sub run_treeview_dialog { slow_func($::main_window->window, sub { pkgs_provider($default_list_mode) }); # default mode if (@initial_selection) { $options->{initial_selection} = \@initial_selection; - $pkgs->{$_}{selected} = 0 foreach @initial_selection; + undef $pkgs->{$_}{selected} foreach @initial_selection; } $w->{rwindow}->set_sensitive(1); |