(build_tree) restore sorting packages in 'by_group' view ; regression

introduced in r239885 on 2008-03-17:

"(build_tree,run_treeview_dialog) do the sort when filling in the tree
in "by_group" mode rather than setting it as a tree propriety (needed
before resurecting flat mode)"

2 files changed, 4 insertions, 2 deletions

diff --git a/NEWS b/NEWS
index e4bbd701..da3a5720 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,7 @@
 - rpmdrake:
   o handle migrating config file from rpmdrake <= 4.9
+  o restore sorting packages in 'by_group' view
+    (regression introduced in 4.8 while restoring flat mode)
 
 Version 4.9.3 - 17 March 2008, Thierry Vignaud
 
diff --git a/Rpmdrake/gui.pm b/Rpmdrake/gui.pm
index 9f57701e..0ee60667 100644
--- a/Rpmdrake/gui.pm
+++ b/Rpmdrake/gui.pm
@@ -833,7 +833,7 @@ or you already installed all of them."));
                 $explanation_only_once = 1;
             }
         }
-        @elems = map { [ $_, !$flat && ctreefy($pkgs->{$_}{pkg}->group) ] } @keys;
+        @elems = map { [ $_, !$flat && ctreefy($pkgs->{$_}{pkg}->group) ] } sort @keys;
     }
     my %sortmethods = (
         by_size => sub { sort { $pkgs->{$b->[0]}{pkg}->size <=> $pkgs->{$a->[0]}{pkg}->size } @_ },
@@ -865,7 +865,7 @@ or you already installed all of them."));
             #- we populate all the groups tree at first
             %$elems = ();
             # better loop on packages, create groups tree and push packages in the proper place:
-            foreach my $pkg (sort @elems) {
+            foreach my $pkg (@elems) {
                 my $grp = $pkg->[1];
                 add_parent($grp);
                 $elems->{$grp} ||= [];