From 39ca63c4b4c3fc3fc6b92cdb79dc92dce155adc8 Mon Sep 17 00:00:00 2001 From: Thierry Vignaud Date: Tue, 7 Jan 2020 14:06:55 +0100 Subject: skip tests if we have no supported downloader as seen in CPAN reports: <<< ...retrieving failed: no webfetch found, supported webfetch are: curl, wget, prozilla, aria2 no metadata found for medium "various" >>> Whic results in: <<< Test Summary Report ------------------- t/superuser--http.t (Wstat: 2560 Tests: 11 Failed: 10) Failed tests: 2-11 Non-zero exit status: 10 Files=40, Tests=3775, 953 wallclock secs ( 1.19 usr 0.08 sys + 309.33 cusr 52.13 csys = 362.73 CPU) Result: FAIL Failed 1/40 test programs. 10/3775 subtests failed. make: *** [Makefile:1155: test_dynamic] Error 255 (/usr/bin/make test exited with 512) CPAN::Reporter: Test result is 'fail', One or more tests failed. >>> And indeed: $ rpm -q curl wget prozilla aria2 package curl is not installed package wget is not installed package prozilla is not installed package aria2 is not installed Should have been done in commit 360f05b8db2029cb62c11f7eddb7fb57f3b774f1 --- NEWS | 3 +++ t/superuser--http.t | 3 +++ 2 files changed, 6 insertions(+) diff --git a/NEWS b/NEWS index 4e41a4ad..cd6f0fd2 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +- cpan_testers: + o skip tests if we have no supported downloader + Version 8.120 - 21 October 2019 - fix test for whether any 32-bit packages are installed diff --git a/t/superuser--http.t b/t/superuser--http.t index 15f0694a..297e7c69 100644 --- a/t/superuser--http.t +++ b/t/superuser--http.t @@ -8,6 +8,9 @@ use Cwd 'getcwd'; need_root_and_prepare(); + +need_downloader(); + my $url = start_httpd(); my $name = 'various'; -- cgit v1.2.1