summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--NEWS1
-rw-r--r--urpm/install.pm3
2 files changed, 3 insertions, 1 deletions
diff --git a/NEWS b/NEWS
index 50b0dba9..dfbc36de 100644
--- a/NEWS
+++ b/NEWS
@@ -1,4 +1,5 @@
- explicitely close the RPM DB after each transaction
+- fix circular dependency that defeats perl's GC
- warn if --allow-force, --allow-nodeps, --force or --keep is in use (mga#3127)
Version 6.45 - 27 February 2012
diff --git a/urpm/install.pm b/urpm/install.pm
index fc30b847..3dd97302 100644
--- a/urpm/install.pm
+++ b/urpm/install.pm
@@ -222,6 +222,7 @@ sub install {
$urpm->{readmes} = {};
my $index;
my $fh;
+ my $is_test = $options{test}; # fix circular reference
#- assume default value for some parameter.
$options{delta} ||= 1000;
@@ -239,7 +240,7 @@ sub install {
my ($urpm, undef, $pkgid) = @_;
return unless defined $pkgid;
$callback_close_helper and $callback_close_helper->($db, @_);
- get_README_files($urpm, $trans, $urpm->{depslist}[$pkgid]) if !$options{test};
+ get_README_files($urpm, $trans, $urpm->{depslist}[$pkgid]) if !$is_test;
close $fh if defined $fh;
};
#- ensure perl does not create a circular reference below, otherwise all this won't be collected,