From 57c70584abaa14f93fcf104e4b83d9821bfd5995 Mon Sep 17 00:00:00 2001 From: Olivier Thauvin Date: Fri, 30 Jul 2010 00:55:59 +0000 Subject: - enable 'use warnings' - fix some warnings --- URPM.pm | 1 + URPM/Build.pm | 1 + URPM/Query.pm | 1 + URPM/Resolve.pm | 4 +++- URPM/Signature.pm | 1 + 5 files changed, 7 insertions(+), 1 deletion(-) diff --git a/URPM.pm b/URPM.pm index e7d5518..72278a1 100644 --- a/URPM.pm +++ b/URPM.pm @@ -1,6 +1,7 @@ package URPM; use strict; +use warnings; use DynaLoader; # different files, but same package diff --git a/URPM/Build.pm b/URPM/Build.pm index 18f3faee..042e4c9 100644 --- a/URPM/Build.pm +++ b/URPM/Build.pm @@ -3,6 +3,7 @@ package URPM; # $Id$ use strict; +use warnings; sub _get_tmp_dir () { my $t = $ENV{TMPDIR}; diff --git a/URPM/Query.pm b/URPM/Query.pm index 5b62f11..6f58552 100644 --- a/URPM/Query.pm +++ b/URPM/Query.pm @@ -1,6 +1,7 @@ package URPM; use strict; +use warnings; # Olivier Thauvin # This package extend URPM functions to permit diff --git a/URPM/Resolve.pm b/URPM/Resolve.pm index 7e38db8..4090313 100644 --- a/URPM/Resolve.pm +++ b/URPM/Resolve.pm @@ -5,6 +5,7 @@ package URPM; # $Id$ use strict; +use warnings; use Config; @@ -435,7 +436,8 @@ sub _choose_required { sub pkg2media { my ($mediums, $p) = @_; my $id = $p->id; - find { $id >= $_->{start} && $id <= $_->{end} } @$mediums; + #- || 0 to avoid undef, but is it normal to have undef ? + find { $id >= ($_->{start} || 0) && $id <= ($_->{end} || 0) } @$mediums; } sub whatrequires { diff --git a/URPM/Signature.pm b/URPM/Signature.pm index 0c2eda0..b050f91 100644 --- a/URPM/Signature.pm +++ b/URPM/Signature.pm @@ -1,6 +1,7 @@ package URPM; use strict; +use warnings; #- parse from rpmlib db. #- -- cgit v1.2.1