From 2f99457c2fbd8cad7ddb77ae4063e4e79b67e561 Mon Sep 17 00:00:00 2001 From: Thierry Vignaud Date: Thu, 5 Oct 2017 12:16:23 +0200 Subject: Revert "fix segfault when checking invalid signatures" This reverts commit 87dbde4f3b078173e53cd45cac000c2d2751b370. Rationale: rpm got fixed We could just initialize header to NULL but rpmReadPackageFile() is supposed to always set a correct value, so keep as it in order to catch another future perl regression --- NEWS | 3 +++ URPM.xs | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index feb794e..64253d4 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +- revert fix for segfault with rpm-4.14 when checking invalid signatures as rpm + got fixed + Version 5.15 - 3 October 2017 - testsuite: diff --git a/URPM.xs b/URPM.xs index cf2eac6..8926770 100644 --- a/URPM.xs +++ b/URPM.xs @@ -3136,7 +3136,7 @@ Urpm_verify_signature(filename, prefix=NULL) char result[1024]; rpmRC rc; FD_t fd; - Header h = headerNew(); + Header h; CODE: fd = Fopen(filename, "r"); if (fd == NULL) -- cgit v1.2.1