there is no use retrying after a headerRead failure since headerRead may have

consumed part of the input, and so next headerRead will read in the middle of
a header, and so always fail. The only real solution is to ensure rpmlib don't
timeout too quickly (and fd->rd_timeoutsecs is rpmlib internal only, so we
can't hint it from here. in any case 1sec timeout is really too low)

1 files changed, 0 insertions, 14 deletions

diff --git a/URPM.xs b/URPM.xs
index 1ec5eb4..04e9502 100644
--- a/URPM.xs
+++ b/URPM.xs
@@ -3322,21 +3322,7 @@ Urpm_parse_hdlist__XS(urpm, filename, ...)
 
 	PUTBACK;
 	do {
-	  int count = 4;
 	  header=headerRead(fd, HEADER_MAGIC_YES);
-	  while (header == NULL && count > 0) {
-	    fd_set readfds;
-	    struct timeval timeout;
-
-	    FD_ZERO(&readfds);
-	    FD_SET(fdFileno(fd), &readfds);
-	    timeout.tv_sec = 1;
-	    timeout.tv_usec = 0;
-	    select(fdFileno(fd)+1, &readfds, NULL, NULL, &timeout);
-
-	    header=headerRead(fd, HEADER_MAGIC_YES);
-	    --count;
-	  }
 	  if (header != NULL) {
 	    struct s_Package pkg, *_pkg;
 	    SV *sv_pkg;