aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThierry Vignaud <thierry.vignaud@gmail.com>2014-05-17 21:30:20 +0200
committerThierry Vignaud <thierry.vignaud@gmail.com>2014-05-17 21:53:01 +0200
commit4b19e5f345e39ed8c3350e6acc7179d26c6e4526 (patch)
tree22e20907a626c141cbcf0f4d3dbc0174b9ec19ce
parentd9edf243aeba4a33fe2d9dc68dcb4d2bdf2d5730 (diff)
downloadperl-URPM-4b19e5f345e39ed8c3350e6acc7179d26c6e4526.tar
perl-URPM-4b19e5f345e39ed8c3350e6acc7179d26c6e4526.tar.gz
perl-URPM-4b19e5f345e39ed8c3350e6acc7179d26c6e4526.tar.bz2
perl-URPM-4b19e5f345e39ed8c3350e6acc7179d26c6e4526.tar.xz
perl-URPM-4b19e5f345e39ed8c3350e6acc7179d26c6e4526.zip
(compare) croak if used on URPM::Package object (mga#12766)
suggests to use compare_pkg instead (needs a new rpmdrake)
-rw-r--r--NEWS1
-rw-r--r--URPM.xs2
2 files changed, 3 insertions, 0 deletions
diff --git a/NEWS b/NEWS
index 8662f51..d7af4a2 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,4 @@
+- compare(): croak if used on URPM::Package object (mga#12766)
- enhanced doc
- kill support for kernel-*source-stripped
diff --git a/URPM.xs b/URPM.xs
index b1c3f72..50091a8 100644
--- a/URPM.xs
+++ b/URPM.xs
@@ -1711,6 +1711,8 @@ Pkg_compare(pkg, evr)
croak("undefined package");
char *epoch = NULL, *version, *release;
+ if (!strncmp(evr, "URPM::Package=", 14))
+ croak("compare() must not be called with a package reference as argument; use compare_pkg() instead");
/* extract epoch and version from evr */
version = evr;