make it compatible with rpm-4.12.0

rpm-4.12.0 introduces a new weak deps implementation (the 3rd one to be
used in mdv/mga!)

The tag we used to use (RPMTAG_SUGGESTSNAME) is now OLDSUGGESTSNAME
=> we need to handle both old & new tags

Hopefully rpm-4.12.x enables to check both old & new tags when using
xxxNVRS variants

We thus have a choice between RECOMMEND & SUGGEST tags, that both
fallback on older SUGGESTS tags if no new ones are found.
The difference is that they filter old suggests depending on
RPMSENSE_STRONG hint.

As we used suggests in the recommends role, this is the perfect time to
switch from suggests to recommends
(with a patch on rpm in order to fallback RECOMMEND on weak (old)
SUGGESTS instead of on strong (old) ENHANCES as we didn't used the later
in mga)

Our rpm is patched so that RECOMMENDNAME fallbacks too.
In Suse, only RECOMMENDNEVRS is the only RECOMMEND variant that handle
the fallback on old tags.
However, using RPMTAG_RECOMMENDNEVRS makes URPM->suggest_nosense to
return versionated suggests, which while not supported by urpmi, do are
used by a couple packages (such as git or gnome-user-share)

This breaks urpmi as suggests on "foo >= x.y" is not interpreted by
urpmi which thinks that "foo" is a new suggests and reinstalls a
previously removed suggests
Hence we patched rpm.

2 files changed, 5 insertions, 2 deletions

diff --git a/NEWS b/NEWS
index cf1f639..324d067 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+- make it compatible with rpm-4.12.0
+- use new recommends tags instead of suggests ones
+
 Version 4.31 - 27 June 2014
 
 - compare(): croak if used on URPM::Package object (mga#12766)
diff --git a/URPM.xs b/URPM.xs
index b90404e..46fc2a9 100644
--- a/URPM.xs
+++ b/URPM.xs
@@ -764,7 +764,7 @@ pack_header(const URPM__Package pkg) {
     if (pkg->requires == NULL)
       pkg->requires = pack_list(pkg->h, RPMTAG_REQUIRENAME, RPMTAG_REQUIREFLAGS, RPMTAG_REQUIREVERSION);
     if (pkg->suggests == NULL)
-      pkg->suggests = pack_list(pkg->h, RPMTAG_SUGGESTSNAME, 0, 0);
+      pkg->suggests = pack_list(pkg->h, RPMTAG_RECOMMENDNAME, 0, 0);
     if (pkg->obsoletes == NULL)
       pkg->obsoletes = pack_list(pkg->h, RPMTAG_OBSOLETENAME, RPMTAG_OBSOLETEFLAGS, RPMTAG_OBSOLETEVERSION);
     if (pkg->conflicts == NULL)
@@ -1871,7 +1871,7 @@ Pkg_obsoletes_nosense(pkg)
   case 1:  tag = RPMTAG_CONFLICTNAME; s = pkg->conflicts; break;
   case 2:  tag = RPMTAG_PROVIDENAME;  s = pkg->provides;  break;
   case 3:  tag = RPMTAG_REQUIRENAME;  s = pkg->requires;  break;
-  case 4:  tag = RPMTAG_SUGGESTSNAME; s = pkg->suggests;  break;
+  case 4:  tag = RPMTAG_RECOMMENDNAME;s = pkg->suggests; break;
   default: tag = RPMTAG_OBSOLETENAME; s = pkg->obsoletes; break;
   }
   return_list_str(s, pkg->h, tag, 0, 0, callback_list_str_xpush, NULL);